From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Zenghui Yu <yuzenghui@huawei.com>, will@kernel.org
Cc: guohanjun@huawei.com, sudeep.holla@arm.com, rjw@rjwysocki.net,
lenb@kernel.org, linux-acpi@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, wanghaibin.wang@huawei.com
Subject: Re: [PATCH] ACPI/IORT: Remove the unused __get_pci_rid()
Date: Tue, 26 May 2020 14:07:52 +0100 [thread overview]
Message-ID: <20200526130752.GA23951@e121166-lin.cambridge.arm.com> (raw)
In-Reply-To: <20200509093430.1983-1-yuzenghui@huawei.com>
On Sat, May 09, 2020 at 05:34:30PM +0800, Zenghui Yu wrote:
> Since commit bc8648d49a95 ("ACPI/IORT: Handle PCI aliases properly for
> IOMMUs"), __get_pci_rid() has become actually unused and can be removed.
>
> Signed-off-by: Zenghui Yu <yuzenghui@huawei.com>
> ---
> drivers/acpi/arm64/iort.c | 9 ---------
> 1 file changed, 9 deletions(-)
Acked-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
If we miss v5.8 (which I think it is likely, even though this patch is
just removing dead code so it is safe at this stage) I will resend it
for v5.9 - not a problem.
Lorenzo
> diff --git a/drivers/acpi/arm64/iort.c b/drivers/acpi/arm64/iort.c
> index 7d04424189df..ec94dbb60c7a 100644
> --- a/drivers/acpi/arm64/iort.c
> +++ b/drivers/acpi/arm64/iort.c
> @@ -789,15 +789,6 @@ void acpi_configure_pmsi_domain(struct device *dev)
> dev_set_msi_domain(dev, msi_domain);
> }
>
> -static int __maybe_unused __get_pci_rid(struct pci_dev *pdev, u16 alias,
> - void *data)
> -{
> - u32 *rid = data;
> -
> - *rid = alias;
> - return 0;
> -}
> -
> #ifdef CONFIG_IOMMU_API
> static struct acpi_iort_node *iort_get_msi_resv_iommu(struct device *dev)
> {
> --
> 2.19.1
>
next prev parent reply other threads:[~2020-05-26 13:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-09 9:34 [PATCH] ACPI/IORT: Remove the unused __get_pci_rid() Zenghui Yu
2020-05-09 9:56 ` Hanjun Guo
2020-05-25 4:00 ` Zenghui Yu
2020-05-26 13:07 ` Lorenzo Pieralisi [this message]
2020-05-26 20:45 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200526130752.GA23951@e121166-lin.cambridge.arm.com \
--to=lorenzo.pieralisi@arm.com \
--cc=guohanjun@huawei.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=sudeep.holla@arm.com \
--cc=wanghaibin.wang@huawei.com \
--cc=will@kernel.org \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).