From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC94BC433E0 for ; Mon, 6 Jul 2020 23:13:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 972E520771 for ; Mon, 6 Jul 2020 23:13:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726933AbgGFXND (ORCPT ); Mon, 6 Jul 2020 19:13:03 -0400 Received: from mga01.intel.com ([192.55.52.88]:10923 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726366AbgGFXNC (ORCPT ); Mon, 6 Jul 2020 19:13:02 -0400 IronPort-SDR: uDyzR1C+slFXilinK50G9L6qXGA8SNAJub/C8yLOQaLro+UWXXwqMx8Du1fod6fZWi1Wm90BgP q6asZYtiUHUQ== X-IronPort-AV: E=McAfee;i="6000,8403,9674"; a="165586810" X-IronPort-AV: E=Sophos;i="5.75,321,1589266800"; d="scan'208";a="165586810" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jul 2020 16:13:02 -0700 IronPort-SDR: 6TYtgomBXFRuWGlr6JvObSFiQlFGAAPw/oIykjZRlCpvfsdy2v1EYHYM1P2FyNzP863EBiGoVg 3C3mDQQGa6mg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,321,1589266800"; d="scan'208";a="323354356" Received: from hartmaxe-mobl1.ger.corp.intel.com (HELO localhost) ([10.252.53.13]) by orsmga007.jf.intel.com with ESMTP; 06 Jul 2020 16:12:58 -0700 Date: Tue, 7 Jul 2020 02:12:57 +0300 From: Jarkko Sakkinen To: Stefan Berger Cc: linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-security-module@vger.kernel.org, Stefan Berger Subject: Re: [PATCH v9 2/2] tpm: Add support for event log pointer found in TPM2 ACPI table Message-ID: <20200706231257.GD20770@linux.intel.com> References: <20200706181953.3592084-1-stefanb@linux.vnet.ibm.com> <20200706181953.3592084-3-stefanb@linux.vnet.ibm.com> <20200706230914.GC20770@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200706230914.GC20770@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Tue, Jul 07, 2020 at 02:09:18AM +0300, Jarkko Sakkinen wrote: > On Mon, Jul 06, 2020 at 02:19:53PM -0400, Stefan Berger wrote: > > From: Stefan Berger > > > > In case a TPM2 is attached, search for a TPM2 ACPI table when trying > > to get the event log from ACPI. If one is found, use it to get the > > start and length of the log area. This allows non-UEFI systems, such > > as SeaBIOS, to pass an event log when using a TPM2. > > > > Signed-off-by: Stefan Berger > > Do you think that QEMU with TPM 1.2 emulator turned on would be a viable > way to test this? > > I'm anyway more worried about breaking existing TPM 1.2 functionality > and that requires only QEMU without extras. BTW, you should cc your patches to all M- and R-entries in the MAINTAINERS file. Please, resend this patch set version. You can add acquired reviewed-by and tested-by tags (e.g. Jerry's) and use this tag for the patch set: "RESEND,PATCH v9". /Jarkko