From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Linux PM <linux-pm@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Linux ACPI <linux-acpi@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>
Subject: Re: [PATCH] PM: sleep: core: Fix the handling of pending runtime resume requests
Date: Mon, 24 Aug 2020 11:34:52 +0300 [thread overview]
Message-ID: <20200824083452.GX1375436@lahna.fi.intel.com> (raw)
In-Reply-To: <20200821193442.GA264863@rowland.harvard.edu>
Hi,
On Fri, Aug 21, 2020 at 03:34:42PM -0400, Alan Stern wrote:
> This means that the code could be simplified to just:
>
> pm_runtime_barrier(dev);
>
> Will this fix the reported bug? It seems likely to me that the actual
> problem with the failure scenario in the patch description was that
> turning on an ACPI power resource causes runtime-resume requests to be
> queued for all devices sharing that resource. Wouldn't it make more
> sense to resume only the device that requested it and leave the others
> in runtime suspend?
The problem with at least PCIe devices that share ACPI power resources
is that once you turn on the power resource all the devices that shared
it will go into D0uninitialized power state and that means they lose all
wake configuration etc. so they need to be re-initialized by their
driver before they can go back to D3(cold) in order for their wakes to
still work.
next prev parent reply other threads:[~2020-08-24 8:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-21 17:41 [PATCH] PM: sleep: core: Fix the handling of pending runtime resume requests Rafael J. Wysocki
2020-08-21 19:34 ` Alan Stern
2020-08-24 8:34 ` Mika Westerberg [this message]
2020-08-24 13:38 ` Rafael J. Wysocki
2020-08-24 13:59 ` Mika Westerberg
2020-08-24 13:36 ` Rafael J. Wysocki
2020-08-24 15:04 ` Alan Stern
2020-08-24 17:31 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200824083452.GX1375436@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).