linux-acpi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Wolfram Sang <wsa@kernel.org>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>,
	linux-acpi@vger.kernel.org, linux-i2c@vger.kernel.org
Subject: Re: [PATCH v1 1/2] i2c: core: Don't fail PRP0001 enumeration when no ID table exist
Date: Tue, 25 Aug 2020 13:12:52 +0300	[thread overview]
Message-ID: <20200825101252.GT1891694@smile.fi.intel.com> (raw)
In-Reply-To: <20200825072314.GD1861@ninjato>

On Tue, Aug 25, 2020 at 09:23:14AM +0200, Wolfram Sang wrote:
> On Fri, Aug 21, 2020 at 08:03:33PM +0300, Andy Shevchenko wrote:
> > When commit c64ffff7a9d1 ("i2c: core: Allow empty id_table in ACPI case
> > as well") fixed the enumeration of I²C devices on ACPI enabled platforms
> > when driver has no ID table, it missed the PRP0001 support.
> > 
> > i2c_device_match() and i2c_acpi_match_device() differently match
> > driver against given device. Use acpi_driver_match_device(), that is used
> > in the former, in i2c_device_probe() and don't fail PRP0001 enumeration
> > when no ID table exist.
> > 
> > Fixes: c64ffff7a9d1 ("i2c: core: Allow empty id_table in ACPI case as well")
> > BugLink: https://stackoverflow.com/q/63519678/2511795
> 
> You are monitoring SO? Nice.

Monitoring is probably too strong word here, rather sometimes looking for
interesting topics (mostly related to ACPI + Linux (kernel) and near to them).

This makes me wonder how many commits are actually referring to SO.
The 1st one I found is 8c88f87cb27a ("netfilter: nfnetlink_queue: add NAT TCP
sequence adjustment if packet mangled"). Some of them referring stackexchange
site, but not many (brief estimation like a couple of dozens at most).

> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> 
> Applied to for-current, thanks!

Thanks!

-- 
With Best Regards,
Andy Shevchenko



      reply	other threads:[~2020-08-25 10:13 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-21 17:03 [PATCH v1 1/2] i2c: core: Don't fail PRP0001 enumeration when no ID table exist Andy Shevchenko
2020-08-21 17:03 ` [PATCH v1 2/2] i2c: acpi: Remove dead code, i.e. i2c_acpi_match_device() Andy Shevchenko
2020-08-24  8:42   ` Mika Westerberg
2020-08-25  7:23   ` Wolfram Sang
2020-08-24  8:41 ` [PATCH v1 1/2] i2c: core: Don't fail PRP0001 enumeration when no ID table exist Mika Westerberg
2020-08-25  7:23 ` Wolfram Sang
2020-08-25 10:12   ` Andy Shevchenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200825101252.GT1891694@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    --cc=wsa@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).