From: Christoph Hellwig <hch@lst.de>
To: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: Christoph Hellwig <hch@lst.de>,
iommu@lists.linux-foundation.org,
Russell King <linux@armlinux.org.uk>,
Santosh Shilimkar <ssantosh@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jim Quinlan <james.quinlan@broadcom.com>,
Nathan Chancellor <natechancellor@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Robin Murphy <robin.murphy@arm.com>,
Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
Ohad Ben-Cohen <ohad@wizery.com>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
linux-remoteproc@vger.kernel.org, linux-usb@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-sh@vger.kernel.org,
linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org,
devicetree@vger.kernel.org, arnaud.pouliquen@st.com,
loic.pallardy.st.com@lst.de
Subject: Re: [PATCH 6/6] dma-mapping: introduce DMA range map, supplanting dma_pfn_offset
Date: Tue, 15 Sep 2020 07:41:22 +0200 [thread overview]
Message-ID: <20200915054122.GA18079@lst.de> (raw)
In-Reply-To: <20200914230147.GA3251212@xps15>
On Mon, Sep 14, 2020 at 05:01:47PM -0600, Mathieu Poirier wrote:
[700 lines of the fullquote deleted..]
> > + for (r = map; r->size; r++)
> > + num_ranges++;
> > +
> > + new_map = kmemdup(map, array_size(num_ranges + 1, sizeof(*map)),
> > + GFP_KERNEL);
> > + if (!new_map)
> > + return -ENOMEM;
> > + to->dma_range_map = new_map;
> > + return 0;
> > +}
> > +
>
> This patch seemed Ok to me but it broke the stm32 remoteproc implementation. When
> I tested things out function dma_coerce_mask_and_cohenrent() returns -5 and the
> rest of the initialisation fails. I isolated things to function dma_to_pfn()
> [2]. In the original implementation __bus_to_pfn() returns 0xfffff and
> dev->dma_pfn_offset is equal to 0x38000. As such the function returns 0x137fff
> and dma_supported() a non-zero value[3].
>
> With this set function dma_to_pfn() received a face lift. Function
> __bus_to_pfn() still returns 0xfffff but translate_dma_to_phys() returns 0,
> which forces dma_supported() to also return 0 and that is where the -5 (-EIO)
> comes from.
>
> Taking a futher look at translate_dma_to_phy(), @dma_addr never falls within the
> bus_dma_region ranges and returns 0.
>
> I'm suspecting an initialisation problem and if it occurred here, it will
> likely show up elsewhere.
Can you try this incremental patch?
diff --git a/include/linux/dma-direct.h b/include/linux/dma-direct.h
index 088c97181ab146..c6b21acba7a459 100644
--- a/include/linux/dma-direct.h
+++ b/include/linux/dma-direct.h
@@ -46,7 +46,7 @@ static inline phys_addr_t translate_dma_to_phys(struct device *dev,
if (dma_addr >= m->dma_start && dma_addr - m->dma_start < m->size)
return (phys_addr_t)dma_addr + m->offset;
- return 0;
+ return (phys_addr_t)-1;
}
#ifdef CONFIG_ARCH_HAS_PHYS_TO_DMA
next prev parent reply other threads:[~2020-09-15 5:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-14 7:33 support range based offsets in dma-direct v2 Christoph Hellwig
2020-09-14 7:33 ` [PATCH 1/6] ARM/dma-mapping: remove a __arch_page_to_dma #error Christoph Hellwig
2020-09-14 7:33 ` [PATCH 2/6] ARM/dma-mapping: remove dma_to_virt Christoph Hellwig
2020-09-14 7:33 ` [PATCH 3/6] ARM/dma-mapping: move various helpers from dma-mapping.h to dma-direct.h Christoph Hellwig
2020-09-14 7:33 ` [PATCH 4/6] ARM/keystone: move the DMA offset handling under ifdef CONFIG_ARM_LPAE Christoph Hellwig
2020-09-14 7:33 ` [PATCH 5/6] usb: don't inherity DMA properties for USB devices Christoph Hellwig
2020-09-14 7:51 ` Greg Kroah-Hartman
2020-09-14 7:33 ` [PATCH 6/6] dma-mapping: introduce DMA range map, supplanting dma_pfn_offset Christoph Hellwig
2020-09-14 23:01 ` Mathieu Poirier
2020-09-15 5:41 ` Christoph Hellwig [this message]
2020-09-15 19:55 ` Mathieu Poirier
2020-09-16 6:13 ` Christoph Hellwig
2020-09-16 6:14 support range based offsets in dma-direct v3 Christoph Hellwig
2020-09-16 6:14 ` [PATCH 6/6] dma-mapping: introduce DMA range map, supplanting dma_pfn_offset Christoph Hellwig
2020-09-16 17:36 ` Mathieu Poirier
2020-10-26 15:33 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200915054122.GA18079@lst.de \
--to=hch@lst.de \
--cc=arnaud.pouliquen@st.com \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=frowand.list@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=iommu@lists.linux-foundation.org \
--cc=james.quinlan@broadcom.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=loic.pallardy.st.com@lst.de \
--cc=mathieu.poirier@linaro.org \
--cc=natechancellor@gmail.com \
--cc=ohad@wizery.com \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
--cc=ssantosh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).