From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 283B3C4727E for ; Sat, 26 Sep 2020 16:29:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BE25021527 for ; Sat, 26 Sep 2020 16:29:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="flBuDFjy" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730169AbgIZQ3e (ORCPT ); Sat, 26 Sep 2020 12:29:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40638 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730166AbgIZQ32 (ORCPT ); Sat, 26 Sep 2020 12:29:28 -0400 Received: from mail-pj1-x1043.google.com (mail-pj1-x1043.google.com [IPv6:2607:f8b0:4864:20::1043]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 63A1EC0613D4 for ; Sat, 26 Sep 2020 09:29:28 -0700 (PDT) Received: by mail-pj1-x1043.google.com with SMTP id q4so1112466pjh.5 for ; Sat, 26 Sep 2020 09:29:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ReZsLvHBneH04N8Loq9YJ9S6MWNTP72CPq7StQtiUsk=; b=flBuDFjylqO4PcpY2bHDwc92sMi/0GbduSVdkuQNfd88bmVK6DfigGBFUH2QBccrk2 385Yim03CnMzoMGY7oZWhtOHqZer6SqZzNEY4WhKUkcI+yagFY8N4xPq4loZU+jTLeex HDG74TDBdazjHstF7s1FoKEAo65tC4nQ0BeU4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ReZsLvHBneH04N8Loq9YJ9S6MWNTP72CPq7StQtiUsk=; b=VCe6wSMNCykVrP2iJMRo8JTCcdlceXu+XJp64gVZEZLYpFTaAVabOX7TuWpx53vtbE ZkUqDkejKmo7QWQAU7P6Mxd0Og1WuMm+2G6tWBOoRdMi2bzo1+fcNIXQ+UT9jv/5RktT gXrQG/+tEHVIKIeN98mLqW1N2wFFfEPsIbeAa33X180AP+mXIau8zHf1PnYyUpmEJwVb WjcwPEgUIBc/Gnxhr4DuiDuxB1num0305j71re/9LNTyuOYkYo9ooARSTbir9gzdOZKU uZP/Izn2w+W3hFnycsKN+eqXFvQf42tjWhqcVpBtQb2Y39q8lh03RhX48qs0REBp3FT0 IvzA== X-Gm-Message-State: AOAM533NaeCaTmtQLTySzDozY7MUamKBePxt4jCuyAbtZYTEwuhziFy9 IaVxJybv1kseodqZCNyPRkNLfQ== X-Google-Smtp-Source: ABdhPJwd4IF1Fz4/85gg89M2RFijczjSa7iLtSh9kaFyp2cYD7D9Izg0ei9xFdzpxZhcWY/9odrHmw== X-Received: by 2002:a17:902:b7c8:b029:d0:cbe1:e7b2 with SMTP id v8-20020a170902b7c8b02900d0cbe1e7b2mr4320915plz.35.1601137767826; Sat, 26 Sep 2020 09:29:27 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id q16sm6358555pfj.117.2020.09.26.09.29.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 26 Sep 2020 09:29:27 -0700 (PDT) Date: Sat, 26 Sep 2020 09:29:26 -0700 From: Kees Cook To: Shuah Khan Cc: corbet@lwn.net, gregkh@linuxfoundation.org, shuah@kernel.org, rafael@kernel.org, johannes@sipsolutions.net, lenb@kernel.org, james.morse@arm.com, tony.luck@intel.com, bp@alien8.de, arve@android.com, tkjos@android.com, maco@android.com, joel@joelfernandes.org, christian@brauner.io, hridya@google.com, surenb@google.com, minyard@acm.org, arnd@arndb.de, mchehab@kernel.org, rric@kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-acpi@vger.kernel.org, devel@driverdev.osuosl.org, openipmi-developer@lists.sourceforge.net, linux-edac@vger.kernel.org Subject: Re: [PATCH 00/11] Introduce Simple atomic and non-atomic counters Message-ID: <202009260923.9A2606CFF6@keescook> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Fri, Sep 25, 2020 at 05:47:14PM -0600, Shuah Khan wrote: > 7. Verified that the test module compiles in kunit env. and test > module can be loaded to run the test. I meant write it using KUnit interfaces (e.g. KUNIT_EXPECT*(), kunit_test_suite(), etc): https://www.kernel.org/doc/html/latest/dev-tools/kunit/ Though I see the docs are still not updated[1] to reflect the Kconfig (CONFIG_foo_KUNIT_TEST) and file naming conventions (foo_kunit.c). -Kees [1] https://lore.kernel.org/lkml/20200911042404.3598910-1-davidgow@google.com/ -- Kees Cook