From: Alex Hung <alex.hung@canonical.com>
To: rjw@rjwysocki.net, lenb@kernel.org, linux-acpi@vger.kernel.org,
alex.hung@canonical.com
Subject: [PATCH] ACPI: processor: remove unnecessary string _UID comments
Date: Tue, 13 Oct 2020 19:03:40 -0600 [thread overview]
Message-ID: <20201014010340.433398-1-alex.hung@canonical.com> (raw)
ACPI 6.3 Errata A no longer allows _UID to be string except Itanium
for historical reasons as stated in section 5.2.12. Therefore, it is
redundant to comment "we don't handle string _UIDs yet" which implies a
feature is missing.
"From ACPI Specification 6.3 onward, all processor objects for all
architectures except Itanium must now use Device() objects with an _HID
of ACPI0007, and use only integer _UID values."
Signed-off-by: Alex Hung <alex.hung@canonical.com>
---
drivers/acpi/acpi_processor.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/acpi/acpi_processor.c b/drivers/acpi/acpi_processor.c
index b51ddf3..710605f 100644
--- a/drivers/acpi/acpi_processor.c
+++ b/drivers/acpi/acpi_processor.c
@@ -264,7 +264,6 @@ static int acpi_processor_get_info(struct acpi_device *device)
} else {
/*
* Declared with "Device" statement; match _UID.
- * Note that we don't handle string _UIDs yet.
*/
status = acpi_evaluate_integer(pr->handle, METHOD_NAME__UID,
NULL, &value);
--
2.7.4
next reply other threads:[~2020-10-14 1:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-14 1:03 Alex Hung [this message]
2020-10-16 16:14 ` [PATCH] ACPI: processor: remove unnecessary string _UID comments Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201014010340.433398-1-alex.hung@canonical.com \
--to=alex.hung@canonical.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).