Linux-ACPI Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH 0/2] ACPI: DPTF: Driver name fixes and Kconfig update
@ 2020-10-15 16:57 Rafael J. Wysocki
  2020-10-15 16:58 ` [PATCH 1/2] ACPI: DPTF: Fix participant driver names Rafael J. Wysocki
  2020-10-15 16:59 ` [PATCH 2/2] ACPI: DPTF: Add ACPI_DPTF Kconfig menu Rafael J. Wysocki
  0 siblings, 2 replies; 7+ messages in thread
From: Rafael J. Wysocki @ 2020-10-15 16:57 UTC (permalink / raw)
  To: Linux ACPI; +Cc: LKML, Srinivas Pandruvada, Borislav Petkov

Hi,

These patches fix the names of two DPTF drivers to adhere to the sysfs file
naming conventions and rework the DPTF part of Kconfig.

Please refer to the patch changelogs for details.

Thanks!




^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH 1/2] ACPI: DPTF: Fix participant driver names
  2020-10-15 16:57 [PATCH 0/2] ACPI: DPTF: Driver name fixes and Kconfig update Rafael J. Wysocki
@ 2020-10-15 16:58 ` Rafael J. Wysocki
  2020-10-15 19:47   ` Srinivas Pandruvada
  2020-10-16  8:23   ` Borislav Petkov
  2020-10-15 16:59 ` [PATCH 2/2] ACPI: DPTF: Add ACPI_DPTF Kconfig menu Rafael J. Wysocki
  1 sibling, 2 replies; 7+ messages in thread
From: Rafael J. Wysocki @ 2020-10-15 16:58 UTC (permalink / raw)
  To: Linux ACPI; +Cc: LKML, Srinivas Pandruvada, Borislav Petkov

From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

Change the names of DPTF participant drivers to adhere to the
sysfs file naming conventions (no spaces present in the name in
particular).

Fixes: 2ce6324eadb0 ("ACPI: DPTF: Add PCH FIVR participant driver")
Fixes: 6256ebd5daf9 ("ACPI / DPTF: Add DPTF power participant driver")
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
 drivers/acpi/dptf/dptf_pch_fivr.c |    2 +-
 drivers/acpi/dptf/dptf_power.c    |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Index: linux-pm/drivers/acpi/dptf/dptf_pch_fivr.c
===================================================================
--- linux-pm.orig/drivers/acpi/dptf/dptf_pch_fivr.c
+++ linux-pm/drivers/acpi/dptf/dptf_pch_fivr.c
@@ -114,7 +114,7 @@ static struct platform_driver pch_fivr_d
 	.probe = pch_fivr_add,
 	.remove = pch_fivr_remove,
 	.driver = {
-		.name = "DPTF PCH FIVR",
+		.name = "dptf_pch_fivr",
 		.acpi_match_table = pch_fivr_device_ids,
 	},
 };
Index: linux-pm/drivers/acpi/dptf/dptf_power.c
===================================================================
--- linux-pm.orig/drivers/acpi/dptf/dptf_power.c
+++ linux-pm/drivers/acpi/dptf/dptf_power.c
@@ -237,7 +237,7 @@ static struct platform_driver dptf_power
 	.probe = dptf_power_add,
 	.remove = dptf_power_remove,
 	.driver = {
-		.name = "DPTF Platform Power",
+		.name = "dptf_power",
 		.acpi_match_table = int3407_device_ids,
 	},
 };




^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH 2/2] ACPI: DPTF: Add ACPI_DPTF Kconfig menu
  2020-10-15 16:57 [PATCH 0/2] ACPI: DPTF: Driver name fixes and Kconfig update Rafael J. Wysocki
  2020-10-15 16:58 ` [PATCH 1/2] ACPI: DPTF: Fix participant driver names Rafael J. Wysocki
@ 2020-10-15 16:59 ` Rafael J. Wysocki
  2020-10-15 19:46   ` Srinivas Pandruvada
  2020-10-16  8:25   ` Borislav Petkov
  1 sibling, 2 replies; 7+ messages in thread
From: Rafael J. Wysocki @ 2020-10-15 16:59 UTC (permalink / raw)
  To: Linux ACPI; +Cc: LKML, Srinivas Pandruvada, Borislav Petkov

From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

Add a Kconfig menu for Intel DPTF (Dynamic Platform and Thermal
Framework), put both the existing participant drivers in it and set
them to be built as modules by default.

While at it, do a few assorted cleanups for a good measure.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
 drivers/acpi/dptf/Kconfig |   29 ++++++++++++++++++++++++-----
 1 file changed, 24 insertions(+), 5 deletions(-)

Index: linux-pm/drivers/acpi/dptf/Kconfig
===================================================================
--- linux-pm.orig/drivers/acpi/dptf/Kconfig
+++ linux-pm/drivers/acpi/dptf/Kconfig
@@ -1,8 +1,25 @@
 # SPDX-License-Identifier: GPL-2.0
-config DPTF_POWER
-	tristate "DPTF Platform Power Participant"
+
+menuconfig ACPI_DPTF
+	bool "Intel DPTF (Dynamic Platform and Thermal Framework) Support"
 	depends on X86
 	help
+	  Intel Dynamic Platform and Thermal Framework (DPTF) is a platform
+	  level hardware/software solution for power and thermal management.
+
+	  As a container for multiple power/thermal technologies, DPTF provides
+	  a coordinated approach for different policies to effect the hardware
+	  state of a system.
+
+	  For more information see:
+	  <https://01.org/intel%C2%AE-dynamic-platform-and-thermal-framework-dptf-chromium-os/overview>
+
+if ACPI_DPTF
+
+config DPTF_POWER
+	tristate "Platform Power DPTF Participant"
+	default m
+	help
 	  This driver adds support for Dynamic Platform and Thermal Framework
 	  (DPTF) Platform Power Participant device (INT3407) support.
 	  This participant is responsible for exposing platform telemetry:
@@ -16,15 +33,17 @@ config DPTF_POWER
 	  the module will be called dptf_power.
 
 config DPTF_PCH_FIVR
-	tristate "DPTF PCH FIVR Participant"
-	depends on X86
+	tristate "PCH FIVR DPTF Participant"
+	default m
 	help
 	  This driver adds support for Dynamic Platform and Thermal Framework
 	  (DPTF) PCH FIVR Participant device support. This driver allows to
-	  switch PCH FIVR (Fully Integrated Voltage Regulator) frequency.
+	  switch the PCH FIVR (Fully Integrated Voltage Regulator) frequency.
 	  This participant is responsible for exposing:
 		freq_mhz_low_clock
 		freq_mhz_high_clock
 
 	  To compile this driver as a module, choose M here:
 	  the module will be called dptf_pch_fivr.
+
+endif




^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 2/2] ACPI: DPTF: Add ACPI_DPTF Kconfig menu
  2020-10-15 16:59 ` [PATCH 2/2] ACPI: DPTF: Add ACPI_DPTF Kconfig menu Rafael J. Wysocki
@ 2020-10-15 19:46   ` Srinivas Pandruvada
  2020-10-16  8:25   ` Borislav Petkov
  1 sibling, 0 replies; 7+ messages in thread
From: Srinivas Pandruvada @ 2020-10-15 19:46 UTC (permalink / raw)
  To: Rafael J. Wysocki, Linux ACPI; +Cc: LKML, Borislav Petkov

On Thu, 2020-10-15 at 18:59 +0200, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> 
> Add a Kconfig menu for Intel DPTF (Dynamic Platform and Thermal
> Framework), put both the existing participant drivers in it and set
> them to be built as modules by default.
> 
> While at it, do a few assorted cleanups for a good measure.
> 
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Reviewed-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>

> ---
>  drivers/acpi/dptf/Kconfig |   29 ++++++++++++++++++++++++-----
>  1 file changed, 24 insertions(+), 5 deletions(-)
> 
> Index: linux-pm/drivers/acpi/dptf/Kconfig
> ===================================================================
> --- linux-pm.orig/drivers/acpi/dptf/Kconfig
> +++ linux-pm/drivers/acpi/dptf/Kconfig
> @@ -1,8 +1,25 @@
>  # SPDX-License-Identifier: GPL-2.0
> -config DPTF_POWER
> -	tristate "DPTF Platform Power Participant"
> +
> +menuconfig ACPI_DPTF
> +	bool "Intel DPTF (Dynamic Platform and Thermal Framework)
> Support"
>  	depends on X86
>  	help
> +	  Intel Dynamic Platform and Thermal Framework (DPTF) is a
> platform
> +	  level hardware/software solution for power and thermal
> management.
> +
> +	  As a container for multiple power/thermal technologies, DPTF
> provides
> +	  a coordinated approach for different policies to effect the
> hardware
> +	  state of a system.
> +
> +	  For more information see:
> +	  <
> https://01.org/intel%C2%AE-dynamic-platform-and-thermal-framework-dptf-chromium-os/overview
> >
> +
> +if ACPI_DPTF
> +
> +config DPTF_POWER
> +	tristate "Platform Power DPTF Participant"
> +	default m
> +	help
>  	  This driver adds support for Dynamic Platform and Thermal
> Framework
>  	  (DPTF) Platform Power Participant device (INT3407) support.
>  	  This participant is responsible for exposing platform
> telemetry:
> @@ -16,15 +33,17 @@ config DPTF_POWER
>  	  the module will be called dptf_power.
>  
>  config DPTF_PCH_FIVR
> -	tristate "DPTF PCH FIVR Participant"
> -	depends on X86
> +	tristate "PCH FIVR DPTF Participant"
> +	default m
>  	help
>  	  This driver adds support for Dynamic Platform and Thermal
> Framework
>  	  (DPTF) PCH FIVR Participant device support. This driver
> allows to
> -	  switch PCH FIVR (Fully Integrated Voltage Regulator)
> frequency.
> +	  switch the PCH FIVR (Fully Integrated Voltage Regulator)
> frequency.
>  	  This participant is responsible for exposing:
>  		freq_mhz_low_clock
>  		freq_mhz_high_clock
>  
>  	  To compile this driver as a module, choose M here:
>  	  the module will be called dptf_pch_fivr.
> +
> +endif
> 
> 
> 


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 1/2] ACPI: DPTF: Fix participant driver names
  2020-10-15 16:58 ` [PATCH 1/2] ACPI: DPTF: Fix participant driver names Rafael J. Wysocki
@ 2020-10-15 19:47   ` Srinivas Pandruvada
  2020-10-16  8:23   ` Borislav Petkov
  1 sibling, 0 replies; 7+ messages in thread
From: Srinivas Pandruvada @ 2020-10-15 19:47 UTC (permalink / raw)
  To: Rafael J. Wysocki, Linux ACPI; +Cc: LKML, Borislav Petkov

On Thu, 2020-10-15 at 18:58 +0200, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> 
> Change the names of DPTF participant drivers to adhere to the
> sysfs file naming conventions (no spaces present in the name in
> particular).
> 
> Fixes: 2ce6324eadb0 ("ACPI: DPTF: Add PCH FIVR participant driver")
> Fixes: 6256ebd5daf9 ("ACPI / DPTF: Add DPTF power participant
> driver")
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Reviewed-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>

> ---
>  drivers/acpi/dptf/dptf_pch_fivr.c |    2 +-
>  drivers/acpi/dptf/dptf_power.c    |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> Index: linux-pm/drivers/acpi/dptf/dptf_pch_fivr.c
> ===================================================================
> --- linux-pm.orig/drivers/acpi/dptf/dptf_pch_fivr.c
> +++ linux-pm/drivers/acpi/dptf/dptf_pch_fivr.c
> @@ -114,7 +114,7 @@ static struct platform_driver pch_fivr_d
>  	.probe = pch_fivr_add,
>  	.remove = pch_fivr_remove,
>  	.driver = {
> -		.name = "DPTF PCH FIVR",
> +		.name = "dptf_pch_fivr",
>  		.acpi_match_table = pch_fivr_device_ids,
>  	},
>  };
> Index: linux-pm/drivers/acpi/dptf/dptf_power.c
> ===================================================================
> --- linux-pm.orig/drivers/acpi/dptf/dptf_power.c
> +++ linux-pm/drivers/acpi/dptf/dptf_power.c
> @@ -237,7 +237,7 @@ static struct platform_driver dptf_power
>  	.probe = dptf_power_add,
>  	.remove = dptf_power_remove,
>  	.driver = {
> -		.name = "DPTF Platform Power",
> +		.name = "dptf_power",
>  		.acpi_match_table = int3407_device_ids,
>  	},
>  };
> 
> 
> 


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 1/2] ACPI: DPTF: Fix participant driver names
  2020-10-15 16:58 ` [PATCH 1/2] ACPI: DPTF: Fix participant driver names Rafael J. Wysocki
  2020-10-15 19:47   ` Srinivas Pandruvada
@ 2020-10-16  8:23   ` Borislav Petkov
  1 sibling, 0 replies; 7+ messages in thread
From: Borislav Petkov @ 2020-10-16  8:23 UTC (permalink / raw)
  To: Rafael J. Wysocki; +Cc: Linux ACPI, LKML, Srinivas Pandruvada

On Thu, Oct 15, 2020 at 06:58:43PM +0200, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> 
> Change the names of DPTF participant drivers to adhere to the
> sysfs file naming conventions (no spaces present in the name in
> particular).
> 
> Fixes: 2ce6324eadb0 ("ACPI: DPTF: Add PCH FIVR participant driver")
> Fixes: 6256ebd5daf9 ("ACPI / DPTF: Add DPTF power participant driver")
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> ---
>  drivers/acpi/dptf/dptf_pch_fivr.c |    2 +-
>  drivers/acpi/dptf/dptf_power.c    |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> Index: linux-pm/drivers/acpi/dptf/dptf_pch_fivr.c
> ===================================================================
> --- linux-pm.orig/drivers/acpi/dptf/dptf_pch_fivr.c
> +++ linux-pm/drivers/acpi/dptf/dptf_pch_fivr.c
> @@ -114,7 +114,7 @@ static struct platform_driver pch_fivr_d
>  	.probe = pch_fivr_add,
>  	.remove = pch_fivr_remove,
>  	.driver = {
> -		.name = "DPTF PCH FIVR",
> +		.name = "dptf_pch_fivr",
>  		.acpi_match_table = pch_fivr_device_ids,
>  	},
>  };
> Index: linux-pm/drivers/acpi/dptf/dptf_power.c
> ===================================================================
> --- linux-pm.orig/drivers/acpi/dptf/dptf_power.c
> +++ linux-pm/drivers/acpi/dptf/dptf_power.c
> @@ -237,7 +237,7 @@ static struct platform_driver dptf_power
>  	.probe = dptf_power_add,
>  	.remove = dptf_power_remove,
>  	.driver = {
> -		.name = "DPTF Platform Power",
> +		.name = "dptf_power",
>  		.acpi_match_table = int3407_device_ids,
>  	},
>  };

Acked-by: Borislav Petkov <bp@suse.de>

-- 
Regards/Gruss,
    Boris.

SUSE Software Solutions Germany GmbH, GF: Felix Imendörffer, HRB 36809, AG Nürnberg

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 2/2] ACPI: DPTF: Add ACPI_DPTF Kconfig menu
  2020-10-15 16:59 ` [PATCH 2/2] ACPI: DPTF: Add ACPI_DPTF Kconfig menu Rafael J. Wysocki
  2020-10-15 19:46   ` Srinivas Pandruvada
@ 2020-10-16  8:25   ` Borislav Petkov
  1 sibling, 0 replies; 7+ messages in thread
From: Borislav Petkov @ 2020-10-16  8:25 UTC (permalink / raw)
  To: Rafael J. Wysocki; +Cc: Linux ACPI, LKML, Srinivas Pandruvada

On Thu, Oct 15, 2020 at 06:59:52PM +0200, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> 
> Add a Kconfig menu for Intel DPTF (Dynamic Platform and Thermal
> Framework), put both the existing participant drivers in it and set
> them to be built as modules by default.
> 
> While at it, do a few assorted cleanups for a good measure.
> 
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> ---
>  drivers/acpi/dptf/Kconfig |   29 ++++++++++++++++++++++++-----
>  1 file changed, 24 insertions(+), 5 deletions(-)
> 
> Index: linux-pm/drivers/acpi/dptf/Kconfig
> ===================================================================
> --- linux-pm.orig/drivers/acpi/dptf/Kconfig
> +++ linux-pm/drivers/acpi/dptf/Kconfig
> @@ -1,8 +1,25 @@
>  # SPDX-License-Identifier: GPL-2.0
> -config DPTF_POWER
> -	tristate "DPTF Platform Power Participant"
> +
> +menuconfig ACPI_DPTF
> +	bool "Intel DPTF (Dynamic Platform and Thermal Framework) Support"
>  	depends on X86
>  	help
> +	  Intel Dynamic Platform and Thermal Framework (DPTF) is a platform
> +	  level hardware/software solution for power and thermal management.
> +
> +	  As a container for multiple power/thermal technologies, DPTF provides
> +	  a coordinated approach for different policies to effect the hardware
> +	  state of a system.
> +
> +	  For more information see:
> +	  <https://01.org/intel%C2%AE-dynamic-platform-and-thermal-framework-dptf-chromium-os/overview>

Oh wow, they have a "(r)" for all rights reserved *in* *the* *URL*. OMG.

But yeah:

Acked-by: Borislav Petkov <bp@suse.de>

Thx Rafael.

-- 
Regards/Gruss,
    Boris.

SUSE Software Solutions Germany GmbH, GF: Felix Imendörffer, HRB 36809, AG Nürnberg

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, back to index

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-15 16:57 [PATCH 0/2] ACPI: DPTF: Driver name fixes and Kconfig update Rafael J. Wysocki
2020-10-15 16:58 ` [PATCH 1/2] ACPI: DPTF: Fix participant driver names Rafael J. Wysocki
2020-10-15 19:47   ` Srinivas Pandruvada
2020-10-16  8:23   ` Borislav Petkov
2020-10-15 16:59 ` [PATCH 2/2] ACPI: DPTF: Add ACPI_DPTF Kconfig menu Rafael J. Wysocki
2020-10-15 19:46   ` Srinivas Pandruvada
2020-10-16  8:25   ` Borislav Petkov

Linux-ACPI Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-acpi/0 linux-acpi/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-acpi linux-acpi/ https://lore.kernel.org/linux-acpi \
		linux-acpi@vger.kernel.org
	public-inbox-index linux-acpi

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-acpi


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git