* [PATCH] ACPI: button: Drop no longer necessary Acer SW5-012 lid_init_state quirk
@ 2020-10-26 21:28 Hans de Goede
2020-10-27 18:29 ` Rafael J. Wysocki
0 siblings, 1 reply; 2+ messages in thread
From: Hans de Goede @ 2020-10-26 21:28 UTC (permalink / raw)
To: Rafael J . Wysocki, Len Brown; +Cc: Hans de Goede, linux-acpi
Commit 78a5b53e9fb4 ("Input: soc_button_array - work around DSDTs which
modify the irqflags") adds a workaround for DSDTs with a _LID method
which play tricks with the irqflags, assuming that the OS is using
an irq-type of IRQ_TYPE_LEVEL_LOW.
Now that this workaround is in place, we no longer need to disable the
lid functionality on the Acer SW5-012.
Fixes: 78a5b53e9fb4 ("Input: soc_button_array - Work around DSDTs which modify the irqflags")
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
drivers/acpi/button.c | 13 -------------
1 file changed, 13 deletions(-)
diff --git a/drivers/acpi/button.c b/drivers/acpi/button.c
index da4b125ab4c3..0761529cac05 100644
--- a/drivers/acpi/button.c
+++ b/drivers/acpi/button.c
@@ -73,19 +73,6 @@ MODULE_DEVICE_TABLE(acpi, button_device_ids);
/* Please keep this list sorted alphabetically by vendor and model */
static const struct dmi_system_id dmi_lid_quirks[] = {
- {
- /*
- * Acer Switch 10 SW5-012. _LID method messes with home and
- * power button GPIO IRQ settings causing an interrupt storm on
- * both GPIOs. This is unfixable without a DSDT override, so we
- * have to disable the lid-switch functionality altogether :|
- */
- .matches = {
- DMI_MATCH(DMI_SYS_VENDOR, "Acer"),
- DMI_MATCH(DMI_PRODUCT_NAME, "Aspire SW5-012"),
- },
- .driver_data = (void *)(long)ACPI_BUTTON_LID_INIT_DISABLED,
- },
{
/* GP-electronic T701, _LID method points to a floating GPIO */
.matches = {
--
2.28.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ACPI: button: Drop no longer necessary Acer SW5-012 lid_init_state quirk
2020-10-26 21:28 [PATCH] ACPI: button: Drop no longer necessary Acer SW5-012 lid_init_state quirk Hans de Goede
@ 2020-10-27 18:29 ` Rafael J. Wysocki
0 siblings, 0 replies; 2+ messages in thread
From: Rafael J. Wysocki @ 2020-10-27 18:29 UTC (permalink / raw)
To: Hans de Goede; +Cc: Rafael J . Wysocki, Len Brown, ACPI Devel Maling List
On Mon, Oct 26, 2020 at 10:28 PM Hans de Goede <hdegoede@redhat.com> wrote:
>
> Commit 78a5b53e9fb4 ("Input: soc_button_array - work around DSDTs which
> modify the irqflags") adds a workaround for DSDTs with a _LID method
> which play tricks with the irqflags, assuming that the OS is using
> an irq-type of IRQ_TYPE_LEVEL_LOW.
>
> Now that this workaround is in place, we no longer need to disable the
> lid functionality on the Acer SW5-012.
>
> Fixes: 78a5b53e9fb4 ("Input: soc_button_array - Work around DSDTs which modify the irqflags")
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
> drivers/acpi/button.c | 13 -------------
> 1 file changed, 13 deletions(-)
>
> diff --git a/drivers/acpi/button.c b/drivers/acpi/button.c
> index da4b125ab4c3..0761529cac05 100644
> --- a/drivers/acpi/button.c
> +++ b/drivers/acpi/button.c
> @@ -73,19 +73,6 @@ MODULE_DEVICE_TABLE(acpi, button_device_ids);
>
> /* Please keep this list sorted alphabetically by vendor and model */
> static const struct dmi_system_id dmi_lid_quirks[] = {
> - {
> - /*
> - * Acer Switch 10 SW5-012. _LID method messes with home and
> - * power button GPIO IRQ settings causing an interrupt storm on
> - * both GPIOs. This is unfixable without a DSDT override, so we
> - * have to disable the lid-switch functionality altogether :|
> - */
> - .matches = {
> - DMI_MATCH(DMI_SYS_VENDOR, "Acer"),
> - DMI_MATCH(DMI_PRODUCT_NAME, "Aspire SW5-012"),
> - },
> - .driver_data = (void *)(long)ACPI_BUTTON_LID_INIT_DISABLED,
> - },
> {
> /* GP-electronic T701, _LID method points to a floating GPIO */
> .matches = {
> --
Applied as 5.10-rc material, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-10-27 18:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-26 21:28 [PATCH] ACPI: button: Drop no longer necessary Acer SW5-012 lid_init_state quirk Hans de Goede
2020-10-27 18:29 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).