From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Ricardo Ribalda <ribalda@chromium.org>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
linux-gpio@vger.kernel.org, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] gpiolib: acpi: Support GpioInt with active_low polarity
Date: Wed, 28 Oct 2020 20:27:44 +0200 [thread overview]
Message-ID: <20201028182744.GZ4077@smile.fi.intel.com> (raw)
In-Reply-To: <20201028171757.765866-1-ribalda@chromium.org>
On Wed, Oct 28, 2020 at 06:17:57PM +0100, Ricardo Ribalda wrote:
> On the current implementation we only support active_high polarity for
> GpioInt.
>
> There can be cases where a GPIO has active_low polarity and it is also a
> IRQ source.
>
> De-couple the irq_polarity and active_low fields instead of re-use it.
>
> With this patch we support ACPI devices such as:
Is it real device on the market?!
This table is broken. _DSD GPIO active_low is only for GpioIo().
If it is a ChromeBook, please fix the firmware.
> Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings
> {
> GpioInt (Edge, ActiveBoth, Exclusive, PullDefault, 0x0000,
> "\\_SB.PCI0.GPIO", 0x00, ResourceConsumer, ,
> )
> { // Pin list
> 0x0064
> }
> })
> Name (_DSD, Package (0x02) // _DSD: Device-Specific Data
> {
> ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301") /* Device Properties for _DSD */,
> Package (0x01)
> {
> Package (0x02)
> {
> "privacy-gpio",
> Package (0x04)
> {
> \_SB.PCI0.XHCI.RHUB.HS07,
> Zero,
> Zero,
> One
> }
> }
> }
> })
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-10-29 14:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-28 17:17 [PATCH] gpiolib: acpi: Support GpioInt with active_low polarity Ricardo Ribalda
2020-10-28 18:27 ` Andy Shevchenko [this message]
2020-10-29 15:34 ` Ricardo Ribalda
2020-10-29 17:31 ` Andy Shevchenko
2020-10-29 18:08 ` Ricardo Ribalda
2020-10-29 18:14 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201028182744.GZ4077@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bgolaszewski@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=ribalda@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).