From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Ricardo Ribalda <ribalda@chromium.org>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>,
linux-acpi@vger.kernel.org,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
linux-gpio@vger.kernel.org
Subject: Re: [PATCH v1 2/3] Documentation: firmware-guide: gpio-properties: active_low only for GpioIo()
Date: Thu, 29 Oct 2020 16:46:56 +0200 [thread overview]
Message-ID: <20201029144656.GD4077@smile.fi.intel.com> (raw)
In-Reply-To: <CANiDSCtRDwfFo9HE84iujjFe6h9aS6b3B8wkz5Rt0aO8=XMsNg@mail.gmail.com>
On Wed, Oct 28, 2020 at 10:10:42PM +0100, Ricardo Ribalda wrote:
> Hi Andy
>
> Thanks for your patch and super fast response.
>
> I think there are two different concepts here:
>
> 1) when the pin has a low value, it is 0 or a 1? =>active_low
I'm not sure I have got it. GpioIo() has no such property and
_DSD active_low is documented as being polarity setting:
active_low == 1 => active low polarity.
> 2) when do I get an irq, low->high or high->low => irq polarity
IRQ polarity is clearly defined by GpioInt() resource in the ACPI
specification.
> When I read the acpi spec for GpioInt()
> https://www.uefi.org/sites/default/files/resources/ACPI_6_2.pdf page
> 934, it has the same problem as for GpioIo(), it does not express the
> active_low and this is where the _DSD field comes handy.
ActiveLevel field is described in 19.6.55 GpioInt (GPIO Interrupt Connection
Resource Descriptor Macro).
> Without using the active_low, how can we describe a pin that is
> active low and has to trigger an irq on both edges?
This is nonsense.
What does it mean?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-10-29 14:45 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-28 20:50 [PATCH v1 1/3] Documentation: firmware-guide: gpio-properties: Fix factual mistakes Andy Shevchenko
2020-10-28 20:51 ` [PATCH v1 2/3] Documentation: firmware-guide: gpio-properties: active_low only for GpioIo() Andy Shevchenko
2020-10-28 21:10 ` Ricardo Ribalda
2020-10-29 14:46 ` Andy Shevchenko [this message]
2020-10-29 14:54 ` Ricardo Ribalda
2020-10-29 17:17 ` Andy Shevchenko
2020-10-29 17:20 ` Andy Shevchenko
2020-10-29 17:25 ` Andy Shevchenko
2020-10-29 17:32 ` Ricardo Ribalda
2020-10-29 18:09 ` Ricardo Ribalda
2020-10-29 18:13 ` Andy Shevchenko
2020-10-29 18:58 ` Ricardo Ribalda
2020-10-29 19:11 ` Andy Shevchenko
2020-10-29 18:10 ` Andy Shevchenko
2020-10-29 8:13 ` Mika Westerberg
2020-10-28 20:51 ` [PATCH v1 3/3] Documentation: firmware-guide: gpio-properties: Clarify initial output state Andy Shevchenko
2020-10-29 8:16 ` Mika Westerberg
2020-10-29 8:13 ` [PATCH v1 1/3] Documentation: firmware-guide: gpio-properties: Fix factual mistakes Mika Westerberg
2020-10-29 11:10 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201029144656.GD4077@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=ribalda@chromium.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).