From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>,
linux-rtc@vger.kernel.org, Tin Huynh <tnhuynh@apm.com>,
linux-acpi@vger.kernel.org
Subject: Re: [PATCH v1 1/3] rtc: ds1307: Remove non-valid ACPI IDs
Date: Thu, 12 Nov 2020 19:16:01 +0200 [thread overview]
Message-ID: <20201112171601.GL4077@smile.fi.intel.com> (raw)
In-Reply-To: <20201112163617.GE4556@piout.net>
On Thu, Nov 12, 2020 at 05:36:17PM +0100, Alexandre Belloni wrote:
> On 12/11/2020 17:57:51+0200, Andy Shevchenko wrote:
> > The commit 9c19b8930d2c ("rtc: ds1307: Add ACPI support") added non-valid
> > ACPI IDs (all of them abusing ACPI specification). Moreover there is
> > no even a single evidence that vendor registered any of such device.
> >
> > Remove broken ACPI IDs from the driver. For prototyping one may use PRP0001
> > with device tree defined bindings. The following patches will add support
> > of that to the driver.
>
> I'm intrigued, how does PRP0001 work? Where would the device tree come
> from?
From nowhere :-)
There is no device tree. The properties are coming from _DSD ACPI Method with
compatible string provided. ACPI glue layer provides a mechanism to parse that
and match against OF ID table (even when CONFIG_OF=n!).
More about PRP0001 is in documentation [1].
> You probably want to have a look at:
> https://lore.kernel.org/linux-rtc/20201112130734.331094-3-ch@denx.de/T/#u
Thanks for heads up!
I'll check that thread and answer there.
[1]: Documentation/firmware-guide/acpi/enumeration.rst
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-11-12 17:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-12 15:57 [PATCH v1 1/3] rtc: ds1307: Remove non-valid ACPI IDs Andy Shevchenko
2020-11-12 15:57 ` [PATCH v1 2/3] rtc: ds1307: Make use of device properties Andy Shevchenko
2020-11-12 16:26 ` Andy Shevchenko
2020-11-12 15:57 ` [PATCH v1 3/3] rtc: ds1307: Drop of_match_ptr and CONFIG_OF protections Andy Shevchenko
2020-11-12 16:36 ` [PATCH v1 1/3] rtc: ds1307: Remove non-valid ACPI IDs Alexandre Belloni
2020-11-12 17:16 ` Andy Shevchenko [this message]
2020-11-12 19:01 ` Rafael J. Wysocki
2020-11-13 14:11 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201112171601.GL4077@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=tnhuynh@apm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).