linux-acpi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Kevin Paul Herbert <kph@platinasystems.com>,
	Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: kbuild-all@lists.01.org, clang-built-linux@googlegroups.com,
	"Rafael J . Wysocki" <rjw@rjwysocki.net>,
	Len Brown <lenb@kernel.org>,
	linux-acpi@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
	Frank Rowand <frowand.list@gmail.com>,
	devicetree@vger.kernel.org,
	Tom Grennan <tgrennan@platinasystems.com>,
	linux-kernel@vger.kernel.org,
	Kevin Paul Herbert <kph@platinasystems.com>
Subject: Re: [PATCH] nvmem: Change to unified property interface
Date: Tue, 30 Mar 2021 12:57:26 +0800	[thread overview]
Message-ID: <202103301200.72gTTdf5-lkp@intel.com> (raw)
In-Reply-To: <20210329223827.2851916-1-kph@platinasystems.com>

[-- Attachment #1: Type: text/plain, Size: 4276 bytes --]

Hi Kevin,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on v5.12-rc5 next-20210329]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Kevin-Paul-Herbert/nvmem-Change-to-unified-property-interface/20210330-064121
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 1e43c377a79f9189fea8f2711b399d4e8b4e609b
config: x86_64-randconfig-a014-20210329 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 482283042f795ecc27838a3b2f76b5494991401c)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # https://github.com/0day-ci/linux/commit/edbc7632702cf638265a6d7180bd8c951cda6ad9
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Kevin-Paul-Herbert/nvmem-Change-to-unified-property-interface/20210330-064121
        git checkout edbc7632702cf638265a6d7180bd8c951cda6ad9
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   drivers/thermal/sprd_thermal.c:128:9: error: implicit declaration of function 'of_nvmem_cell_get' [-Werror,-Wimplicit-function-declaration]
           cell = of_nvmem_cell_get(np, cell_id);
                  ^
   drivers/thermal/sprd_thermal.c:128:9: note: did you mean 'nvmem_cell_get'?
   include/linux/nvmem-consumer.h:60:20: note: 'nvmem_cell_get' declared here
   struct nvmem_cell *nvmem_cell_get(struct device *dev, const char *id);
                      ^
>> drivers/thermal/sprd_thermal.c:128:7: warning: incompatible integer to pointer conversion assigning to 'struct nvmem_cell *' from 'int' [-Wint-conversion]
           cell = of_nvmem_cell_get(np, cell_id);
                ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   1 warning and 1 error generated.


vim +128 drivers/thermal/sprd_thermal.c

554fdbaf19b188 Freeman Liu 2020-02-18  120  
554fdbaf19b188 Freeman Liu 2020-02-18  121  static int sprd_thm_cal_read(struct device_node *np, const char *cell_id,
554fdbaf19b188 Freeman Liu 2020-02-18  122  			     u32 *val)
554fdbaf19b188 Freeman Liu 2020-02-18  123  {
554fdbaf19b188 Freeman Liu 2020-02-18  124  	struct nvmem_cell *cell;
554fdbaf19b188 Freeman Liu 2020-02-18  125  	void *buf;
554fdbaf19b188 Freeman Liu 2020-02-18  126  	size_t len;
554fdbaf19b188 Freeman Liu 2020-02-18  127  
554fdbaf19b188 Freeman Liu 2020-02-18 @128  	cell = of_nvmem_cell_get(np, cell_id);
554fdbaf19b188 Freeman Liu 2020-02-18  129  	if (IS_ERR(cell))
554fdbaf19b188 Freeman Liu 2020-02-18  130  		return PTR_ERR(cell);
554fdbaf19b188 Freeman Liu 2020-02-18  131  
554fdbaf19b188 Freeman Liu 2020-02-18  132  	buf = nvmem_cell_read(cell, &len);
554fdbaf19b188 Freeman Liu 2020-02-18  133  	nvmem_cell_put(cell);
554fdbaf19b188 Freeman Liu 2020-02-18  134  	if (IS_ERR(buf))
554fdbaf19b188 Freeman Liu 2020-02-18  135  		return PTR_ERR(buf);
554fdbaf19b188 Freeman Liu 2020-02-18  136  
554fdbaf19b188 Freeman Liu 2020-02-18  137  	if (len > sizeof(u32)) {
554fdbaf19b188 Freeman Liu 2020-02-18  138  		kfree(buf);
554fdbaf19b188 Freeman Liu 2020-02-18  139  		return -EINVAL;
554fdbaf19b188 Freeman Liu 2020-02-18  140  	}
554fdbaf19b188 Freeman Liu 2020-02-18  141  
554fdbaf19b188 Freeman Liu 2020-02-18  142  	memcpy(val, buf, len);
554fdbaf19b188 Freeman Liu 2020-02-18  143  
554fdbaf19b188 Freeman Liu 2020-02-18  144  	kfree(buf);
554fdbaf19b188 Freeman Liu 2020-02-18  145  	return 0;
554fdbaf19b188 Freeman Liu 2020-02-18  146  }
554fdbaf19b188 Freeman Liu 2020-02-18  147  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 37996 bytes --]

  parent reply	other threads:[~2021-03-30  4:59 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-29 22:38 [PATCH] nvmem: Change to unified property interface Kevin Paul Herbert
2021-03-30  3:21 ` kernel test robot
2021-03-30  4:26 ` [PATCH v2] " Kevin Paul Herbert
2021-03-30  4:28 ` Kevin Paul Herbert
2021-03-30  4:34 ` Kevin Paul Herbert
2021-03-30  4:57 ` kernel test robot [this message]
2021-03-30 10:43 ` [PATCH] " kernel test robot
2021-03-30 16:18 ` [PATCH v3 0/1] " Kevin Paul Herbert
2021-03-30 16:18 ` [PATCH v3 1/1] " Kevin Paul Herbert
  -- strict thread matches above, loose matches on Subject: below --
2021-03-29 22:28 [PATCH] " Kevin Paul Herbert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202103301200.72gTTdf5-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=clang-built-linux@googlegroups.com \
    --cc=devicetree@vger.kernel.org \
    --cc=frowand.list@gmail.com \
    --cc=kbuild-all@lists.01.org \
    --cc=kph@platinasystems.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rjw@rjwysocki.net \
    --cc=robh+dt@kernel.org \
    --cc=srinivas.kandagatla@linaro.org \
    --cc=tgrennan@platinasystems.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).