From: Bjorn Helgaas <helgaas@kernel.org>
To: chakravarthikulkarni <chakravarthikulkarni2021@gmail.com>
Cc: linux-pci@vger.kernel.org,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
"Len Brown" <lenb@kernel.org>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
"Krzysztof Wilczyński" <kw@linux.com>
Subject: Re: [PATCH] PCI: acpiphp: Fixed coding style
Date: Fri, 16 Apr 2021 14:35:55 -0500 [thread overview]
Message-ID: <20210416193555.GA2747805@bjorn-Precision-5520> (raw)
In-Reply-To: <20210301072145.19018-1-chakravarthikulkarni2021@gmail.com>
On Mon, Mar 01, 2021 at 12:51:45PM +0530, chakravarthikulkarni wrote:
> In this commit fixed coding style for braces and comments.
>
> Signed-off-by: chakravarthikulkarni <chakravarthikulkarni2021@gmail.com>
Applied to pci/hotplug for v5.13, thanks!
I dropped the comment change because it's really one comment that
should remain connected, so it doesn't seem like an improvement to me
to add comment start/stop in the middle.
> ---
> drivers/pci/hotplug/acpiphp.h | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/pci/hotplug/acpiphp.h b/drivers/pci/hotplug/acpiphp.h
> index a74b274a8c45..e0964600a78f 100644
> --- a/drivers/pci/hotplug/acpiphp.h
> +++ b/drivers/pci/hotplug/acpiphp.h
> @@ -80,8 +80,8 @@ struct acpiphp_bridge {
> struct acpiphp_slot {
> struct list_head node;
> struct pci_bus *bus;
> - struct list_head funcs; /* one slot may have different
> - objects (i.e. for each function) */
> + struct list_head funcs; /* one slot may have different */
> + /* objects (i.e. for each function) */
> struct slot *slot;
>
> u8 device; /* pci device# */
> @@ -148,8 +148,7 @@ static inline struct acpiphp_root_context *to_acpiphp_root_context(struct acpi_h
> * ACPI has no generic method of setting/getting attention status
> * this allows for device specific driver registration
> */
> -struct acpiphp_attention_info
> -{
> +struct acpiphp_attention_info {
> int (*set_attn)(struct hotplug_slot *slot, u8 status);
> int (*get_attn)(struct hotplug_slot *slot, u8 *status);
> struct module *owner;
> --
> 2.17.1
>
prev parent reply other threads:[~2021-04-16 19:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-01 7:21 [PATCH] PCI: acpiphp: Fixed coding style chakravarthikulkarni
2021-03-07 1:18 ` Krzysztof Wilczyński
2021-04-16 19:35 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210416193555.GA2747805@bjorn-Precision-5520 \
--to=helgaas@kernel.org \
--cc=chakravarthikulkarni2021@gmail.com \
--cc=kw@linux.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).