From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3751CC433EF for ; Wed, 8 Dec 2021 16:04:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236498AbhLHQI3 (ORCPT ); Wed, 8 Dec 2021 11:08:29 -0500 Received: from mga03.intel.com ([134.134.136.65]:33704 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236226AbhLHQI2 (ORCPT ); Wed, 8 Dec 2021 11:08:28 -0500 X-IronPort-AV: E=McAfee;i="6200,9189,10192"; a="237799890" X-IronPort-AV: E=Sophos;i="5.88,189,1635231600"; d="scan'208";a="237799890" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Dec 2021 08:04:48 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,189,1635231600"; d="scan'208";a="479944744" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga002.jf.intel.com with ESMTP; 08 Dec 2021 08:04:44 -0800 Received: by black.fi.intel.com (Postfix, from userid 1000) id C74731A0; Wed, 8 Dec 2021 18:04:50 +0200 (EET) Date: Wed, 8 Dec 2021 19:04:50 +0300 From: "Kirill A. Shutemov" To: "Rafael J. Wysocki" Cc: Andi Kleen , Borislav Petkov , Dan Williams , Dave Hansen , "H. Peter Anvin" , Kuppuswamy Sathyanarayanan , ACPI Devel Maling List , Linux Kernel Mailing List , Ingo Molnar , "Rafael J. Wysocki" , Kuppuswamy Sathyanarayanan , Thomas Gleixner , Tony Luck , the arch/x86 maintainers Subject: Re: [PATCH 4/4] ACPI: PM: Avoid cache flush on entering S4 Message-ID: <20211208160450.3hplhtikjjvfrhts@black.fi.intel.com> References: <20211206122952.74139-1-kirill.shutemov@linux.intel.com> <20211206122952.74139-5-kirill.shutemov@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Wed, Dec 08, 2021 at 04:10:52PM +0100, Rafael J. Wysocki wrote: > On Mon, Dec 6, 2021 at 1:30 PM Kirill A. Shutemov > wrote: > > > > According to the ACPI spec v6.4, section 16.2 the cache flushing > > required on entering to S1, S2, and S3. > > > > No need to flush caches on hibernation (S4). > > > > Signed-off-by: Kirill A. Shutemov > > --- > > drivers/acpi/sleep.c | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/drivers/acpi/sleep.c b/drivers/acpi/sleep.c > > index 14e8df0ac762..8166d863ed6b 100644 > > --- a/drivers/acpi/sleep.c > > +++ b/drivers/acpi/sleep.c > > @@ -902,8 +902,6 @@ static int acpi_hibernation_enter(void) > > { > > acpi_status status = AE_OK; > > > > - ACPI_FLUSH_CPU_CACHE(); > > - > > /* This shouldn't return. If it returns, we have a problem */ > > status = acpi_enter_sleep_state(ACPI_STATE_S4); > > /* Reprogram control registers */ > > -- > > Applied (with some edits in the subject and changelog) as 5.17 material, thanks! Is it for the series or only 4/4? Do I need to do something for 2/4 and 3/4? -- Kirill A. Shutemov