From: Jonathan Cameron <jic23@kernel.org>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Anand Ashok Dumbre <anand.ashok.dumbre@xilinx.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
linux-iio@vger.kernel.org, git@xilinx.com, michals@xilinx.com,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH v12 1/5] device property: Add fwnode_iomap()
Date: Sat, 18 Dec 2021 10:38:24 +0000 [thread overview]
Message-ID: <20211218103824.67099464@jic23-huawei> (raw)
In-Reply-To: <CAJZ5v0hG409ffmAiOO5j4O9iPN_qGp4Wnw8eNPKjm5kvncwRLA@mail.gmail.com>
On Fri, 17 Dec 2021 18:52:00 +0100
"Rafael J. Wysocki" <rafael@kernel.org> wrote:
> On Fri, Dec 3, 2021 at 10:24 PM Anand Ashok Dumbre
> <anand.ashok.dumbre@xilinx.com> wrote:
> >
> > This patch introduces a new helper routine - fwnode_iomap(), which
> > allows to map the memory mapped IO for a given device node.
> >
> > This implementation does not cover the ACPI case and may be expanded
> > in the future. The main purpose here is to be able to develop resource
> > provider agnostic drivers.
> >
> > Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > Signed-off-by: Anand Ashok Dumbre <anand.ashok.dumbre@xilinx.com>
> > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > ---
> > drivers/base/property.c | 16 ++++++++++++++++
> > include/linux/property.h | 2 ++
> > 2 files changed, 18 insertions(+)
> >
> > diff --git a/drivers/base/property.c b/drivers/base/property.c
> > index f1f35b48ab8b..ed4470410030 100644
> > --- a/drivers/base/property.c
> > +++ b/drivers/base/property.c
> > @@ -958,6 +958,22 @@ int fwnode_irq_get(const struct fwnode_handle *fwnode, unsigned int index)
> > }
> > EXPORT_SYMBOL(fwnode_irq_get);
> >
> > +/**
> > + * fwnode_iomap - Maps the memory mapped IO for a given fwnode
> > + * @fwnode: Pointer to the firmware node
> > + * @index: Index of the IO range
> > + *
> > + * Returns a pointer to the mapped memory.
> > + */
> > +void __iomem *fwnode_iomap(struct fwnode_handle *fwnode, int index)
> > +{
> > + if (IS_ENABLED(CONFIG_OF_ADDRESS) && is_of_node(fwnode))
> > + return of_iomap(to_of_node(fwnode), index);
> > +
> > + return NULL;
> > +}
> > +EXPORT_SYMBOL(fwnode_iomap);
>
> So why is this EXPORT_SYMBOL() and not EXPORT_SYMBOL_GPL()?
Good question. I'm guessing this is because of_iomap is EXPORT_SYMBOL()
and we don't want to discourage use of this function in preference to it.
Series applied to the togreg branch of iio.git but initially pushed out
as testing to let 0-day see if it can find anything we broke.
Note I can still rebase if people would prefer _GPL() so feel free to
discuss further. +CC Rob Herring and DT list.
Thanks,
Jonathan
>
> Other than this I'm not an OF_ expert, but I trust Andy, so with the
> above addressed:
>
> Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> > +
> > /**
> > * fwnode_graph_get_next_endpoint - Get next endpoint firmware node
> > * @fwnode: Pointer to the parent firmware node
> > diff --git a/include/linux/property.h b/include/linux/property.h
> > index 88fa726a76df..6670d5a1ec2a 100644
> > --- a/include/linux/property.h
> > +++ b/include/linux/property.h
> > @@ -122,6 +122,8 @@ void fwnode_handle_put(struct fwnode_handle *fwnode);
> >
> > int fwnode_irq_get(const struct fwnode_handle *fwnode, unsigned int index);
> >
> > +void __iomem *fwnode_iomap(struct fwnode_handle *fwnode, int index);
> > +
> > unsigned int device_get_child_node_count(struct device *dev);
> >
> > static inline bool device_property_read_bool(struct device *dev,
> > --
> > 2.17.1
> >
next prev parent reply other threads:[~2021-12-18 10:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-03 21:23 [PATCH v12 0/5] Add Xilinx AMS Driver Anand Ashok Dumbre
2021-12-03 21:23 ` [PATCH v12 1/5] device property: Add fwnode_iomap() Anand Ashok Dumbre
2021-12-16 11:33 ` Jonathan Cameron
2021-12-17 17:52 ` Rafael J. Wysocki
2021-12-18 10:38 ` Jonathan Cameron [this message]
2021-12-21 12:30 ` Jonathan Cameron
2021-12-03 21:23 ` [PATCH v12 2/5] arm64: zynqmp: DT: Add Xilinx AMS node Anand Ashok Dumbre
2022-01-19 11:51 ` Michael Tretter
2021-12-03 21:23 ` [PATCH v12 3/5] iio: adc: Add Xilinx AMS driver Anand Ashok Dumbre
2021-12-03 21:23 ` [PATCH v12 4/5] dt-bindings: iio: adc: Add Xilinx AMS binding documentation Anand Ashok Dumbre
2021-12-03 21:23 ` [PATCH v12 5/5] MAINTAINERS: Add maintainer for xilinx-ams Anand Ashok Dumbre
2021-12-15 12:11 ` [PATCH v12 0/5] Add Xilinx AMS Driver Anand Ashok Dumbre
2021-12-16 11:37 ` Jonathan Cameron
2022-01-10 5:17 ` Anand Ashok Dumbre
2022-01-10 13:39 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211218103824.67099464@jic23-huawei \
--to=jic23@kernel.org \
--cc=anand.ashok.dumbre@xilinx.com \
--cc=devicetree@vger.kernel.org \
--cc=git@xilinx.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=lars@metafoo.de \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michals@xilinx.com \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).