From: Hector Martin <marcan@marcan.st> To: Kalle Valo <kvalo@codeaurora.org>, "David S. Miller" <davem@davemloft.net>, Jakub Kicinski <kuba@kernel.org>, Rob Herring <robh+dt@kernel.org>, "Rafael J. Wysocki" <rafael@kernel.org>, Len Brown <lenb@kernel.org>, Arend van Spriel <aspriel@gmail.com>, Franky Lin <franky.lin@broadcom.com>, Hante Meuleman <hante.meuleman@broadcom.com>, Chi-hsien Lin <chi-hsien.lin@infineon.com>, Wright Feng <wright.feng@infineon.com>, Chung-hsien Hsu <chung-hsien.hsu@infineon.com> Cc: "Hector Martin" <marcan@marcan.st>, "Sven Peter" <sven@svenpeter.dev>, "Alyssa Rosenzweig" <alyssa@rosenzweig.io>, "Mark Kettenis" <kettenis@openbsd.org>, "Rafał Miłecki" <zajec5@gmail.com>, "Pieter-Paul Giesberts" <pieter-paul.giesberts@broadcom.com>, "Linus Walleij" <linus.walleij@linaro.org>, "Hans de Goede" <hdegoede@redhat.com>, "John W. Linville" <linville@tuxdriver.com>, "Daniel (Deognyoun) Kim" <dekim@broadcom.com>, "brian m. carlson" <sandals@crustytoothpaste.net>, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, SHA-cyfmac-dev-list@infineon.com Subject: [PATCH 33/34] brcmfmac: pcie: Load and provide TxCap blobs Date: Mon, 27 Dec 2021 00:36:23 +0900 [thread overview] Message-ID: <20211226153624.162281-34-marcan@marcan.st> (raw) In-Reply-To: <20211226153624.162281-1-marcan@marcan.st> These blobs are named .txcap_blob, and exist alongside the existing .clm_blob files. Use the existing firmware machinery to provide them to the core. Signed-off-by: Hector Martin <marcan@marcan.st> --- .../net/wireless/broadcom/brcm80211/brcmfmac/pcie.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c index 6f483d25f7a1..04c29e620eca 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c @@ -73,6 +73,7 @@ MODULE_FIRMWARE(BRCMF_FW_DEFAULT_PATH "brcmfmac*-pcie.*.txt"); /* per-board firmware binaries */ MODULE_FIRMWARE(BRCMF_FW_DEFAULT_PATH "brcmfmac*-pcie.*.bin"); MODULE_FIRMWARE(BRCMF_FW_DEFAULT_PATH "brcmfmac*-pcie.*.clm_blob"); +MODULE_FIRMWARE(BRCMF_FW_DEFAULT_PATH "brcmfmac*-pcie.*.txcap_blob"); static const struct brcmf_firmware_mapping brcmf_pcie_fwnames[] = { BRCMF_FW_ENTRY(BRCM_CC_43602_CHIP_ID, 0xFFFFFFFF, 43602), @@ -325,7 +326,9 @@ struct brcmf_pciedev_info { char fw_name[BRCMF_FW_NAME_LEN]; char nvram_name[BRCMF_FW_NAME_LEN]; char clm_name[BRCMF_FW_NAME_LEN]; + char txcap_name[BRCMF_FW_NAME_LEN]; const struct firmware *clm_fw; + const struct firmware *txcap_fw; const struct brcmf_pcie_reginfo *reginfo; void __iomem *regs; void __iomem *tcm; @@ -1499,6 +1502,10 @@ static int brcmf_pcie_get_blob(struct device *dev, const struct firmware **fw, *fw = devinfo->clm_fw; devinfo->clm_fw = NULL; break; + case BRCMF_BLOB_TXCAP: + *fw = devinfo->txcap_fw; + devinfo->txcap_fw = NULL; + break; default: return -ENOENT; } @@ -2088,6 +2095,7 @@ static int brcmf_pcie_read_otp(struct brcmf_pciedev_info *devinfo) #define BRCMF_PCIE_FW_CODE 0 #define BRCMF_PCIE_FW_NVRAM 1 #define BRCMF_PCIE_FW_CLM 2 +#define BRCMF_PCIE_FW_TXCAP 3 static void brcmf_pcie_setup(struct device *dev, int ret, struct brcmf_fw_request *fwreq) @@ -2113,6 +2121,7 @@ static void brcmf_pcie_setup(struct device *dev, int ret, nvram = fwreq->items[BRCMF_PCIE_FW_NVRAM].nv_data.data; nvram_len = fwreq->items[BRCMF_PCIE_FW_NVRAM].nv_data.len; devinfo->clm_fw = fwreq->items[BRCMF_PCIE_FW_CLM].binary; + devinfo->txcap_fw = fwreq->items[BRCMF_PCIE_FW_TXCAP].binary; kfree(fwreq); ret = brcmf_chip_get_raminfo(devinfo->ci); @@ -2189,6 +2198,7 @@ brcmf_pcie_prepare_fw_request(struct brcmf_pciedev_info *devinfo) { ".bin", devinfo->fw_name }, { ".txt", devinfo->nvram_name }, { ".clm_blob", devinfo->clm_name }, + { ".txcap_blob", devinfo->txcap_name }, }; fwreq = brcmf_fw_alloc_request(devinfo->ci->chip, devinfo->ci->chiprev, @@ -2203,6 +2213,8 @@ brcmf_pcie_prepare_fw_request(struct brcmf_pciedev_info *devinfo) fwreq->items[BRCMF_PCIE_FW_NVRAM].flags = BRCMF_FW_REQF_OPTIONAL; fwreq->items[BRCMF_PCIE_FW_CLM].type = BRCMF_FW_TYPE_BINARY; fwreq->items[BRCMF_PCIE_FW_CLM].flags = BRCMF_FW_REQF_OPTIONAL; + fwreq->items[BRCMF_PCIE_FW_TXCAP].type = BRCMF_FW_TYPE_BINARY; + fwreq->items[BRCMF_PCIE_FW_TXCAP].flags = BRCMF_FW_REQF_OPTIONAL; /* NVRAM reserves PCI domain 0 for Broadcom's SDK faked bus */ fwreq->domain_nr = pci_domain_nr(devinfo->pdev->bus) + 1; fwreq->bus_nr = devinfo->pdev->bus->number; @@ -2419,6 +2431,7 @@ brcmf_pcie_remove(struct pci_dev *pdev) brcmf_pcie_reset_device(devinfo); brcmf_pcie_release_resource(devinfo); release_firmware(devinfo->clm_fw); + release_firmware(devinfo->txcap_fw); if (devinfo->ci) brcmf_chip_detach(devinfo->ci); -- 2.33.0
next prev parent reply other threads:[~2021-12-26 15:41 UTC|newest] Thread overview: 105+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-12-26 15:35 [RFC PATCH 00/34] brcmfmac: Support Apple T2 and M1 platforms Hector Martin 2021-12-26 15:35 ` [PATCH 01/34] dt-bindings: net: bcm4329-fmac: Add Apple properties & chips Hector Martin 2021-12-26 21:02 ` Linus Walleij 2021-12-26 23:34 ` Rob Herring 2021-12-27 16:36 ` Rob Herring 2021-12-27 17:23 ` Hector Martin 2021-12-29 16:38 ` Mark Kettenis 2022-01-02 14:12 ` Hector Martin 2021-12-29 16:42 ` Mark Kettenis 2022-01-04 5:47 ` Hector Martin 2021-12-26 15:35 ` [PATCH 02/34] brcmfmac: pcie: Declare missing firmware files in pcie.c Hector Martin 2021-12-26 21:04 ` Linus Walleij 2021-12-26 15:35 ` [PATCH 03/34] brcmfmac: firmware: Support having multiple alt paths Hector Martin 2022-01-02 5:31 ` Linus Walleij 2022-01-02 7:10 ` Dmitry Osipenko 2022-01-02 6:38 ` Dmitry Osipenko 2022-01-02 6:45 ` Dmitry Osipenko 2022-01-02 14:18 ` Hector Martin 2022-01-02 20:11 ` Dmitry Osipenko 2022-01-03 0:41 ` Hector Martin 2022-01-03 1:26 ` Dmitry Osipenko 2022-01-03 6:17 ` Hector Martin 2022-01-02 6:55 ` Dmitry Osipenko 2022-01-03 6:18 ` Hector Martin 2022-01-02 7:08 ` Dmitry Osipenko 2022-01-02 7:20 ` Dmitry Osipenko 2022-01-02 14:25 ` Hector Martin 2022-01-02 20:12 ` Dmitry Osipenko 2021-12-26 15:35 ` [PATCH 04/34] brcmfmac: firmware: Handle per-board clm_blob files Hector Martin 2022-01-02 6:21 ` Linus Walleij 2021-12-26 15:35 ` [PATCH 05/34] brcmfmac: pcie/sdio/usb: Get CLM blob via standard firmware mechanism Hector Martin 2022-01-02 6:22 ` Linus Walleij 2021-12-26 15:35 ` [PATCH 06/34] brcmfmac: firmware: Support passing in multiple board_types Hector Martin 2022-01-02 5:34 ` Linus Walleij 2021-12-26 15:35 ` [PATCH 07/34] brcmfmac: pcie: Read Apple OTP information Hector Martin 2022-01-02 5:38 ` Linus Walleij 2022-01-03 5:51 ` Hector Martin 2022-01-03 11:13 ` Linus Walleij 2021-12-26 15:35 ` [PATCH 08/34] brcmfmac: of: Fetch Apple properties Hector Martin 2022-01-02 5:40 ` Linus Walleij 2021-12-26 15:35 ` [PATCH 09/34] brcmfmac: pcie: Perform firmware selection for Apple platforms Hector Martin 2022-01-02 5:44 ` Linus Walleij 2021-12-26 15:36 ` [PATCH 10/34] brcmfmac: firmware: Allow platform to override macaddr Hector Martin 2022-01-02 5:50 ` Linus Walleij 2022-01-03 5:42 ` Hector Martin 2021-12-26 15:36 ` [PATCH 11/34] brcmfmac: msgbuf: Increase RX ring sizes to 1024 Hector Martin 2022-01-02 5:50 ` Linus Walleij 2021-12-26 15:36 ` [PATCH 12/34] brcmfmac: pcie: Fix crashes due to early IRQs Hector Martin 2022-01-02 5:51 ` Linus Walleij 2021-12-26 15:36 ` [PATCH 13/34] brcmfmac: pcie: Support PCIe core revisions >= 64 Hector Martin 2022-01-02 5:53 ` Linus Walleij 2021-12-26 15:36 ` [PATCH 14/34] brcmfmac: pcie: Add IDs/properties for BCM4378 Hector Martin 2022-01-02 5:53 ` Linus Walleij 2021-12-26 15:36 ` [PATCH 15/34] ACPI / property: Support strings in Apple _DSM props Hector Martin 2021-12-26 18:20 ` Lukas Wunner 2022-01-02 6:20 ` Linus Walleij 2021-12-26 15:36 ` [PATCH 16/34] brcmfmac: acpi: Add support for fetching Apple ACPI properties Hector Martin 2022-01-02 5:58 ` Linus Walleij 2022-01-03 6:03 ` Hector Martin 2022-01-03 11:14 ` Linus Walleij [not found] ` <CAHp75VcZcJ+zCDL-J+w8gEeKXGYdJajjLoa1JTj_kkJixrV12Q@mail.gmail.com> 2022-01-03 17:22 ` Hector Martin [not found] ` <CAHp75Vedgs_zTH2O120jtUuQiuseA0VN62TJiJ7kAi1f5nDQ6Q@mail.gmail.com> 2022-01-04 5:22 ` Hector Martin 2022-01-10 9:59 ` Kalle Valo 2021-12-26 15:36 ` [PATCH 17/34] brcmfmac: pcie: Provide a buffer of random bytes to the device Hector Martin 2022-01-02 5:59 ` Linus Walleij 2021-12-26 15:36 ` [PATCH 18/34] brcmfmac: pcie: Add IDs/properties for BCM4355 Hector Martin 2022-01-02 6:00 ` Linus Walleij 2021-12-26 15:36 ` [PATCH 19/34] brcmfmac: pcie: Add IDs/properties for BCM4377 Hector Martin 2022-01-02 6:01 ` Linus Walleij 2021-12-26 15:36 ` [PATCH 20/34] brcmfmac: pcie: Perform correct BCM4364 firmware selection Hector Martin 2022-01-02 6:02 ` Linus Walleij 2021-12-26 15:36 ` [PATCH 21/34] brcmfmac: chip: Only disable D11 cores; handle an arbitrary number Hector Martin 2022-01-02 6:03 ` Linus Walleij 2021-12-26 15:36 ` [PATCH 22/34] brcmfmac: chip: Handle 1024-unit sizes for TCM blocks Hector Martin 2022-01-02 6:09 ` Linus Walleij 2021-12-26 15:36 ` [PATCH 23/34] brcmfmac: cfg80211: Add support for scan params v2 Hector Martin 2022-01-02 6:23 ` Linus Walleij 2021-12-26 15:36 ` [PATCH 24/34] brcmfmac: feature: Add support for setting feats based on WLC version Hector Martin 2022-01-02 6:11 ` Linus Walleij 2021-12-26 15:36 ` [PATCH 25/34] brcmfmac: cfg80211: Add support for PMKID_V3 operations Hector Martin 2022-01-02 6:12 ` Linus Walleij 2021-12-26 15:36 ` [PATCH 26/34] brcmfmac: cfg80211: Pass the PMK in binary instead of hex Hector Martin 2022-01-02 6:13 ` Linus Walleij 2021-12-26 15:36 ` [PATCH 27/34] brcmfmac: pcie: Add IDs/properties for BCM4387 Hector Martin 2022-01-02 6:13 ` Linus Walleij 2021-12-26 15:36 ` [PATCH 28/34] brcmfmac: pcie: Replace brcmf_pcie_copy_mem_todev with memcpy_toio Hector Martin 2022-01-02 6:15 ` Linus Walleij 2021-12-26 15:36 ` [PATCH 29/34] brcmfmac: pcie: Read the console on init and shutdown Hector Martin 2022-01-02 6:16 ` Linus Walleij 2021-12-26 15:36 ` [PATCH 30/34] brcmfmac: pcie: Release firmwares in the brcmf_pcie_setup error path Hector Martin 2022-01-02 6:16 ` Linus Walleij 2021-12-26 15:36 ` [PATCH 31/34] brcmfmac: fwil: Constify iovar name arguments Hector Martin 2022-01-02 6:17 ` Linus Walleij 2021-12-26 15:36 ` [PATCH 32/34] brcmfmac: common: Add support for downloading TxCap blobs Hector Martin 2022-01-02 6:18 ` Linus Walleij 2021-12-26 15:36 ` Hector Martin [this message] 2022-01-02 6:19 ` [PATCH 33/34] brcmfmac: pcie: Load and provide " Linus Walleij 2021-12-26 15:36 ` [PATCH 34/34] brcmfmac: common: Add support for external calibration blobs Hector Martin 2022-01-02 6:19 ` Linus Walleij 2021-12-26 19:17 ` [RFC PATCH 00/34] brcmfmac: Support Apple T2 and M1 platforms Lukas Wunner 2021-12-26 21:42 ` Hans de Goede 2021-12-27 11:53 ` Hector Martin 2022-01-02 6:25 ` Linus Walleij 2022-01-03 6:27 ` Hector Martin 2022-01-03 10:20 ` Arend van Spriel
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20211226153624.162281-34-marcan@marcan.st \ --to=marcan@marcan.st \ --cc=SHA-cyfmac-dev-list@infineon.com \ --cc=alyssa@rosenzweig.io \ --cc=aspriel@gmail.com \ --cc=brcm80211-dev-list.pdl@broadcom.com \ --cc=chi-hsien.lin@infineon.com \ --cc=chung-hsien.hsu@infineon.com \ --cc=davem@davemloft.net \ --cc=dekim@broadcom.com \ --cc=devicetree@vger.kernel.org \ --cc=franky.lin@broadcom.com \ --cc=hante.meuleman@broadcom.com \ --cc=hdegoede@redhat.com \ --cc=kettenis@openbsd.org \ --cc=kuba@kernel.org \ --cc=kvalo@codeaurora.org \ --cc=lenb@kernel.org \ --cc=linus.walleij@linaro.org \ --cc=linux-acpi@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-wireless@vger.kernel.org \ --cc=linville@tuxdriver.com \ --cc=netdev@vger.kernel.org \ --cc=pieter-paul.giesberts@broadcom.com \ --cc=rafael@kernel.org \ --cc=robh+dt@kernel.org \ --cc=sandals@crustytoothpaste.net \ --cc=sven@svenpeter.dev \ --cc=wright.feng@infineon.com \ --cc=zajec5@gmail.com \ --subject='Re: [PATCH 33/34] brcmfmac: pcie: Load and provide TxCap blobs' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).