From: Mario Limonciello <mario.limonciello@amd.com>
To: "Rafael J . Wysocki" <rjw@rjwysocki.net>, <linux-acpi@vger.kernel.org>
Cc: <Shyam-sundar.S-k@amd.com>,
Basavaraj Natikar <Basavaraj.Natikar@amd.com>,
Mario Limonciello <mario.limonciello@amd.com>
Subject: [PATCH 0/3] On AMD platforms only offer s2idle w/ proper FW
Date: Wed, 5 Jan 2022 13:39:07 -0600 [thread overview]
Message-ID: <20220105193910.25678-1-mario.limonciello@amd.com> (raw)
Currently the Linux kernel will offer s2idle regardless of whether the FADT
indicates the system should use or on X86 if the LPS0 ACPI device has been
activated.
On some non-AMD platforms s2idle can be offered even without proper
firmware support. The power consumption may be higher in these instances
but the system otherwise properly suspends and resumes.
On AMD platforms however when the FW has been configured not to offer
s2idle some different hardware initialization has occurred such that the
system won't properly resume.
This patch series changes the kernel suspend code to conditionally decide
whether to offer s2idle. When an AMD system is encountered all the
prerequisites will be checked before s2idle is offered to the user.
Mario Limonciello (3):
PM: suspend: Move some structure declarations around
PM: sleep: Don't always assume s2idle will be enabled
acpi: sleep: Don't offer s2idle on AMD platforms without LPS0
drivers/acpi/sleep.c | 6 ++++++
drivers/acpi/x86/s2idle.c | 36 ++++++++++++++++++++++++----------
include/linux/suspend.h | 1 +
kernel/power/suspend.c | 41 ++++++++++++++++++++-------------------
4 files changed, 54 insertions(+), 30 deletions(-)
--
2.25.1
next reply other threads:[~2022-01-05 19:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-05 19:39 Mario Limonciello [this message]
2022-01-05 19:39 ` [PATCH 1/3] PM: suspend: Move some structure declarations around Mario Limonciello
2022-01-05 19:39 ` [PATCH 2/3] PM: sleep: Don't always assume s2idle will be enabled Mario Limonciello
2022-01-05 19:39 ` [PATCH 3/3] acpi: sleep: Don't offer s2idle on AMD platforms without LPS0 Mario Limonciello
2022-01-11 15:52 ` [PATCH 0/3] On AMD platforms only offer s2idle w/ proper FW Rafael J. Wysocki
2022-01-11 16:23 ` Limonciello, Mario
2022-01-11 17:05 ` Rafael J. Wysocki
2022-01-11 17:32 ` Limonciello, Mario
2022-01-11 17:32 ` Deucher, Alexander
2022-01-11 17:44 ` Rafael J. Wysocki
2022-01-11 18:30 ` Deucher, Alexander
2022-01-11 18:36 ` Limonciello, Mario
2022-01-11 19:20 ` Rafael J. Wysocki
2022-01-11 19:35 ` Limonciello, Mario
2022-01-11 19:48 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220105193910.25678-1-mario.limonciello@amd.com \
--to=mario.limonciello@amd.com \
--cc=Basavaraj.Natikar@amd.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=linux-acpi@vger.kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).