linux-acpi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild@lists.01.org,
	Mario Limonciello <mario.limonciello@amd.com>,
	Hans de Goede <hdegoede@redhat.com>,
	Mark Gross <mgross@linux.intel.com>,
	"Rafael J . Wysocki" <rjw@rjwysocki.net>
Cc: lkp@intel.com, kbuild-all@lists.01.org,
	"open list:X86 PLATFORM DRIVERS" 
	<platform-driver-x86@vger.kernel.org>,
	linux-acpi@vger.kernel.org,
	Shyam Sundar S K <Shyam-sundar.S-k@amd.com>,
	Goswami Sanket <Sanket.Goswami@amd.com>,
	Mario Limonciello <mario.limonciello@amd.com>
Subject: [kbuild] Re: [PATCH v4 1/3] ACPI / x86: Add support for LPS0 callback handler
Date: Thu, 17 Mar 2022 11:48:40 +0300	[thread overview]
Message-ID: <202203171657.uF7h6TEG-lkp@intel.com> (raw)
In-Reply-To: <20220316212924.5619-1-mario.limonciello@amd.com>

Hi Mario,

url:    https://github.com/0day-ci/linux/commits/Mario-Limonciello/ACPI-x86-Add-support-for-LPS0-callback-handler/20220317-053103 
base:    a32cd981a6da2373c093d471ee4405a915e217d5
config: i386-randconfig-m021 (https://download.01.org/0day-ci/archive/20220317/202203171657.uF7h6TEG-lkp@intel.com/config )
compiler: gcc-9 (Ubuntu 9.4.0-1ubuntu1~20.04) 9.4.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
drivers/acpi/x86/s2idle.c:478 acpi_s2idle_prepare_late() error: we previously assumed 'handler' could be null (see line 479)

vim +/handler +478 drivers/acpi/x86/s2idle.c

fa209644a7124b Mario Limonciello  2021-09-01  474  		acpi_sleep_run_lps0_dsm(ACPI_LPS0_MS_ENTRY,
fa209644a7124b Mario Limonciello  2021-09-01  475  				lps0_dsm_func_mask_microsoft, lps0_dsm_guid_microsoft);
fef98671194be0 Rafael J. Wysocki  2020-12-17  476  	}
4be2feac72a3ad Mario Limonciello  2022-03-16  477  
4be2feac72a3ad Mario Limonciello  2022-03-16 @478  	list_for_each_entry(handler, &lps0_s2idle_devops_head, list_node) {
4be2feac72a3ad Mario Limonciello  2022-03-16 @479  		if (handler)
4be2feac72a3ad Mario Limonciello  2022-03-16  480  			handler->prepare();

The list iterator can never be NULL so there is no need to check.

4be2feac72a3ad Mario Limonciello  2022-03-16  481  	}
4be2feac72a3ad Mario Limonciello  2022-03-16  482  
fef98671194be0 Rafael J. Wysocki  2020-12-17  483  	return 0;
fef98671194be0 Rafael J. Wysocki  2020-12-17  484  }

---
0-DAY CI Kernel Test Service
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org 
_______________________________________________
kbuild mailing list -- kbuild@lists.01.org
To unsubscribe send an email to kbuild-leave@lists.01.org


      parent reply	other threads:[~2022-03-17  8:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-16 21:29 [PATCH v4 1/3] ACPI / x86: Add support for LPS0 callback handler Mario Limonciello
2022-03-16 21:29 ` [PATCH v4 2/3] platform/x86: amd-pmc: Move to later in the suspend process Mario Limonciello
2022-03-16 21:29 ` [PATCH v4 3/3] platform/x86: amd-pmc: Drop CPU QoS workaround Mario Limonciello
2022-03-17  8:48 ` Dan Carpenter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202203171657.uF7h6TEG-lkp@intel.com \
    --to=dan.carpenter@oracle.com \
    --cc=Sanket.Goswami@amd.com \
    --cc=Shyam-sundar.S-k@amd.com \
    --cc=hdegoede@redhat.com \
    --cc=kbuild-all@lists.01.org \
    --cc=kbuild@lists.01.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=mario.limonciello@amd.com \
    --cc=mgross@linux.intel.com \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=rjw@rjwysocki.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).