linux-acpi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bjorn Helgaas <helgaas@kernel.org>
To: Gaosheng Cui <cuigaosheng1@huawei.com>
Cc: rafael.j.wysocki@intel.com, bjorn.helgaas@hp.com,
	rene.herman@gmail.com, len.brown@intel.com,
	linux-acpi@vger.kernel.org
Subject: Re: [PATCH] PNPBIOS: remove unused pnpid32_to_pnpid() declaration
Date: Tue, 13 Sep 2022 17:41:21 -0500	[thread overview]
Message-ID: <20220913224121.GA629552@bhelgaas> (raw)
In-Reply-To: <20220911094535.3226660-1-cuigaosheng1@huawei.com>

On Sun, Sep 11, 2022 at 05:45:35PM +0800, Gaosheng Cui wrote:
> pnpid32_to_pnpid() has been removed since
> commit 25eb846189d2 ("PNP: add pnp_eisa_id_to_string()"),
> so remove it.

Woof, I guess I messed that up, sorry :(

I would word the commit log as:

  All uses of pnpid32_to_pnpid() were removed by 25eb846189d2 ("PNP:
  add pnp_eisa_id_to_string()"), so remove the declaration, too.

Regardless,

Reviewed-by: Bjorn Helgaas <bhelgaas@google.com>

> Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>
> ---
>  drivers/pnp/pnpbios/pnpbios.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/pnp/pnpbios/pnpbios.h b/drivers/pnp/pnpbios/pnpbios.h
> index 2ce739ff9c1a..f3302006842e 100644
> --- a/drivers/pnp/pnpbios/pnpbios.h
> +++ b/drivers/pnp/pnpbios/pnpbios.h
> @@ -153,7 +153,6 @@ extern int  pnpbios_dont_use_current_config;
>  extern int pnpbios_parse_data_stream(struct pnp_dev *dev, struct pnp_bios_node * node);
>  extern int pnpbios_read_resources_from_node(struct pnp_dev *dev, struct pnp_bios_node *node);
>  extern int pnpbios_write_resources_to_node(struct pnp_dev *dev, struct pnp_bios_node *node);
> -extern void pnpid32_to_pnpid(u32 id, char *str);
>  
>  extern void pnpbios_print_status(const char * module, u16 status);
>  extern void pnpbios_calls_init(union pnp_bios_install_struct * header);
> -- 
> 2.25.1
> 

  reply	other threads:[~2022-09-13 22:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-11  9:45 [PATCH] PNPBIOS: remove unused pnpid32_to_pnpid() declaration Gaosheng Cui
2022-09-13 22:41 ` Bjorn Helgaas [this message]
2022-09-14  1:41   ` cuigaosheng
2022-09-24 16:08   ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220913224121.GA629552@bhelgaas \
    --to=helgaas@kernel.org \
    --cc=bjorn.helgaas@hp.com \
    --cc=cuigaosheng1@huawei.com \
    --cc=len.brown@intel.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=rafael.j.wysocki@intel.com \
    --cc=rene.herman@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).