From: "Jiri Slaby (SUSE)" <jirislaby@kernel.org>
To: rafael.j.wysocki@intel.com
Cc: linux-kernel@vger.kernel.org,
"Jiri Slaby (SUSE)" <jirislaby@kernel.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Len Brown <lenb@kernel.org>,
linux-acpi@vger.kernel.org, Chuanhong Guo <gch981213@gmail.com>,
Tighe Donnelly <tighe.donnelly@protonmail.com>,
Mario Limonciello <mario.limonciello@amd.com>
Subject: [PATCH 2/2] ACPI: resource: note more about IRQ override
Date: Tue, 4 Oct 2022 12:33:41 +0200 [thread overview]
Message-ID: <20221004103341.12646-2-jirislaby@kernel.org> (raw)
In-Reply-To: <20221004103341.12646-1-jirislaby@kernel.org>
Use an exclamation mark to note which of the properties was overridden.
Cc: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Len Brown <lenb@kernel.org>
Cc: linux-acpi@vger.kernel.org
Cc: Chuanhong Guo <gch981213@gmail.com>
Cc: Tighe Donnelly <tighe.donnelly@protonmail.com>
Cc: Mario Limonciello <mario.limonciello@amd.com>
Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
---
drivers/acpi/resource.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c
index 8d13e94bb921..497d626185e4 100644
--- a/drivers/acpi/resource.c
+++ b/drivers/acpi/resource.c
@@ -508,8 +508,11 @@ static void acpi_dev_get_irqresource(struct resource *res, u32 gsi,
u8 pol = p ? ACPI_ACTIVE_LOW : ACPI_ACTIVE_HIGH;
if (triggering != trig || polarity != pol) {
- pr_warn("ACPI: IRQ %d override to %s, %s\n", gsi,
- t ? "level" : "edge", p ? "low" : "high");
+ pr_warn("ACPI: IRQ %d override to %s%s, %s%s\n", gsi,
+ t ? "level" : "edge",
+ trig == triggering ? "" : "(!)",
+ p ? "low" : "high",
+ pol == polarity ? "" : "(!)");
triggering = trig;
polarity = pol;
}
--
2.37.3
next prev parent reply other threads:[~2022-10-04 10:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-04 10:33 [PATCH 1/2] ACPI: resource: do IRQ override on LENOVO IdeaPad Jiri Slaby (SUSE)
2022-10-04 10:33 ` Jiri Slaby (SUSE) [this message]
2022-10-04 21:02 ` Limonciello, Mario
2022-10-05 4:02 ` Chuanhong Guo
2022-10-05 16:34 ` Limonciello, Mario
2022-10-13 18:51 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221004103341.12646-2-jirislaby@kernel.org \
--to=jirislaby@kernel.org \
--cc=gch981213@gmail.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=rafael.j.wysocki@intel.com \
--cc=rafael@kernel.org \
--cc=tighe.donnelly@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).