Hi Andy, I love your patch! Yet something to improve: [auto build test ERROR on soc/for-next] [also build test ERROR on linus/master v6.0 next-20221005] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Andy-Shevchenko/device-property-Introduce-fwnode_device_is_compatible-helper/20221005-223919 base: https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git for-next config: powerpc-allnoconfig compiler: powerpc-linux-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/b930d58084d15cbf92f0cd490ad05e843991bd8e git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Andy-Shevchenko/device-property-Introduce-fwnode_device_is_compatible-helper/20221005-223919 git checkout b930d58084d15cbf92f0cd490ad05e843991bd8e # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=powerpc SHELL=/bin/bash arch/powerpc/kernel/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot All errors (new ones prefixed by >>): In file included from include/linux/of.h:22, from arch/powerpc/kernel/cputable.c:15: >> include/linux/property.h:54:6: error: no previous prototype for 'fwnode_device_is_compatible' [-Werror=missing-prototypes] 54 | bool fwnode_device_is_compatible(const struct fwnode_handle *fwnode, const char *compat) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/property.h: In function 'fwnode_device_is_compatible': include/linux/property.h:56:16: error: implicit declaration of function 'fwnode_property_match_string'; did you mean 'device_property_match_string'? [-Werror=implicit-function-declaration] 56 | return fwnode_property_match_string(fwnode, "compatible", compat) >= 0; | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ | device_property_match_string cc1: all warnings being treated as errors vim +/fwnode_device_is_compatible +54 include/linux/property.h 36 37 bool device_property_present(struct device *dev, const char *propname); 38 int device_property_read_u8_array(struct device *dev, const char *propname, 39 u8 *val, size_t nval); 40 int device_property_read_u16_array(struct device *dev, const char *propname, 41 u16 *val, size_t nval); 42 int device_property_read_u32_array(struct device *dev, const char *propname, 43 u32 *val, size_t nval); 44 int device_property_read_u64_array(struct device *dev, const char *propname, 45 u64 *val, size_t nval); 46 int device_property_read_string_array(struct device *dev, const char *propname, 47 const char **val, size_t nval); 48 int device_property_read_string(struct device *dev, const char *propname, 49 const char **val); 50 int device_property_match_string(struct device *dev, 51 const char *propname, const char *string); 52 53 bool fwnode_device_is_available(const struct fwnode_handle *fwnode); > 54 bool fwnode_device_is_compatible(const struct fwnode_handle *fwnode, const char *compat) 55 { 56 return fwnode_property_match_string(fwnode, "compatible", compat) >= 0; 57 } 58 -- 0-DAY CI Kernel Test Service https://01.org/lkp