From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59154C433FE for ; Mon, 17 Oct 2022 18:20:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230048AbiJQSUn (ORCPT ); Mon, 17 Oct 2022 14:20:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52392 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230118AbiJQSUl (ORCPT ); Mon, 17 Oct 2022 14:20:41 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 1C7A61A3A9; Mon, 17 Oct 2022 11:20:39 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1D90B1042; Mon, 17 Oct 2022 11:20:45 -0700 (PDT) Received: from bogus (unknown [10.57.36.55]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D9A7B3F792; Mon, 17 Oct 2022 11:20:37 -0700 (PDT) Date: Mon, 17 Oct 2022 19:20:35 +0100 From: Sudeep Holla To: Manank Patel Cc: rafael@kernel.org, lenb@kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Fixes: 91cefefb6991 ("ACPI: PCC: replace wait_for_completion()") Message-ID: <20221017182035.3g67uudttl6k5gag@bogus> References: <20221013130311.1433314-1-pmanank200502@gmail.com> <20221017174915.45916-1-pmanank200502@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221017174915.45916-1-pmanank200502@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Mon, Oct 17, 2022 at 11:19:15PM +0530, Manank Patel wrote: > Fixed unintentional u32 overflow by changing PCC_CMD_WAIT_RETRIES_NUM to 500ULL > You just need to add the below fixes line above Signed-off tag. You seemed to have changed the $subject. Please retain the origin subject Please post it again cleanly marking it as v2(as in the subject must be [PATCH v2] "ACPI: PCC: Fix unintentional integer overflow" Fixes: 91cefefb6991 ("ACPI: PCC: replace wait_for_completion()") > Signed-off-by: Manank Patel > --- > > Sorry for the spam, I made a mistake in the previous patch (I had a confusion > in your suggestion about the Fixes tag).As you would have realised, i'm new > to this, and not so familiar with the workflow (Though I have read the > Documentation). Let me know if you have any suggestions. > Add a text here pointing what changed from v1->v2 v1->v2: Change the macro itself ULL instead typecasting in the code Hope this helps. With all these changes incorporated in v2, you can add my Acked-by: Sudeep Holla -- Regards, Sudeep