From: Bjorn Helgaas <helgaas@kernel.org>
To: Jianmin Lv <lvjianmin@loongson.cn>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Marc Zyngier <maz@kernel.org>,
linux-kernel@vger.kernel.org, loongarch@lists.linux.dev,
Jiaxun Yang <jiaxun.yang@flygoat.com>,
Huacai Chen <chenhuacai@loongson.cn>,
Bjorn Helgaas <bhelgaas@google.com>, Len Brown <lenb@kernel.org>,
rafael@kernel.org, linux-pci@vger.kernel.org,
linux-acpi@vger.kernel.org
Subject: Re: [PATCH V4 1/4] ACPI / PCI: fix LPIC IRQ model default PCI IRQ polarity
Date: Fri, 21 Oct 2022 07:01:29 -0500 [thread overview]
Message-ID: <20221021120129.GA185586@bhelgaas> (raw)
In-Reply-To: <f8a64289-6560-7d75-461c-39b7a612e9c2@loongson.cn>
On Fri, Oct 21, 2022 at 09:58:57AM +0800, Jianmin Lv wrote:
> On 2022/10/21 上午12:47, Bjorn Helgaas wrote:
> > On Thu, Oct 20, 2022 at 04:22:02PM +0800, Jianmin Lv wrote:
> > > On LoongArch ACPI based systems, the PCI devices (e.g. sata
> > > controlers and PCI-to-to PCI bridge controlers) existed in
> > > Loongson chipsets output high-level interrupt signal to the
> > > interrupt controller they connected to,
> > The point is that one should be able to write this code from a spec,
> > without having to empirically discover the interrupt polarity. What
> > spec tells you about using ACTIVE_HIGH here?
> >
> Yes, no mentions for the inverter in ACPI spec, the description about
> device interrupt type can be found in Loongson chipset manual:
>
> https://github.com/loongson/LoongArch-Documentation/blob/main/docs/Loongson-7A1000-usermanual-EN/interrupt-controller/device-interrupt-types.adoc
That's the kind of reference I was looking for. The link to HTML is
convenient in some ways, but since specs evolve over time and URLs are
ephemeral, I think a citation like "Loongson 7A1000 Bridge User Manual
v2.00, sec 5.3" is more likely to be useful far in the future.
Bjorn
next prev parent reply other threads:[~2022-10-21 12:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-20 8:22 [PATCH V4 0/4] irqchip: Support to set irq type for ACPI path Jianmin Lv
2022-10-20 8:22 ` [PATCH V4 1/4] ACPI / PCI: fix LPIC IRQ model default PCI IRQ polarity Jianmin Lv
2022-10-20 16:47 ` Bjorn Helgaas
2022-10-21 1:58 ` Jianmin Lv
2022-10-21 12:01 ` Bjorn Helgaas [this message]
2022-10-22 2:05 ` Jianmin Lv
2022-10-20 8:22 ` [PATCH V4 2/4] irqchip/loongson-pch-pic: fix translate callback for DT path Jianmin Lv
2022-10-20 8:22 ` [PATCH V4 3/4] irqchip/loongson-pch-pic: Support to set IRQ type for ACPI path Jianmin Lv
2022-10-20 8:22 ` [PATCH V4 4/4] irqchip/loongson-liointc: " Jianmin Lv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221021120129.GA185586@bhelgaas \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=chenhuacai@loongson.cn \
--cc=jiaxun.yang@flygoat.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=lvjianmin@loongson.cn \
--cc=maz@kernel.org \
--cc=rafael@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).