From: Pin-yen Lin <treapking@chromium.org>
To: Andrzej Hajda <andrzej.hajda@intel.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Robert Foss <rfoss@kernel.org>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Jonas Karlman <jonas@kwiboo.se>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Daniel Scally <djrscally@gmail.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Prashant Malani <pmalani@chromium.org>,
Benson Leung <bleung@chromium.org>,
Guenter Roeck <groeck@chromium.org>
Cc: "Xin Ji" <xji@analogixsemi.com>,
"Javier Martinez Canillas" <javierm@redhat.com>,
"Lyude Paul" <lyude@redhat.com>,
linux-kernel@vger.kernel.org,
"Pin-yen Lin" <treapking@chromium.org>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
chrome-platform@lists.linux.dev,
"Nícolas F . R . A . Prado" <nfraprado@collabora.com>,
"Marek Vasut" <marex@denx.de>,
"Hsin-Yi Wang" <hsinyi@chromium.org>,
devicetree@vger.kernel.org, "Allen Chen" <allen.chen@ite.com.tw>,
dri-devel@lists.freedesktop.org,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Stephen Boyd" <swboyd@chromium.org>,
linux-acpi@vger.kernel.org, "Chen-Yu Tsai" <wenst@chromium.org>
Subject: [PATCH v13 02/10] platform/chrome: cros_ec_typec: Purge blocking switch devlinks
Date: Fri, 3 Mar 2023 22:33:42 +0800 [thread overview]
Message-ID: <20230303143350.815623-3-treapking@chromium.org> (raw)
In-Reply-To: <20230303143350.815623-1-treapking@chromium.org>
From: Prashant Malani <pmalani@chromium.org>
When using OF graph, the fw_devlink code will create links between the
individual port driver (cros-ec-typec here) and the parent device for
a Type-C switch (like mode-switch). Since the mode-switch will in turn
have the usb-c-connector (i.e the child of the port driver) as a
supplier, fw_devlink will not be able to resolve the cyclic dependency
correctly.
As a result, the mode-switch driver probe() never runs, so mode-switches
are never registered. Because of that, the port driver probe constantly
fails with -EPROBE_DEFER, because the Type-C connector class requires all
switch devices to be registered prior to port registration.
To break this deadlock and allow the mode-switch registration to occur,
purge all the usb-c-connector nodes' absent suppliers. This eliminates
the connector as a supplier for a switch and allows it to be probed.
Signed-off-by: Prashant Malani <pmalani@chromium.org>
Signed-off-by: Pin-yen Lin <treapking@chromium.org>
Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>
Tested-by: Chen-Yu Tsai <wenst@chromium.org>
Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
---
(no changes since v11)
Changes in v11:
- Collected Acked-by tag
Changes in v10:
- Collected Reviewed-by and Tested-by tags
Changes in v7:
- Fix the long comment lines
Changes in v6:
- New in v6
drivers/platform/chrome/cros_ec_typec.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platform/chrome/cros_ec_typec.c
index 001b0de95a46..bbc95a3ba5a7 100644
--- a/drivers/platform/chrome/cros_ec_typec.c
+++ b/drivers/platform/chrome/cros_ec_typec.c
@@ -385,6 +385,16 @@ static int cros_typec_init_ports(struct cros_typec_data *typec)
return -EINVAL;
}
+ /*
+ * OF graph may have set up some device links with switches,
+ * since connectors have their own compatible. Purge these
+ * to avoid a deadlock in switch probe (the switch mistakenly
+ * assumes the connector is a supplier).
+ */
+ if (dev_of_node(dev))
+ device_for_each_child_node(dev, fwnode)
+ fw_devlink_purge_absent_suppliers(fwnode);
+
/* DT uses "reg" to specify port number. */
port_prop = dev->of_node ? "reg" : "port-number";
device_for_each_child_node(dev, fwnode) {
--
2.40.0.rc0.216.gc4246ad0f0-goog
next prev parent reply other threads:[~2023-03-03 14:34 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-03 14:33 [PATCH v13 00/10] Register Type-C mode-switch in DP bridge endpoints Pin-yen Lin
2023-03-03 14:33 ` [PATCH v13 01/10] device property: Add remote endpoint to devcon matcher Pin-yen Lin
2023-03-06 11:43 ` Andy Shevchenko
2023-03-06 11:54 ` Sakari Ailus
2023-03-08 7:30 ` Heikki Krogerus
2023-03-03 14:33 ` Pin-yen Lin [this message]
2023-03-03 14:33 ` [PATCH v13 03/10] drm/display: Add Type-C switch helpers Pin-yen Lin
2023-03-06 11:49 ` Andy Shevchenko
2023-03-08 10:20 ` Pin-yen Lin
2023-03-08 15:28 ` Andy Shevchenko
2023-03-09 10:20 ` Pin-yen Lin
2023-03-03 14:33 ` [PATCH v13 04/10] dt-bindings: display: bridge: anx7625: Add mode-switch support Pin-yen Lin
2023-03-03 14:33 ` [PATCH v13 05/10] drm/bridge: anx7625: Check for Type-C during panel registration Pin-yen Lin
2023-03-06 11:51 ` Andy Shevchenko
2023-03-08 10:25 ` Pin-yen Lin
2023-03-03 14:33 ` [PATCH v13 06/10] drm/bridge: Remove redundant i2c_client in anx7625/it6505 Pin-yen Lin
2023-03-03 14:33 ` [PATCH v13 07/10] drm/bridge: anx7625: Register Type C mode switches Pin-yen Lin
2023-03-06 11:55 ` Andy Shevchenko
2023-03-08 13:44 ` Pin-yen Lin
2023-03-03 14:33 ` [PATCH v13 08/10] dt-bindings: display: bridge: it6505: Add mode-switch support Pin-yen Lin
2023-03-03 14:33 ` [PATCH v13 09/10] drm/bridge: it6505: Fix Kconfig indentation Pin-yen Lin
2023-03-03 14:33 ` [PATCH v13 10/10] drm/bridge: it6505: Register Type C mode switches Pin-yen Lin
2023-03-06 12:02 ` Andy Shevchenko
2023-03-08 13:51 ` Pin-yen Lin
2023-03-08 15:31 ` Andy Shevchenko
2023-03-09 10:21 ` Pin-yen Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230303143350.815623-3-treapking@chromium.org \
--to=treapking@chromium.org \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@gmail.com \
--cc=allen.chen@ite.com.tw \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andrzej.hajda@intel.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=djrscally@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=groeck@chromium.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=hsinyi@chromium.org \
--cc=javierm@redhat.com \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lyude@redhat.com \
--cc=marex@denx.de \
--cc=neil.armstrong@linaro.org \
--cc=nfraprado@collabora.com \
--cc=pmalani@chromium.org \
--cc=rafael@kernel.org \
--cc=rfoss@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=swboyd@chromium.org \
--cc=tzimmermann@suse.de \
--cc=wenst@chromium.org \
--cc=xji@analogixsemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).