From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8B6EC76195 for ; Mon, 27 Mar 2023 11:31:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229884AbjC0Lbg (ORCPT ); Mon, 27 Mar 2023 07:31:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44980 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229475AbjC0Lbf (ORCPT ); Mon, 27 Mar 2023 07:31:35 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 46F38BD; Mon, 27 Mar 2023 04:31:34 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3E3DC4B3; Mon, 27 Mar 2023 04:32:18 -0700 (PDT) Received: from bogus (unknown [10.57.52.160]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5AC593F663; Mon, 27 Mar 2023 04:31:31 -0700 (PDT) Date: Mon, 27 Mar 2023 12:30:57 +0100 From: Sudeep Holla To: Huisong Li Cc: robbiek@xsightlabs.com, linux-acpi@vger.kernel.org, Sudeep Holla , linux-kernel@vger.kernel.org, rafael@kernel.org, rafael.j.wysocki@intel.com, wanghuiqiang@huawei.com, zhangzekun11@huawei.com, wangxiongfeng2@huawei.com, tanxiaofei@huawei.com, guohanjun@huawei.com, xiexiuqi@huawei.com, wangkefeng.wang@huawei.com, huangdaode@huawei.com Subject: Re: [PATCH v2 1/2] mailbox: pcc: Add support for platform notification handling Message-ID: <20230327113057.cc2ufila5z25mgic@bogus> References: <20221016034043.52227-1-lihuisong@huawei.com> <20230314111135.16520-1-lihuisong@huawei.com> <20230314111135.16520-2-lihuisong@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230314111135.16520-2-lihuisong@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Tue, Mar 14, 2023 at 07:11:34PM +0800, Huisong Li wrote: > Currently, PCC driver doesn't support the processing of platform > notification for type 4 PCC subspaces. > > According to ACPI specification, if platform sends a notification > to OSPM, it must clear the command complete bit and trigger platform > interrupt. OSPM needs to check whether the command complete bit is > cleared, clear platform interrupt, process command, and then set the > command complete and ring doorbell to the Platform. > > Let us stash the value of the pcc type and use the same while processing > the interrupt of the channel. We also need to set the command complete > bit and ring doorbell in the interrupt handler for the type 4 channel to > complete the communication flow after processing the notification from > the Platform. > > Signed-off-by: Huisong Li > --- > drivers/mailbox/pcc.c | 50 +++++++++++++++++++++++++++++++++++-------- > 1 file changed, 41 insertions(+), 9 deletions(-) > > diff --git a/drivers/mailbox/pcc.c b/drivers/mailbox/pcc.c > index 105d46c9801b..a0a87c480d8b 100644 > --- a/drivers/mailbox/pcc.c > +++ b/drivers/mailbox/pcc.c > @@ -91,6 +91,7 @@ struct pcc_chan_reg { > * @cmd_update: PCC register bundle for the command complete update register > * @error: PCC register bundle for the error status register > * @plat_irq: platform interrupt > + * @type: PCC subspace type > */ > struct pcc_chan_info { > struct pcc_mbox_chan chan; > @@ -100,12 +101,15 @@ struct pcc_chan_info { > struct pcc_chan_reg cmd_update; > struct pcc_chan_reg error; > int plat_irq; > + u8 type; > }; > > #define to_pcc_chan_info(c) container_of(c, struct pcc_chan_info, chan) > static struct pcc_chan_info *chan_info; > static int pcc_chan_count; > > +static int pcc_send_data(struct mbox_chan *chan, void *data); > + > /* > * PCC can be used with perf critical drivers such as CPPC > * So it makes sense to locally cache the virtual address and > @@ -221,6 +225,34 @@ static int pcc_map_interrupt(u32 interrupt, u32 flags) > return acpi_register_gsi(NULL, interrupt, trigger, polarity); > } > > +static bool pcc_mbox_cmd_complete_check(struct pcc_chan_info *pchan) > +{ > + u64 val; > + int ret; > + > + ret = pcc_chan_reg_read(&pchan->cmd_complete, &val); > + if (ret) > + return false; > + > + if (!pchan->cmd_complete.gas) > + return true; > + > + /* > + * Judge if the channel respond the interrupt based on the value of > + * command complete. > + */ > + val &= pchan->cmd_complete.status_mask; [super nit] Would prefer an blank line here. -- Regards, Sudeep