[PATCH v7 2/9] acpi/bus: Set driver_data to NULL every time .add() fails

From: Michal Wilczynski <michal.wilczynski@intel.com>
To: linux-acpi@vger.kernel.org
Cc: rafael@kernel.org, dan.j.williams@intel.com,
	vishal.l.verma@intel.com, lenb@kernel.org, dave.jiang@intel.com,
	ira.weiny@intel.com, rui.zhang@intel.com,
	linux-kernel@vger.kernel.org, nvdimm@lists.linux.dev,
	Michal Wilczynski <michal.wilczynski@intel.com>
Subject: [PATCH v7 2/9] acpi/bus: Set driver_data to NULL every time .add() fails
Date: Mon,  3 Jul 2023 11:02:45 +0300	[thread overview]
Message-ID: <20230703080252.2899090-3-michal.wilczynski@intel.com> (raw)
In-Reply-To: <20230703080252.2899090-1-michal.wilczynski@intel.com>

Most drivers set driver_data during .add() callback, but usually
they don't set it back to NULL in case of a failure. Set driver_data to
NULL in acpi_device_probe() to avoid code duplication.

Signed-off-by: Michal Wilczynski <michal.wilczynski@intel.com>
---
 drivers/acpi/bus.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c
index 2d6f1f45d44e..c087fd6e8398 100644
--- a/drivers/acpi/bus.c
+++ b/drivers/acpi/bus.c
@@ -1014,8 +1014,10 @@ static int acpi_device_probe(struct device *dev)
 		return -ENOSYS;
 
 	ret = acpi_drv->ops.add(acpi_dev);
-	if (ret)
+	if (ret) {
+		acpi_dev->driver_data = NULL;
 		return ret;
+	}
 
 	pr_debug("Driver [%s] successfully bound to device [%s]\n",
 		 acpi_drv->name, acpi_dev->pnp.bus_id);
-- 
2.41.0

