From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Linux ACPI <linux-acpi@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Russell King (Oracle)" <linux@armlinux.org.uk>
Subject: Re: [PATCH v1 1/4] ACPI: scan: Fix device check notification handling
Date: Thu, 22 Feb 2024 18:50:59 +0000 [thread overview]
Message-ID: <20240222185059.00005f40@Huawei.com> (raw)
In-Reply-To: <4886572.GXAFRqVoOG@kreacher>
On Wed, 21 Feb 2024 21:01:02 +0100
"Rafael J. Wysocki" <rjw@rjwysocki.net> wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> It is generally invalid to fail a Device Check notification if the scan
> handler has not been attached to the given device after a bus rescan,
> because there may be valid reasons for the scan handler to refuse
> attaching to the device (for example, the device is not ready).
>
> For this reason, modify acpi_scan_device_check() to return 0 in that
> case without printing a warning.
>
> While at it, reduce the log level of the "already enumerated" message
> in the same function, because it is only interesting when debugging
> notification handling
>
> Fixes: 443fc8202272 ("ACPI / hotplug: Rework generic code to handle suprise removals")
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Seems reasonable to me. Not sure it fixes any bugs anyone has seen
in the wild though. I'd not give it a fixes tag without such a
known case, but your subsystem so fair enough!
Thanks for resolving how to handle the processor case.
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> ---
> drivers/acpi/scan.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> Index: linux-pm/drivers/acpi/scan.c
> ===================================================================
> --- linux-pm.orig/drivers/acpi/scan.c
> +++ linux-pm/drivers/acpi/scan.c
> @@ -314,18 +314,14 @@ static int acpi_scan_device_check(struct
> * again).
> */
> if (adev->handler) {
> - dev_warn(&adev->dev, "Already enumerated\n");
> - return -EALREADY;
> + dev_dbg(&adev->dev, "Already enumerated\n");
> + return 0;
> }
> error = acpi_bus_scan(adev->handle);
> if (error) {
> dev_warn(&adev->dev, "Namespace scan failure\n");
> return error;
> }
> - if (!adev->handler) {
> - dev_warn(&adev->dev, "Enumeration failure\n");
> - error = -ENODEV;
> - }
> } else {
> error = acpi_scan_device_not_enumerated(adev);
> }
>
>
>
next prev parent reply other threads:[~2024-02-22 18:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-21 19:59 [PATCH v1 0/4] ACPI: scan: Check enabled _STA bit on Bus/Device Checks Rafael J. Wysocki
2024-02-21 20:01 ` [PATCH v1 1/4] ACPI: scan: Fix device check notification handling Rafael J. Wysocki
2024-02-22 18:50 ` Jonathan Cameron [this message]
2024-02-21 20:01 ` [PATCH v1 2/4] ACPI: scan: Relocate acpi_bus_trim_one() Rafael J. Wysocki
2024-02-22 17:09 ` Jonathan Cameron
2024-02-21 20:02 ` [PATCH v1 3/4] ACPI: scan: Rework Device Check and Bus Check notification handling Rafael J. Wysocki
2024-02-22 18:28 ` Jonathan Cameron
2024-02-26 15:37 ` Rafael J. Wysocki
2024-02-26 15:54 ` Rafael J. Wysocki
2024-02-21 20:03 ` [PATCH v1 4/4] ACPI: scan: Make acpi_processor_add() check the device enabled bit Rafael J. Wysocki
2024-02-22 18:47 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240222185059.00005f40@Huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mika.westerberg@linux.intel.com \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).