From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Jan Engelhardt <jengelh@inai.de>
Cc: linux-acpi@vger.kernel.org
Subject: Re: [PATCH] x86: ignore unspecified bit positions in the ACPI global lock field
Date: Thu, 19 Mar 2020 13:22:18 +0100 [thread overview]
Message-ID: <21714545.r8kEu0rk5n@kreacher> (raw)
In-Reply-To: <nycvar.YFH.7.76.2003191136480.30451@n3.vanv.qr>
On Thursday, March 19, 2020 11:46:13 AM CET Jan Engelhardt wrote:
>
> On Saturday 2020-03-14 10:46, Rafael J. Wysocki wrote:
> >On Thursday, March 5, 2020 1:24:25 PM CET Jan Engelhardt wrote:
> >> The value in "new" is constructed from "old" such that all bits defined
> >> as reserved by the ACPI spec[1] are left untouched. But if those bits
> >> do not happen to be all zero, "new < 3" will not evaluate to true.
> >>
> >> The firmware of the laptop(s) Medion MD63490 / Akoya P15648 comes with
> >> garbage inside the "FACS" ACPI table. The starting value is
> >> old=0x4944454d, therefore new=0x4944454e, which is >= 3. Mask off
> >> the reserved bits.
> >>
> >> - return (new < 3) ? -1 : 0;
> >> + return ((new & 0x3) < 3) ? -1 : 0;
> >
> >Applied as 5.7 material, thanks!
>
> Would it make sense to funnel this into the upcoming 5.6?
>
It's been marked for -stable, so it will get into 5.6.y early.
Hopefully, it will get some extra test coverage before that.
prev parent reply other threads:[~2020-03-19 12:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-05 12:24 [PATCH] x86: ignore unspecified bit positions in the ACPI global lock field Jan Engelhardt
2020-03-14 9:46 ` Rafael J. Wysocki
2020-03-19 10:46 ` Jan Engelhardt
2020-03-19 12:22 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21714545.r8kEu0rk5n@kreacher \
--to=rjw@rjwysocki.net \
--cc=jengelh@inai.de \
--cc=linux-acpi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).