* [PATCH] device property: Fix the description of struct fwnode_operations
@ 2019-10-08 13:26 Heikki Krogerus
2019-10-08 14:03 ` Andy Shevchenko
0 siblings, 1 reply; 3+ messages in thread
From: Heikki Krogerus @ 2019-10-08 13:26 UTC (permalink / raw)
To: Rafael J. Wysocki; +Cc: Sakari Ailus, Andy Shevchenko, linux-acpi, linux-kernel
Adding description for the device_is_available member which
was missing, and fixing the description of the member
property_read_int_array.
Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
---
include/linux/fwnode.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/linux/fwnode.h b/include/linux/fwnode.h
index 6ae05b9ce359..fc002aacae8d 100644
--- a/include/linux/fwnode.h
+++ b/include/linux/fwnode.h
@@ -50,11 +50,11 @@ struct fwnode_reference_args {
* struct fwnode_operations - Operations for fwnode interface
* @get: Get a reference to an fwnode.
* @put: Put a reference to an fwnode.
+ * @device_is_available: Return true if the device is available.
* @device_get_match_data: Return the device driver match data.
* @property_present: Return true if a property is present.
- * @property_read_integer_array: Read an array of integer properties. Return
- * zero on success, a negative error code
- * otherwise.
+ * @property_read_int_array: Read an array of integer properties. Return zero on
+ * success, a negative error code otherwise.
* @property_read_string_array: Read an array of string properties. Return zero
* on success, a negative error code otherwise.
* @get_parent: Return the parent of an fwnode.
--
2.23.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] device property: Fix the description of struct fwnode_operations
2019-10-08 13:26 [PATCH] device property: Fix the description of struct fwnode_operations Heikki Krogerus
@ 2019-10-08 14:03 ` Andy Shevchenko
2019-10-11 9:34 ` Rafael J. Wysocki
0 siblings, 1 reply; 3+ messages in thread
From: Andy Shevchenko @ 2019-10-08 14:03 UTC (permalink / raw)
To: Heikki Krogerus; +Cc: Rafael J. Wysocki, Sakari Ailus, linux-acpi, linux-kernel
On Tue, Oct 08, 2019 at 04:26:06PM +0300, Heikki Krogerus wrote:
> Adding description for the device_is_available member which
> was missing, and fixing the description of the member
> property_read_int_array.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> include/linux/fwnode.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/include/linux/fwnode.h b/include/linux/fwnode.h
> index 6ae05b9ce359..fc002aacae8d 100644
> --- a/include/linux/fwnode.h
> +++ b/include/linux/fwnode.h
> @@ -50,11 +50,11 @@ struct fwnode_reference_args {
> * struct fwnode_operations - Operations for fwnode interface
> * @get: Get a reference to an fwnode.
> * @put: Put a reference to an fwnode.
> + * @device_is_available: Return true if the device is available.
> * @device_get_match_data: Return the device driver match data.
> * @property_present: Return true if a property is present.
> - * @property_read_integer_array: Read an array of integer properties. Return
> - * zero on success, a negative error code
> - * otherwise.
> + * @property_read_int_array: Read an array of integer properties. Return zero on
> + * success, a negative error code otherwise.
> * @property_read_string_array: Read an array of string properties. Return zero
> * on success, a negative error code otherwise.
> * @get_parent: Return the parent of an fwnode.
> --
> 2.23.0
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] device property: Fix the description of struct fwnode_operations
2019-10-08 14:03 ` Andy Shevchenko
@ 2019-10-11 9:34 ` Rafael J. Wysocki
0 siblings, 0 replies; 3+ messages in thread
From: Rafael J. Wysocki @ 2019-10-11 9:34 UTC (permalink / raw)
To: Andy Shevchenko, Heikki Krogerus; +Cc: Sakari Ailus, linux-acpi, linux-kernel
On Tuesday, October 8, 2019 4:03:06 PM CEST Andy Shevchenko wrote:
> On Tue, Oct 08, 2019 at 04:26:06PM +0300, Heikki Krogerus wrote:
> > Adding description for the device_is_available member which
> > was missing, and fixing the description of the member
> > property_read_int_array.
>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> >
> > Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> > ---
> > include/linux/fwnode.h | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/include/linux/fwnode.h b/include/linux/fwnode.h
> > index 6ae05b9ce359..fc002aacae8d 100644
> > --- a/include/linux/fwnode.h
> > +++ b/include/linux/fwnode.h
> > @@ -50,11 +50,11 @@ struct fwnode_reference_args {
> > * struct fwnode_operations - Operations for fwnode interface
> > * @get: Get a reference to an fwnode.
> > * @put: Put a reference to an fwnode.
> > + * @device_is_available: Return true if the device is available.
> > * @device_get_match_data: Return the device driver match data.
> > * @property_present: Return true if a property is present.
> > - * @property_read_integer_array: Read an array of integer properties. Return
> > - * zero on success, a negative error code
> > - * otherwise.
> > + * @property_read_int_array: Read an array of integer properties. Return zero on
> > + * success, a negative error code otherwise.
> > * @property_read_string_array: Read an array of string properties. Return zero
> > * on success, a negative error code otherwise.
> > * @get_parent: Return the parent of an fwnode.
>
>
Applying as 5.5 material, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-10-11 9:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-08 13:26 [PATCH] device property: Fix the description of struct fwnode_operations Heikki Krogerus
2019-10-08 14:03 ` Andy Shevchenko
2019-10-11 9:34 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).