From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Mattia Dongili <malattia@linux.it>,
"Schmauss, Erik" <erik.schmauss@intel.com>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.co>,
Darren Hart <dvhart@infradead.org>,
Andy Shevchenko <andy@infradead.org>,
Platform Driver <platform-driver-x86@vger.kernel.org>,
Dominik Mierzejewski <dominik@greysector.net>,
William Bader <williambader@hotmail.com>
Subject: Re: [PATCH 1/2] [sony-laptop] SNC calls should handle BUFFER types
Date: Sat, 09 May 2020 11:15:31 +0200 [thread overview]
Message-ID: <2337210.yqbmfTWyIV@kreacher> (raw)
In-Reply-To: <CAHp75Ve--kecWYufUiXUxUZM=tL3NgKtDNf6Ny4ds8GJVz_0pA@mail.gmail.com>
On Tuesday, May 5, 2020 2:27:15 PM CEST Andy Shevchenko wrote:
> +Cc ACPI(CA) people
>
> On Tue, May 5, 2020 at 1:16 PM <malattia@linux.it> wrote:
> > After commit 6d232b29cfce ("ACPICA: Dispatcher: always generate buffer
> > objects for ASL create_field() operator") ACPICA creates buffers even
> > when new fields are small enough to fit into an integer.
>
> > Many SNC calls counted on the old behaviour.
>
> Rafael, Erik, is it correct behaviour from ACPICA p.o.v. nowadays or
> should be fixed rather there?
The new behavior is correct and it is needed to avoid other failures elsewhere.
Unfortunately, all of the call sites assuming that the conversion will happen
need to be fixed.
Cheers!
prev parent reply other threads:[~2020-05-09 9:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200505111810.65586-1-malattia@linux.it>
[not found] ` <20200505111810.65586-2-malattia@linux.it>
2020-05-05 12:27 ` [PATCH 1/2] [sony-laptop] SNC calls should handle BUFFER types Andy Shevchenko
2020-05-09 9:15 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2337210.yqbmfTWyIV@kreacher \
--to=rjw@rjwysocki.net \
--cc=andy.shevchenko@gmail.com \
--cc=andy@infradead.org \
--cc=dominik@greysector.net \
--cc=dvhart@infradead.org \
--cc=erik.schmauss@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=malattia@linux.it \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rafael.j.wysocki@intel.co \
--cc=williambader@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).