From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Matthew Garrett <matthew.garrett@coreos.com>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>
Cc: Mario Limonciello <mario_limonciello@dell.com>,
Mark Brown <broonie@kernel.org>,
Dominik Brodowski <linux@dominikbrodowski.net>,
"robert.moore@intel.com" <robert.moore@intel.com>,
"lv.zheng@intel.com" <lv.zheng@intel.com>,
"rafael.j.wysocki@intel.com" <rafael.j.wysocki@intel.com>,
"han.lu@intel.com" <han.lu@intel.com>,
"yang.jie@intel.com" <yang.jie@intel.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
Matthew Garrett <mjg59@coreos.com>,
"liam.r.girdwood@intel.com" <liam.r.girdwood@intel.com>
Subject: Re: commit b1ef29725865 (ACPI _REV=2) causes sound regression on Dell XPS 13 [Was: Discussion around quirking the _REV behavior for the XPS 13 (2015) until 4.2]
Date: Wed, 13 May 2015 01:38:59 +0200 [thread overview]
Message-ID: <28099406.1MOrFLUSgY@vostro.rjw.lan> (raw)
In-Reply-To: <CAPeXnHss+k4xqYDZsDycKEAtLGMBbsnsMiHsZ_voigbPoq3vUw@mail.gmail.com>
On Tuesday, May 12, 2015 10:43:33 AM Matthew Garrett wrote:
> On Tue, May 12, 2015 at 10:29 AM, Mario Limonciello
> <mario_limonciello@dell.com> wrote:
> > Just to be clear, from the Dell side only the XPS 13 9343 has this _REV
> > behavior.
>
> The Inspiron 7437 queries _REV and uses it to modify its EC behaviour,
> and apparently breaks on Linux without that.
>
> > What's wrong with a DMI quirk until I2S is mature on the kernel side and
> > userspace is new enough in distros? Is it too early in boot for DMI quirks?
> > That would enforce that no other machines can use _REV value of 5 to detect
> > Linux without breaking the 9343.
>
> DMI quirking is fine, but it has to be behind a config option. We're
> going to have to carry the quirk for several years because we have to
> support old userspace for an arbitrarily long time, and if there's no
> config option then Linux will be stuck in HDA mode for that entire
> time.
One problem with the DMI-based approach is that _REV is constant in ACPICA,
so to be able to return different values from it for different systems, we'll
need to add some ACPICA-ish code handling that specifically for Linux and
we're a bit too late in the cycle for that.
So here's what I'm going to do. I'll revert commit b1ef29725865 for 4.1,
but *only* for 4.1 (I've actually queued up a revert of it already) and
I'll revert that revert during the 4.2 merge window.
In the meantime, we'll develop the code to implement the DMI-based quirks
for the Dells and apply it for 4.2.
Are there any volunteers for doing the last part?
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
next prev parent reply other threads:[~2015-05-12 23:13 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-28 23:21 Discussion around quirking the _REV behavior for the XPS 13 (2015) until 4.2 Mario Limonciello
2015-05-04 23:26 ` Mario Limonciello
2015-05-11 18:26 ` commit b1ef29725865 (ACPI _REV=2) causes sound regression on Dell XPS 13 [Was: Discussion around quirking the _REV behavior for the XPS 13 (2015) until 4.2] Dominik Brodowski
2015-05-11 19:01 ` Mario Limonciello
2015-05-12 7:27 ` Jie, Yang
2015-05-12 10:12 ` Mark Brown
2015-05-12 15:26 ` Mario Limonciello
2015-05-12 16:18 ` Mark Brown
2015-05-12 16:45 ` Mario Limonciello
2015-05-12 17:35 ` Mark Brown
2015-05-13 2:14 ` Jie, Yang
2015-05-13 21:32 ` Mario Limonciello
2015-05-12 17:21 ` Matthew Garrett
2015-05-12 17:29 ` Mario Limonciello
2015-05-12 17:40 ` Mark Brown
2015-05-12 17:43 ` Matthew Garrett
2015-05-12 17:49 ` Mario Limonciello
2015-05-12 23:38 ` Rafael J. Wysocki [this message]
2015-05-13 6:36 ` Dominik Brodowski
2015-05-13 13:44 ` Rafael J. Wysocki
2015-05-12 17:32 ` Mark Brown
2015-05-12 17:13 ` Dominik Brodowski
2015-05-12 17:30 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28099406.1MOrFLUSgY@vostro.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=han.lu@intel.com \
--cc=liam.r.girdwood@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux@dominikbrodowski.net \
--cc=lv.zheng@intel.com \
--cc=mario_limonciello@dell.com \
--cc=matthew.garrett@coreos.com \
--cc=mjg59@coreos.com \
--cc=rafael.j.wysocki@intel.com \
--cc=robert.moore@intel.com \
--cc=yang.jie@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).