Linux-ACPI Archive on lore.kernel.org
 help / color / Atom feed
From: <Charles.Hyde@dellteam.com>
To: <oneukum@suse.com>, <lenb@kernel.org>, <rjw@rjwysocki.net>
Cc: <Mario.Limonciello@dell.com>, <nic_swsd@realtek.com>,
	<linux-acpi@vger.kernel.org>, <linux-usb@vger.kernel.org>
Subject: RE: [PATCH 1/3] net: cdc_ncm: add get/set ethernet address functions
Date: Tue, 3 Sep 2019 16:45:20 +0000
Message-ID: <2dd5f5fa0e124f8f87ac2c75af1ef81c@AUSX13MPS307.AMER.DELL.COM> (raw)
In-Reply-To: <1567417420.2469.3.camel@suse.com>

> > This patch adds support for pushing a MAC address out to USB based
> > ethernet controllers driven by cdc_ncm.  With this change, ifconfig
> > can now set the device's MAC address.  For example, the Dell Universal
> > Dock
> > D6000 is driven by cdc_ncm.  The D6000 can now have its MAC address
> > set by ifconfig, as it can be done in Windows.  This was tested with a
> > D6000 using ifconfig on an x86 based chromebook, where iproute2 is not
> > available.
> 
> > +/* Provide method to push MAC address to the USB device's ethernet
> controller.
> > + */
> > +int cdc_ncm_set_mac_addr(struct net_device *net, void *p) {
> > +	struct usbnet *dev = netdev_priv(net);
> > +
> > +	/* Try to push the MAC address out to the device.  Ignore any errors,
> > +	 * to be compatible with prior versions of this source.
> > +	 */
> > +	cdc_ncm_set_ethernet_address(dev, (struct sockaddr *)p);
> 
> You are throwing away error reports.
> 
> 	Regards
> 		Oliver


My intent is limit the changes needed to support setting the MAC address., thus any potential source code errors.  I have not changed the current behavior of the driver with respect to error processing.  The existing source does not check for error return values, therefore my changes also do not check error return values.

Charles

  reply index

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-30 19:37 Charles.Hyde
2019-09-02  9:43 ` Oliver Neukum
2019-09-03 16:45   ` Charles.Hyde [this message]
2019-09-05 21:01 Charles.Hyde
2019-09-06  9:02 ` Bjørn Mork
2019-09-06 18:00   ` Charles.Hyde
2019-09-06 18:15     ` Alan Stern
2019-09-06 18:19       ` Charles.Hyde
2019-09-06 20:07         ` Bjørn Mork
2019-09-06 20:20           ` Charles.Hyde
2019-09-06 20:39             ` Bjørn Mork
2019-09-06 21:00               ` Charles.Hyde

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2dd5f5fa0e124f8f87ac2c75af1ef81c@AUSX13MPS307.AMER.DELL.COM \
    --to=charles.hyde@dellteam.com \
    --cc=Mario.Limonciello@dell.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=nic_swsd@realtek.com \
    --cc=oneukum@suse.com \
    --cc=rjw@rjwysocki.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-ACPI Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-acpi/0 linux-acpi/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-acpi linux-acpi/ https://lore.kernel.org/linux-acpi \
		linux-acpi@vger.kernel.org linux-acpi@archiver.kernel.org
	public-inbox-index linux-acpi

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-acpi


AGPL code for this site: git clone https://public-inbox.org/ public-inbox