From: Hui Wang <hui.wang@canonical.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Rafael Wysocki <rafael.j.wysocki@intel.com>,
manuelkrause@netscape.net
Subject: Re: [PATCH v2] ACPI: resources: add legacy irq override exception by DMI info
Date: Wed, 15 Sep 2021 20:51:07 +0800 [thread overview]
Message-ID: <338de10e-f93d-4633-b55f-81386ffb4295@canonical.com> (raw)
In-Reply-To: <CAJZ5v0jvSEdcgu+gRa2s25wW3L+RQHoyPJiorid7wZdKM23CQw@mail.gmail.com>
On 9/15/21 7:53 PM, Rafael J. Wysocki wrote:
> On Tue, Sep 14, 2021 at 3:34 PM Hui Wang <hui.wang@canonical.com> wrote:
[...]
>>
>> + override = check_override && acpi_dev_irq_override(gsi, triggering,
>> + polarity, shareable);
>> +
> This can be still made more straightforward.
>
> The local bool variable is not necessary and check below can be
> rearranged as follows below.
>
>> /*
>> * In IO-APIC mode, use overridden attribute. Two reasons:
>> * 1. BIOS bug in DSDT
>> @@ -401,7 +448,7 @@ static void acpi_dev_get_irqresource(struct resource *res, u32 gsi,
>> * using extended IRQ descriptors we take the IRQ configuration
>> * from _CRS directly.
>> */
>> - if (legacy && !acpi_get_override_irq(gsi, &t, &p)) {
>> + if (override && !acpi_get_override_irq(gsi, &t, &p)) {
> if (check_override &&
> acpi_dev_irq_override(gsi, triggering, polarity, shareable) &&
> !acpi_get_override_irq(gsi, &t, &p)) {
OK, got it. will change to it in the v3.
Thanks.
>> u8 trig = t ? ACPI_LEVEL_SENSITIVE : ACPI_EDGE_SENSITIVE;
>> u8 pol = p ? ACPI_ACTIVE_LOW : ACPI_ACTIVE_HIGH;
>>
>> --
>> 2.25.1
>>
prev parent reply other threads:[~2021-09-15 12:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-14 13:34 [PATCH v2] ACPI: resources: add legacy irq override exception by DMI info Hui Wang
2021-09-14 16:01 ` Manuel Krause
2021-09-14 23:57 ` Hui Wang
2021-09-15 11:53 ` Rafael J. Wysocki
2021-09-15 12:51 ` Hui Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=338de10e-f93d-4633-b55f-81386ffb4295@canonical.com \
--to=hui.wang@canonical.com \
--cc=linux-acpi@vger.kernel.org \
--cc=manuelkrause@netscape.net \
--cc=rafael.j.wysocki@intel.com \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).