From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 257BCC7EE23 for ; Thu, 2 Mar 2023 01:54:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229809AbjCBBy2 (ORCPT ); Wed, 1 Mar 2023 20:54:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59720 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229817AbjCBByZ (ORCPT ); Wed, 1 Mar 2023 20:54:25 -0500 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 188FE4615E for ; Wed, 1 Mar 2023 17:54:18 -0800 (PST) Received: from dggpemm500002.china.huawei.com (unknown [172.30.72.56]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4PRvGb5cv3znWRy; Thu, 2 Mar 2023 09:51:35 +0800 (CST) Received: from [10.174.178.247] (10.174.178.247) by dggpemm500002.china.huawei.com (7.185.36.229) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Thu, 2 Mar 2023 09:54:15 +0800 Subject: Re: [PATCH] acpi/arm64: Drop extra (struct resource) To: Jonathan Cameron , , Lorenzo Pieralisi , Sudeep Holla , CC: Andy Shevchenko , References: <20230301170938.9278-1-Jonathan.Cameron@huawei.com> From: Hanjun Guo Message-ID: <35c719be-e224-e3d5-3735-75df2d44f4aa@huawei.com> Date: Thu, 2 Mar 2023 09:54:15 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20230301170938.9278-1-Jonathan.Cameron@huawei.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.178.247] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggpemm500002.china.huawei.com (7.185.36.229) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On 2023/3/2 1:09, Jonathan Cameron wrote: > DEFINE_RES_IRQ() is a wrapper around the DEFINE_RES_NAMED() > macro which already has the (struct resource) for the compound > literal. > > Fixes warnings: > CC drivers/acpi/arm64/gtdt.o > CHECK drivers/acpi/arm64/gtdt.c > drivers/acpi/arm64/gtdt.c:355:19: warning: cast to non-scalar > drivers/acpi/arm64/gtdt.c:355:19: warning: cast from non-scalar > > Fixes: 52c4d11f1dce ("resource: Convert DEFINE_RES_NAMED() to be compound literal") > Signed-off-by: Jonathan Cameron > --- > drivers/acpi/arm64/gtdt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/acpi/arm64/gtdt.c b/drivers/acpi/arm64/gtdt.c > index c0e77c1c8e09..24bd479de91f 100644 > --- a/drivers/acpi/arm64/gtdt.c > +++ b/drivers/acpi/arm64/gtdt.c > @@ -352,7 +352,7 @@ static int __init gtdt_import_sbsa_gwdt(struct acpi_gtdt_watchdog *wd, > } > > irq = map_gt_gsi(wd->timer_interrupt, wd->timer_flags); > - res[2] = (struct resource)DEFINE_RES_IRQ(irq); > + res[2] = DEFINE_RES_IRQ(irq); > if (irq <= 0) { > pr_warn("failed to map the Watchdog interrupt.\n"); > nr_res--; > Looks good to me, Reviewed-by: Hanjun Guo