From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: Hans de Goede <hdegoede@redhat.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Andy Shevchenko <andy@infradead.org>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH v5 00/16] Software fwnode references
Date: Thu, 13 Jun 2019 22:28:08 +0200 [thread overview]
Message-ID: <3636687.Nc99FdWIM2@kreacher> (raw)
In-Reply-To: <20190531141547.22728-1-heikki.krogerus@linux.intel.com>
On Friday, May 31, 2019 4:15:31 PM CEST Heikki Krogerus wrote:
> Hi,
>
> This is the fourth, and hopefully the final version, of my proposal to
> make it possible to use fwnode_property_get_reference_args() also with
> software nodes. The two issues reported by Hans in v4 are now fixed,
> which were a typo in a comment, and the fwnode->secondary->secondary
> of max17074 needs to have value ERR_PTR(-ENODEV).
>
> v4 cover letter:
>
> I'm not splitting this series in two after all. After thinking about
> this for some time, I decided to add support for static software
> nodes. I did not want to support them because I don't want to make it
> easy to maintain board files, but in end they make the use of the
> software nodes so much more easier compared to if we always had to
> dynamically allocate them that it's a no-brainer. The references can
> now be also described statically. Actually, those can now only be
> described statically.
>
> Hans! I applied (hopefully) all of the fixes you proposed in v3. I
> hope you have time to test these.
>
> v3 cover letter:
>
> This is the third version of my proposal to add reference handling to
> the software node code. In this version I renamed ACPI_NAME_SIZE to
> ACPI_NAMESEG_SIZE in 6/13, and slit patch 9/13 in two separate patches
> (9/13 and 10/13) as suggested by Andy. Patch 9/13 will now only move
> the registration of max17047 out of probe, and 10/13 will introduce
> the software nodes.
>
> v2 cover letter:
>
> This is the second version of this series. In this version I'm
> introducing a new helper device_find_child_by_name() as proposed
> by Andy. Andy requested also another helper that could be used for
> chaining the fwnodes, but I decided not to add that now. I would like
> to still think about how we should handle exceptions like if there
> already is a secondary node assigned for a node.
>
> v1 cover letter:
>
> This series adds support for software fwnode reference handling. In
> practice it means making fwnode_property_get_reference_args() function
> usable in the drivers also with software nodes. I send the series
> originally as RFC [1].
>
> As the first user for the software node references, I'm converting
> intel_cht_int33fe.c to use them as part of the series.
>
> [1] https://lkml.org/lkml/2019/3/15/457
>
> thanks,
>
> Heikki Krogerus (16):
> software node: Allow node creation without properties
> software node: Simplify software_node_release() function
> software node: Add support for static node descriptors
> software node: Use kobject name when finding child nodes by name
> software node: Add software_node_get_reference_args()
> driver core: Add helper device_find_child_by_name()
> ACPI / property: Don't limit named child node matching to data nodes
> device property: Introduce fwnode_find_reference()
> device connection: Find connections also by checking the references
> usb: typec: Registering real device entries for the muxes
> platform/x86: intel_cht_int33fe: Register max17047 in its own function
> platform/x86: intel_cht_int33fe: Remove unused fusb302 device property
> platform/x86: intel_cht_int33fe: Provide software nodes for the
> devices
> platform/x86: intel_cht_int33fe: Provide fwnode for the USB connector
> platform/x86: intel_cht_int33fe: Supply fwnodes for the external
> dependencies
> platform/x86: intel_cht_int33fe: Replacing the old connections with
> references
>
> drivers/acpi/property.c | 26 +-
> drivers/base/core.c | 28 ++
> drivers/base/devcon.c | 26 ++
> drivers/base/property.c | 24 ++
> drivers/base/swnode.c | 324 +++++++++++++++++------
> drivers/platform/x86/intel_cht_int33fe.c | 291 ++++++++++++++++----
> drivers/usb/roles/class.c | 2 +-
> drivers/usb/typec/bus.h | 15 ++
> drivers/usb/typec/class.c | 17 +-
> drivers/usb/typec/mux.c | 238 ++++++++++++-----
> drivers/usb/typec/mux/pi3usb30532.c | 46 ++--
> include/linux/device.h | 2 +
> include/linux/property.h | 51 ++++
> include/linux/usb/typec_mux.h | 62 ++---
> 14 files changed, 903 insertions(+), 249 deletions(-)
>
>
All applied (but you know that already).
Thanks!
prev parent reply other threads:[~2019-06-13 20:28 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-31 14:15 [PATCH v5 00/16] Software fwnode references Heikki Krogerus
2019-05-31 14:15 ` [PATCH v5 01/16] software node: Allow node creation without properties Heikki Krogerus
2019-05-31 14:15 ` [PATCH v5 02/16] software node: Simplify software_node_release() function Heikki Krogerus
2019-05-31 14:15 ` [PATCH v5 03/16] software node: Add support for static node descriptors Heikki Krogerus
2019-05-31 14:15 ` [PATCH v5 04/16] software node: Use kobject name when finding child nodes by name Heikki Krogerus
2019-05-31 14:15 ` [PATCH v5 05/16] software node: Add software_node_get_reference_args() Heikki Krogerus
2019-05-31 14:15 ` [PATCH v5 06/16] driver core: Add helper device_find_child_by_name() Heikki Krogerus
2019-05-31 14:15 ` [PATCH v5 07/16] ACPI / property: Don't limit named child node matching to data nodes Heikki Krogerus
2019-05-31 14:15 ` [PATCH v5 08/16] device property: Introduce fwnode_find_reference() Heikki Krogerus
2019-05-31 14:15 ` [PATCH v5 09/16] device connection: Find connections also by checking the references Heikki Krogerus
2019-05-31 14:15 ` [PATCH v5 10/16] usb: typec: Registering real device entries for the muxes Heikki Krogerus
2019-05-31 14:15 ` [PATCH v5 11/16] platform/x86: intel_cht_int33fe: Register max17047 in its own function Heikki Krogerus
2019-05-31 14:15 ` [PATCH v5 12/16] platform/x86: intel_cht_int33fe: Remove unused fusb302 device property Heikki Krogerus
2019-05-31 14:15 ` [PATCH v5 13/16] platform/x86: intel_cht_int33fe: Provide software nodes for the devices Heikki Krogerus
2019-05-31 14:15 ` [PATCH v5 14/16] platform/x86: intel_cht_int33fe: Provide fwnode for the USB connector Heikki Krogerus
2019-05-31 14:15 ` [PATCH v5 15/16] platform/x86: intel_cht_int33fe: Supply fwnodes for the external dependencies Heikki Krogerus
2019-05-31 14:15 ` [PATCH v5 16/16] platform/x86: intel_cht_int33fe: Replacing the old connections with references Heikki Krogerus
2019-06-13 20:28 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3636687.Nc99FdWIM2@kreacher \
--to=rjw@rjwysocki.net \
--cc=andy@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).