From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBDB7C4346E for ; Sun, 27 Sep 2020 20:27:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9E4B92399C for ; Sun, 27 Sep 2020 20:27:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726534AbgI0U1r (ORCPT ); Sun, 27 Sep 2020 16:27:47 -0400 Received: from smtp01.smtpout.orange.fr ([80.12.242.123]:34435 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726440AbgI0U1q (ORCPT ); Sun, 27 Sep 2020 16:27:46 -0400 Received: from [192.168.42.210] ([93.22.39.148]) by mwinf5d36 with ME id Z8Th230063BnMZH038ThwF; Sun, 27 Sep 2020 22:27:44 +0200 X-ME-Helo: [192.168.42.210] X-ME-Auth: Y2hyaXN0b3BoZS5qYWlsbGV0QHdhbmFkb28uZnI= X-ME-Date: Sun, 27 Sep 2020 22:27:44 +0200 X-ME-IP: 93.22.39.148 Subject: Re: [PATCH 12/18] ACPI: use semicolons rather than commas to separate statements To: Julia Lawall , "Rafael J. Wysocki" Cc: =?UTF-8?Q?Valdis_Kl=c4=93tnieks?= , Joe Perches , Thomas Gleixner , kernel-janitors@vger.kernel.org, Len Brown , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org References: <1601233948-11629-1-git-send-email-Julia.Lawall@inria.fr> <1601233948-11629-13-git-send-email-Julia.Lawall@inria.fr> From: Christophe JAILLET Message-ID: <446ee567-ecc1-fcc9-2691-d4160fdf2150@wanadoo.fr> Date: Sun, 27 Sep 2020 22:27:41 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <1601233948-11629-13-git-send-email-Julia.Lawall@inria.fr> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: fr Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org Le 27/09/2020 à 21:12, Julia Lawall a écrit : > Replace commas with semicolons. What is done is essentially described by > the following Coccinelle semantic patch (http://coccinelle.lip6.fr/): > > // > @@ expression e1,e2; @@ > e1 > -, > +; > e2 > ... when any > // > > Signed-off-by: Julia Lawall > > --- > drivers/acpi/processor_idle.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/acpi/processor_idle.c b/drivers/acpi/processor_idle.c > index f66236cff69b..85502143f506 100644 > --- a/drivers/acpi/processor_idle.c > +++ b/drivers/acpi/processor_idle.c > @@ -1077,7 +1077,9 @@ static int acpi_processor_get_lpi_info(struct acpi_processor *pr) > /* flatten all the LPI states in this level of hierarchy */ > flatten_lpi_states(pr, curr, prev); > > - tmp = prev, prev = curr, curr = tmp; > + tmp = prev; > + prev = curr; > + curr = tmp; > > status = acpi_get_parent(handle, &pr_ahandle); > } > > swap(prev, curr)? CJ