From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0EDAAC31E40 for ; Tue, 6 Aug 2019 16:53:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D29D42075B for ; Tue, 6 Aug 2019 16:53:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YDWulAFE" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732048AbfHFQxw (ORCPT ); Tue, 6 Aug 2019 12:53:52 -0400 Received: from mail-wr1-f66.google.com ([209.85.221.66]:34285 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728927AbfHFQxw (ORCPT ); Tue, 6 Aug 2019 12:53:52 -0400 Received: by mail-wr1-f66.google.com with SMTP id 31so88635084wrm.1; Tue, 06 Aug 2019 09:53:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=gxNkkJD3b/WJ2BCN1yM/UBEgODs/xbGIxyPlrinnovU=; b=YDWulAFE5M1Cj2s64V8j8s4cLZ1QNjqZ5aD10HE/qncnQNsNiWNP1srKy9Z936zPzZ GfLtuLfTfrrKO3l7ixtUHK6aIHkRVgaik5+aOyFeBIxlxV7xPMyeKBLP45ubBVWxqsvG wv/eUSKpDGVhO/g1WIJNOS0+R9Wfm8cnW8QIO5tIdAWAE7WTYI7POS3z35s1jXLnCod4 CWXJQqx3mhYa908hr5zPh9VqNo/osxl0WXgr26ayPgSZw6kCEbUbyRkHjfamOz2yZxLr yYLSsxfbZ8JDyt/lxippVAe3faaTsN4WpYs1vq6t0UsM2gnR9HGI8OGgrzC6l8M2QSke UBOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=gxNkkJD3b/WJ2BCN1yM/UBEgODs/xbGIxyPlrinnovU=; b=QdON+hfanZRqD8cCT+topmyEO3sUEoaRjRnbCJzwxR7wzyRKdss6V4z/oGqbcYIJuj yEAaQiUcSup0dOdcD9704qezWV+sWG1649aB0XfFkQQJR04fHe/YGNfYFqsFg8i0ZOfn E7m3K+9bmLrM6UFrpV53BF3uGz9DFUIKFAUGrwC7iCjQbypQLGew8GOwizn2+GhNsm/J cxaYwQfOU0PC0Sq6CiBr7fimv4dj1maER6Z2UMwo7zjXBU2FJLcJZzN4gGa9IqGb50gr 7+4FW0NFPgS4au0CWlzRToaxcQhXO5aRkb/kCss2WZ0RUdgZXmmDnGd2yFpHBmEeq7PW FVPw== X-Gm-Message-State: APjAAAUkO6rERWhiSm/BEasrlWqr0J7WYWt6A4e5dn83yDbPHg6cB6uQ MwfZoOfZmUvpESFBrb9ez0bB0zkX X-Google-Smtp-Source: APXvYqwkEM8/7FtU/qIz2EzqolfwDqNOFGtE+29zXZgsxLDAnchWnPtpfHMtQFGIzAti+86XMVHClQ== X-Received: by 2002:adf:ec49:: with SMTP id w9mr5292515wrn.303.1565110429245; Tue, 06 Aug 2019 09:53:49 -0700 (PDT) Received: from [172.30.90.245] (sjewanfw1-nat.mentorg.com. [139.181.7.34]) by smtp.gmail.com with ESMTPSA id l15sm2581667wrq.64.2019.08.06.09.53.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Aug 2019 09:53:48 -0700 (PDT) Subject: Re: [PATCH 04/22] media: Move v4l2_fwnode_parse_link from v4l2 to driver base To: Andy Shevchenko Cc: Linux Media Mailing List , Greg Kroah-Hartman , "Rafael J. Wysocki" , Hyun Kwon , Laurent Pinchart , Mauro Carvalho Chehab , Michal Simek , Philipp Zabel , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Len Brown , Sakari Ailus , Jacopo Mondi , Hans Verkuil , Heikki Krogerus , Andy Shevchenko , Enrico Weigelt , Thomas Gleixner , open list , "moderated list:ARM/ZYNQ ARCHITECTURE" , "open list:STAGING SUBSYSTEM" , "open list:ACPI" References: <20190805233505.21167-1-slongerbeam@gmail.com> <20190805233505.21167-5-slongerbeam@gmail.com> From: Steve Longerbeam Message-ID: <4750b347-b421-6569-600f-0ced8406460e@gmail.com> Date: Tue, 6 Aug 2019 09:53:41 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org Hi Andy, On 8/5/19 11:41 PM, Andy Shevchenko wrote: > On Tue, Aug 6, 2019 at 2:37 AM Steve Longerbeam wrote: >> There is nothing v4l2-specific about v4l2_fwnode_{parse|put}_link(). >> Make these functions more generally available by moving them to driver >> base, with the appropriate name changes to the functions and struct. >> >> In the process embed a 'struct fwnode_endpoint' in 'struct fwnode_link' >> for both sides of the link, and make use of fwnode_graph_parse_endpoint() >> to fully parse both endpoints. Rename members local_node and >> remote_node to more descriptive local_port_parent and >> remote_port_parent. >> > May I ask if it's going to be used outside of v4l2? It could be, I can see fwnode_graph_parse_link() being useful in DRM, for example. But at this, only media core and v4l2 are making use of it. This patch was created so that fwnode links can be parsed in a new media core function that forms media links from fwnode links. The full patchset doesn't seem to be up yet, but see [1] for the cover letter. Steve [1] https://www.mail-archive.com/linux-media@vger.kernel.org/msg148910.html