From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4745C10F14 for ; Thu, 10 Oct 2019 22:20:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AEAC1206B6 for ; Thu, 10 Oct 2019 22:20:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726065AbfJJWUe (ORCPT ); Thu, 10 Oct 2019 18:20:34 -0400 Received: from cloudserver094114.home.pl ([79.96.170.134]:65011 "EHLO cloudserver094114.home.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725959AbfJJWUe (ORCPT ); Thu, 10 Oct 2019 18:20:34 -0400 Received: from 79.184.255.36.ipv4.supernova.orange.pl (79.184.255.36) (HELO kreacher.localnet) by serwer1319399.home.pl (79.96.170.134) with SMTP (IdeaSmtpServer 0.83.292) id 86c559199dc39aa4; Fri, 11 Oct 2019 00:20:31 +0200 From: "Rafael J. Wysocki" To: Daniel Black Cc: Len Brown , "open list:ACPI" , open list Subject: Re: [PATCH] acpi/hmat: ACPI_HMAT_MEMORY_PD_VALID is deprecated in ACPI-6.3 Date: Fri, 11 Oct 2019 00:20:31 +0200 Message-ID: <5172949.9bKdBNxvUS@kreacher> In-Reply-To: <20190806042440.16445-1-daniel@linux.ibm.com> References: <20190806042440.16445-1-daniel@linux.ibm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Tuesday, August 6, 2019 6:24:39 AM CEST Daniel Black wrote: > ACPI-6.3 corresponds to when hmat revision was bumped from > 1 to 2. In this version ACPI_HMAT_MEMORY_PD_VALID was > deprecated and made reserved. > > As such in revision 2+ we shouldn't be testing this flag. > > This is as per ACPI-6.3, 5.2.27.3, Table 5-145 > "Memory Proximity Domain Attributes Structure" > for Flags. > > Signed-off-by: Daniel Black > --- > drivers/acpi/hmat/hmat.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/acpi/hmat/hmat.c b/drivers/acpi/hmat/hmat.c > index 96b7d39a97c6..e938e34673d9 100644 > --- a/drivers/acpi/hmat/hmat.c > +++ b/drivers/acpi/hmat/hmat.c > @@ -382,7 +382,7 @@ static int __init hmat_parse_proximity_domain(union acpi_subtable_headers *heade > pr_info("HMAT: Memory Flags:%04x Processor Domain:%d Memory Domain:%d\n", > p->flags, p->processor_PD, p->memory_PD); > > - if (p->flags & ACPI_HMAT_MEMORY_PD_VALID) { > + if (p->flags & ACPI_HMAT_MEMORY_PD_VALID && hmat_revision == 1) { > target = find_mem_target(p->memory_PD); > if (!target) { > pr_debug("HMAT: Memory Domain missing from SRAT\n"); > Applied as a fix for 5.4, thanks!