linux-acpi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Anchal Agarwal <anchalag@amazon.com>
Cc: Balbir Singh <sblbir@amazon.com>,
	Frank van der Linden <fllinden@amazon.com>,
	Linux ACPI <linux-acpi@vger.kernel.org>,
	Erik Kaneda <erik.kaneda@intel.com>
Subject: Re: [PATCH] ACPICA: Enable sleep button on ACPI legacy wake
Date: Thu, 12 Dec 2019 23:10:32 +0100	[thread overview]
Message-ID: <5749186.Fh4Yg0zt7g@kreacher> (raw)
In-Reply-To: <20191101212319.1FFC440EB1@dev-dsk-anchalag-2a-9c2d1d96.us-west-2.amazon.com>

On Monday, October 29, 2018 6:52:16 PM CET Anchal Agarwal wrote:
> Currently we do not see sleep_enable bit set after guest resumes
> from hibernation. Hibernation is triggered in guest on receiving
> a sleep trigger from the hypervisor(S4 state). We see that power
> button is enabled on wake up from S4 state however sleep button
> isn't.

I'm not against this change in principle, although it may change behavior
in a somewhat unexpected way on some systems.

> This causes subsequent invocation of sleep state to fail
> in the guest.

However, can you explain this in a bit more detail?
 
> Signed-off-by: Anchal Agarwal <anchalag@amazon.com>
> Reviewed-by: Balbir Singh <sblbir@amazon.com>
> Reviewed-by: Frank van der Linden <fllinden@amazon.com>
> ---
>  drivers/acpi/acpica/hwsleep.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/drivers/acpi/acpica/hwsleep.c b/drivers/acpi/acpica/hwsleep.c
> index b62db8ec446f..a176c7802760 100644
> --- a/drivers/acpi/acpica/hwsleep.c
> +++ b/drivers/acpi/acpica/hwsleep.c
> @@ -300,6 +300,17 @@ acpi_status acpi_hw_legacy_wake(u8 sleep_state)
>  				    [ACPI_EVENT_POWER_BUTTON].
>  				    status_register_id, ACPI_CLEAR_STATUS);
>  
> +	/* Enable sleep button */
> +	(void)
> +	      acpi_write_bit_register(acpi_gbl_fixed_event_info
> +				      [ACPI_EVENT_SLEEP_BUTTON].
> +				      enable_register_id, ACPI_ENABLE_EVENT);
> +
> +	(void)
> +	      acpi_write_bit_register(acpi_gbl_fixed_event_info
> +				      [ACPI_EVENT_SLEEP_BUTTON].
> +				      status_register_id, ACPI_CLEAR_STATUS);
> +
>  	acpi_hw_execute_sleep_method(METHOD_PATHNAME__SST, ACPI_SST_WORKING);
>  	return_ACPI_STATUS(status);
>  }
> 





  parent reply	other threads:[~2019-12-12 22:10 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20191101212319.1FFC440EB1@dev-dsk-anchalag-2a-9c2d1d96.us-west-2.amazon.com>
     [not found] ` <CF6A88132359CE47947DB4C6E1709ED53C66675F@ORSMSX122.amr.corp.intel.com>
2019-11-01 22:26   ` [PATCH] ACPICA: Enable sleep button on ACPI legacy wake Agarwal, Anchal
2019-11-04 17:58     ` Agarwal, Anchal
2019-11-08 17:56       ` Anchal Agarwal
2019-12-12 22:10 ` Rafael J. Wysocki [this message]
2020-01-02 22:39   ` Anchal Agarwal
2020-01-15 10:24     ` Rafael J. Wysocki
2020-01-15 18:58       ` Anchal Agarwal
2020-01-15 22:57         ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5749186.Fh4Yg0zt7g@kreacher \
    --to=rjw@rjwysocki.net \
    --cc=anchalag@amazon.com \
    --cc=erik.kaneda@intel.com \
    --cc=fllinden@amazon.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=sblbir@amazon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).