Linux-ACPI Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH 0/2] ACPI: EC: PM: Two fixes related to suspend-to-idle
@ 2020-10-05 17:10 Rafael J. Wysocki
  2020-10-05 17:13 ` [PATCH 1/2] ACPI: EC: PM: Flush EC work unconditionally after wakeup Rafael J. Wysocki
  2020-10-05 17:13 ` [PATCH 2/2] ACPI: EC: PM: Drop ec_no_wakeup check from acpi_ec_dispatch_gpe() Rafael J. Wysocki
  0 siblings, 2 replies; 3+ messages in thread
From: Rafael J. Wysocki @ 2020-10-05 17:10 UTC (permalink / raw)
  To: Linux ACPI; +Cc: Linux PM, LKML

Hi All,

The following two patches address two suspend-to-idle-related issues in the
ACPI EC driver.

Please refer to the patch changelogs for details.

Thanks!




^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH 1/2] ACPI: EC: PM: Flush EC work unconditionally after wakeup
  2020-10-05 17:10 [PATCH 0/2] ACPI: EC: PM: Two fixes related to suspend-to-idle Rafael J. Wysocki
@ 2020-10-05 17:13 ` Rafael J. Wysocki
  2020-10-05 17:13 ` [PATCH 2/2] ACPI: EC: PM: Drop ec_no_wakeup check from acpi_ec_dispatch_gpe() Rafael J. Wysocki
  1 sibling, 0 replies; 3+ messages in thread
From: Rafael J. Wysocki @ 2020-10-05 17:13 UTC (permalink / raw)
  To: Linux ACPI; +Cc: Linux PM, LKML, Raymond Tan

From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Subject: [PATCH] ACPI: EC: PM: Flush EC work unconditionally after wakeup

Commit 607b9df63057 ("ACPI: EC: PM: Avoid flushing EC work when EC
GPE is inactive") has been reported to cause some power button wakeup
events to be missed on some systems, so modify acpi_ec_dispatch_gpe()
to call acpi_ec_flush_work() unconditionally to effectively reverse
the changes made by that commit.

Also note that the problem which prompted commit 607b9df63057 is not
reproducible any more on the affected machine.

Fixes: 607b9df63057 ("ACPI: EC: PM: Avoid flushing EC work when EC GPE is inactive")
Cc: 5.4+ <stable@vger.kernel.org> # 5.4+
Reported-by: Raymond Tan <raymond.tan@intel.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
 drivers/acpi/ec.c |    7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

Index: linux-pm/drivers/acpi/ec.c
===================================================================
--- linux-pm.orig/drivers/acpi/ec.c
+++ linux-pm/drivers/acpi/ec.c
@@ -2019,12 +2019,11 @@ bool acpi_ec_dispatch_gpe(void)
 	 * to allow the caller to process events properly after that.
 	 */
 	ret = acpi_dispatch_gpe(NULL, first_ec->gpe);
-	if (ret == ACPI_INTERRUPT_HANDLED) {
+	if (ret == ACPI_INTERRUPT_HANDLED)
 		pm_pr_dbg("ACPI EC GPE dispatched\n");
 
-		/* Flush the event and query workqueues. */
-		acpi_ec_flush_work();
-	}
+	/* Flush the event and query workqueues. */
+	acpi_ec_flush_work();
 
 	return false;
 }




^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH 2/2] ACPI: EC: PM: Drop ec_no_wakeup check from acpi_ec_dispatch_gpe()
  2020-10-05 17:10 [PATCH 0/2] ACPI: EC: PM: Two fixes related to suspend-to-idle Rafael J. Wysocki
  2020-10-05 17:13 ` [PATCH 1/2] ACPI: EC: PM: Flush EC work unconditionally after wakeup Rafael J. Wysocki
@ 2020-10-05 17:13 ` Rafael J. Wysocki
  1 sibling, 0 replies; 3+ messages in thread
From: Rafael J. Wysocki @ 2020-10-05 17:13 UTC (permalink / raw)
  To: Linux ACPI; +Cc: Linux PM, LKML, Todd Brandt

From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

It turns out that in some cases there are EC events to flush in
acpi_ec_dispatch_gpe() even though the ec_no_wakeup kernel parameter
is set and the EC GPE is disabled while sleeping, so drop the
ec_no_wakeup check that prevents those events from being processed
from acpi_ec_dispatch_gpe().

Reported-by: Todd Brandt <todd.e.brandt@linux.intel.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
 drivers/acpi/ec.c |    3 ---
 1 file changed, 3 deletions(-)

Index: linux-pm/drivers/acpi/ec.c
===================================================================
--- linux-pm.orig/drivers/acpi/ec.c
+++ linux-pm/drivers/acpi/ec.c
@@ -2011,9 +2011,6 @@ bool acpi_ec_dispatch_gpe(void)
 	if (acpi_any_gpe_status_set(first_ec->gpe))
 		return true;
 
-	if (ec_no_wakeup)
-		return false;
-
 	/*
 	 * Dispatch the EC GPE in-band, but do not report wakeup in any case
 	 * to allow the caller to process events properly after that.




^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-05 17:10 [PATCH 0/2] ACPI: EC: PM: Two fixes related to suspend-to-idle Rafael J. Wysocki
2020-10-05 17:13 ` [PATCH 1/2] ACPI: EC: PM: Flush EC work unconditionally after wakeup Rafael J. Wysocki
2020-10-05 17:13 ` [PATCH 2/2] ACPI: EC: PM: Drop ec_no_wakeup check from acpi_ec_dispatch_gpe() Rafael J. Wysocki

Linux-ACPI Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-acpi/0 linux-acpi/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-acpi linux-acpi/ https://lore.kernel.org/linux-acpi \
		linux-acpi@vger.kernel.org
	public-inbox-index linux-acpi

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-acpi


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git