From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0339EC433E2 for ; Mon, 18 May 2020 12:24:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D7A30206D4 for ; Mon, 18 May 2020 12:24:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="DOmeAOjq" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727033AbgERMYS (ORCPT ); Mon, 18 May 2020 08:24:18 -0400 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:37240 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726997AbgERMYQ (ORCPT ); Mon, 18 May 2020 08:24:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1589804655; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aNddrvnjvVAzGmBCFtMQ5iaiY8jsBoqXulJlnAFXCC4=; b=DOmeAOjqSMdffptC4r3ZaZiNZlgt9unz9FjAaT0eIKl6dJxXq5iEYgyuwfvxi1r9spl8NA jMwSmhD7LwAZrDs4VaMXB8qw2SLN9QjHj3309EDlTImRr82C+4EXAXoysHBpeqCWQi/YAV YRvF4dDi6k4I+O6iHQTjwn/F4vVdmu4= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-386-8lQQTlxhMd6AXCKGY6nKrw-1; Mon, 18 May 2020 08:24:08 -0400 X-MC-Unique: 8lQQTlxhMd6AXCKGY6nKrw-1 Received: by mail-wm1-f69.google.com with SMTP id x11so3013184wmc.9 for ; Mon, 18 May 2020 05:24:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=aNddrvnjvVAzGmBCFtMQ5iaiY8jsBoqXulJlnAFXCC4=; b=j0wRVR+PQtyK1mwCSXT9NkGBb+UP/IQgr8pKpXEd+6UbN9JxQ3VduGe0kxLIyrAYAQ i/qXs+7xUGGf9Bqb8bHQtpRKvwbO9+cI1jjBZDkHHdsCD+4l5qSVhjxpVGfwu/RDfOtJ gukTxymmUJPP5fMb5Od6Fo/sIlJzVytkcUknYlDMqJgOOPh7ZRkIA9dxoeOOxq8YXkti lCE2wYqnp/Okp/y/kAmu6RI0mUVdYdtVqpvtoLIUdMIWPjWxUrXMVqrzXp/TsuXZERiY mqY/wwMEQ6lTszw79NeeUVWVHfEv8MdogOx71IvKt8U8T0i/RgDuGDX/HDyxY2HImnQP q74Q== X-Gm-Message-State: AOAM531LZjDWsv34VsK0PKRn+JoOAveKjDTMeiffxDpuKj4Wh3Sf8SkD p67DrMWy9QFmVkEpHDEhRsODjlRP/ktCgaxNp4ykulrHN9+DIsBOj7/r2HhVZ60iSHX7MjFppfK Y11t0IWwtWeC0BQi/7nzWDg== X-Received: by 2002:adf:eac8:: with SMTP id o8mr19377378wrn.268.1589804647178; Mon, 18 May 2020 05:24:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwLe3p91ExNY6QGf1SRfv5g2doyaKilcFhk73/bWJl/jln6ZVFltTOdpBm/OQccJvw+caL9KA== X-Received: by 2002:adf:eac8:: with SMTP id o8mr19377325wrn.268.1589804646888; Mon, 18 May 2020 05:24:06 -0700 (PDT) Received: from x1.localdomain (2001-1c00-0c0c-fe00-d2ea-f29d-118b-24dc.cable.dynamic.v6.ziggo.nl. [2001:1c00:c0c:fe00:d2ea:f29d:118b:24dc]) by smtp.gmail.com with ESMTPSA id 18sm15993570wmj.19.2020.05.18.05.24.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 May 2020 05:24:06 -0700 (PDT) Subject: Re: [PATCHv2 0/7] Support inhibiting input devices To: Andrzej Pietrasiewicz , linux-input@vger.kernel.org, linux-acpi@vger.kernel.org, linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-tegra@vger.kernel.org, patches@opensource.cirrus.com, ibm-acpi-devel@lists.sourceforge.net, platform-driver-x86@vger.kernel.org Cc: "Rafael J . Wysocki" , Len Brown , Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Kukjin Kim , Krzysztof Kozlowski , Dmitry Torokhov , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Vladimir Zapolskiy , Sylvain Lemieux , Laxman Dewangan , Thierry Reding , Jonathan Hunter , Barry Song , Michael Hennerich , Nick Dyer , Ferruh Yigit , Sangwon Jee , Henrique de Moraes Holschuh , kernel@collabora.com, Peter Hutterer , Benjamin Tissoires References: <20200506002746.GB89269@dtor-ws> <20200515164943.28480-1-andrzej.p@collabora.com> <842b95bb-8391-5806-fe65-be64b02de122@redhat.com> From: Hans de Goede Message-ID: <6d9921fc-5c2f-beda-4dcd-66d6970a22fe@redhat.com> Date: Mon, 18 May 2020 14:24:05 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org Hi, On 5/18/20 12:48 PM, Andrzej Pietrasiewicz wrote: > Hi Hans, > > W dniu 15.05.2020 o 20:19, Hans de Goede pisze: >> Hi Andrezj, >> >> On 5/15/20 6:49 PM, Andrzej Pietrasiewicz wrote: >>> Userspace might want to implement a policy to temporarily disregard input >>> from certain devices, including not treating them as wakeup sources. >>> >>> An example use case is a laptop, whose keyboard can be folded under the >>> screen to create tablet-like experience. The user then must hold the laptop >>> in such a way that it is difficult to avoid pressing the keyboard keys. It >>> is therefore desirable to temporarily disregard input from the keyboard, >>> until it is folded back. This obviously is a policy which should be kept >>> out of the kernel, but the kernel must provide suitable means to implement >>> such a policy. >> >> Actually libinput already binds together (inside libinput) SW_TABLET_MODE >> generating evdev nodes and e.g. internal keyboards on devices with 360° >> hinges for this reason. libinput simply closes the /dev/input/event# >> node when folded and re-opens it when the keyboard should become active >> again. Thus not only suppresses events but allows e.g. touchpads to >> enter runtime suspend mode which saves power. Typically closing the >> /dev/input/event# node will also disable the device as wakeup source. >> >> So I wonder what this series actually adds for functionality for >> userspace which can not already be achieved this way? >> >> I also noticed that you keep the device open (do not call the >> input_device's close callback) when inhibited and just throw away > > I'm not sure if I understand you correctly, it is called: > > +static inline void input_stop(struct input_dev *dev) > +{ > +    if (dev->poller) > +        input_dev_poller_stop(dev->poller); > +    if (dev->close) > +        dev->close(dev); >                 ^^^^^^^^^^^^^^^^ > +static int input_inhibit(struct input_dev *dev) > +{ > +    int ret = 0; > + > +    mutex_lock(&dev->mutex); > + > +    if (dev->inhibited) > +        goto out; > + > +    if (dev->users) { > +        if (dev->inhibit) { > +            ret = dev->inhibit(dev); > +            if (ret) > +                goto out; > +        } > +        input_stop(dev); >                 ^^^^^^^^^^^^^^^^ > > It will not be called when dev->users is zero, but if it is zero, > then nobody has opened the device yet so there is nothing to close. Ah, I missed that. So if the device implements the inhibit call back then on inhibit it will get both the inhibit and close callback called? And what happens if the last user goes away and the device is not inhibited? I'm trying to understand here what the difference between the 2 is / what the goal of having a separate inhibit callback ? IOW is there something which we want to do on close when the close is being done to inhibit the device, which we do not want to do on a normal close ? Regards, Hans