Linux-ACPI Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] tools/power/acpi: exclude tools/* from .gitignore pattern
@ 2019-04-29 14:45 Masahiro Yamada
  2019-04-29 14:45 ` Masahiro Yamada
  2019-05-31  9:23 ` Rafael J. Wysocki
  0 siblings, 2 replies; 3+ messages in thread
From: Masahiro Yamada @ 2019-04-29 14:45 UTC (permalink / raw)
  To: Rafael J . Wysocki, Len Brown, linux-acpi
  Cc: Masahiro Yamada, Robert Moore, linux-kernel, Erik Schmauss, devel

tools/power/acpi/.gitignore has the following entries:

  acpidbg
  acpidump
  ec

They are intended to ignore the following build artifacts:

  tools/power/acpi/acpidbg
  tools/power/acpi/acpidump
  tools/power/acpi/ec

However, those .gitignore entries are effective not only for the
current directory, but also for any sub-directories.

So, the following directories are also considered to be ignored:

  tools/power/acpi/tools/acpidbg
  tools/power/acpi/tools/acpidump
  tools/power/acpi/tools/ec

They are obviously version-controlled, so should be excluded from the
.gitignore patterns.

You can fix it by prefixing the patterns with '/', which means they
are only effective in the current directory.

I also prefixed the "include" consistently. IMHO, '/' prefixing is
safer when you intend to ignore specific files or directories.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---

 tools/power/acpi/.gitignore | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/tools/power/acpi/.gitignore b/tools/power/acpi/.gitignore
index cba3d99..f698a0e 100644
--- a/tools/power/acpi/.gitignore
+++ b/tools/power/acpi/.gitignore
@@ -1,4 +1,4 @@
-acpidbg
-acpidump
-ec
-include
+/acpidbg
+/acpidump
+/ec
+/include/
-- 
2.7.4

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] tools/power/acpi: exclude tools/* from .gitignore pattern
  2019-04-29 14:45 [PATCH] tools/power/acpi: exclude tools/* from .gitignore pattern Masahiro Yamada
@ 2019-04-29 14:45 ` Masahiro Yamada
  2019-05-31  9:23 ` Rafael J. Wysocki
  1 sibling, 0 replies; 3+ messages in thread
From: Masahiro Yamada @ 2019-04-29 14:45 UTC (permalink / raw)
  To: Rafael J . Wysocki, Len Brown, linux-acpi
  Cc: Masahiro Yamada, Robert Moore, linux-kernel, Erik Schmauss, devel

tools/power/acpi/.gitignore has the following entries:

  acpidbg
  acpidump
  ec

They are intended to ignore the following build artifacts:

  tools/power/acpi/acpidbg
  tools/power/acpi/acpidump
  tools/power/acpi/ec

However, those .gitignore entries are effective not only for the
current directory, but also for any sub-directories.

So, the following directories are also considered to be ignored:

  tools/power/acpi/tools/acpidbg
  tools/power/acpi/tools/acpidump
  tools/power/acpi/tools/ec

They are obviously version-controlled, so should be excluded from the
.gitignore patterns.

You can fix it by prefixing the patterns with '/', which means they
are only effective in the current directory.

I also prefixed the "include" consistently. IMHO, '/' prefixing is
safer when you intend to ignore specific files or directories.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---

 tools/power/acpi/.gitignore | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/tools/power/acpi/.gitignore b/tools/power/acpi/.gitignore
index cba3d99..f698a0e 100644
--- a/tools/power/acpi/.gitignore
+++ b/tools/power/acpi/.gitignore
@@ -1,4 +1,4 @@
-acpidbg
-acpidump
-ec
-include
+/acpidbg
+/acpidump
+/ec
+/include/
-- 
2.7.4


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] tools/power/acpi: exclude tools/* from .gitignore pattern
  2019-04-29 14:45 [PATCH] tools/power/acpi: exclude tools/* from .gitignore pattern Masahiro Yamada
  2019-04-29 14:45 ` Masahiro Yamada
@ 2019-05-31  9:23 ` Rafael J. Wysocki
  1 sibling, 0 replies; 3+ messages in thread
From: Rafael J. Wysocki @ 2019-05-31  9:23 UTC (permalink / raw)
  To: Masahiro Yamada
  Cc: Len Brown, linux-acpi, Robert Moore, linux-kernel, Erik Schmauss, devel

On Monday, April 29, 2019 4:45:06 PM CEST Masahiro Yamada wrote:
> tools/power/acpi/.gitignore has the following entries:
> 
>   acpidbg
>   acpidump
>   ec
> 
> They are intended to ignore the following build artifacts:
> 
>   tools/power/acpi/acpidbg
>   tools/power/acpi/acpidump
>   tools/power/acpi/ec
> 
> However, those .gitignore entries are effective not only for the
> current directory, but also for any sub-directories.
> 
> So, the following directories are also considered to be ignored:
> 
>   tools/power/acpi/tools/acpidbg
>   tools/power/acpi/tools/acpidump
>   tools/power/acpi/tools/ec
> 
> They are obviously version-controlled, so should be excluded from the
> .gitignore patterns.
> 
> You can fix it by prefixing the patterns with '/', which means they
> are only effective in the current directory.
> 
> I also prefixed the "include" consistently. IMHO, '/' prefixing is
> safer when you intend to ignore specific files or directories.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
> 
>  tools/power/acpi/.gitignore | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/tools/power/acpi/.gitignore b/tools/power/acpi/.gitignore
> index cba3d99..f698a0e 100644
> --- a/tools/power/acpi/.gitignore
> +++ b/tools/power/acpi/.gitignore
> @@ -1,4 +1,4 @@
> -acpidbg
> -acpidump
> -ec
> -include
> +/acpidbg
> +/acpidump
> +/ec
> +/include/
> 

Applied, thanks!





^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-29 14:45 [PATCH] tools/power/acpi: exclude tools/* from .gitignore pattern Masahiro Yamada
2019-04-29 14:45 ` Masahiro Yamada
2019-05-31  9:23 ` Rafael J. Wysocki

Linux-ACPI Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-acpi/0 linux-acpi/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-acpi linux-acpi/ https://lore.kernel.org/linux-acpi \
		linux-acpi@vger.kernel.org linux-acpi@archiver.kernel.org
	public-inbox-index linux-acpi


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-acpi


AGPL code for this site: git clone https://public-inbox.org/ public-inbox