From: Ferry Toth <fntoth@gmail.com> To: linux-acpi@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: linux-acpi@vger.kernel.org Subject: Re: [PATCH] ACPICA: make acpi_load_table() return table index Date: Fri, 13 Sep 2019 18:48:28 +0200 [thread overview] Message-ID: <7625fe37-1710-056d-fb9e-39c33fd962a1@gmail.com> (raw) In-Reply-To: <20190913151228.GT2680@smile.fi.intel.com> Hello all, Sorry to have sent our message with cancelled e-mail address. I have correct this now. Op 13-09-19 om 17:12 schreef Shevchenko, Andriy: > On Fri, Sep 13, 2019 at 05:20:21PM +0300, Moore, Robert wrote: >> -----Original Message----- >> From: Nikolaus Voss [mailto:nv@vosn.de] >> Sent: Friday, September 13, 2019 12:44 AM >> To: Moore, Robert <robert.moore@intel.com> >> Cc: Shevchenko, Andriy <andriy.shevchenko@intel.com>; Schmauss, Erik <erik.schmauss@intel.com>; Rafael J. Wysocki <rjw@rjwysocki.net>; Len Brown <lenb@kernel.org>; Jacek Anaszewski <jacek.anaszewski@gmail.com>; Pavel Machek <pavel@ucw.cz>; Dan Murphy <dmurphy@ti.com>; linux-acpi@vger.kernel.org; devel@acpica.org; linux-kernel@vger.kernel.org; Ferry Toth <ftoth@telfort.nl>; nikolaus.voss@loewensteinmedical.de >> Subject: RE: [PATCH] ACPICA: make acpi_load_table() return table index >> >> Bob, >> >> On Thu, 12 Sep 2019, Moore, Robert wrote: >>> The ability to unload an ACPI table (especially AML tables such as >>> SSDTs) is in the process of being deprecated in ACPICA -- since it is >>> also deprecated in the current ACPI specification. This is being done >>> because of the difficulty of deleting the namespace entries for the >>> table. FYI, Windows does not properly support this function either. >> >> ok, I see it can be a problem to unload an AML table with all it's consequences e.g. with respect to driver unregistering in setups with complex dependencies. It will only work properly under certain conditions >> - nevertheless acpi_tb_unload_table() is still exported in ACPICA and we should get this working as it worked before. >> >> AcpiTbUnloadTable is not exported, it is an internal interface only -- as >> recognized by the "AcpiTb". > > In Linux it became a part of ABI when the > > commit 772bf1e2878ecfca0d1f332071c83e021dd9cf01 > Author: Jan Kiszka <jan.kiszka@siemens.com> > Date: Fri Jun 9 20:36:31 2017 +0200 > > ACPI: configfs: Unload SSDT on configfs entry removal > > appeared in the kernel. And the commit message explains quite well why it is an important feature: "This allows to change SSDTs without rebooting the system. It also allows to destroy devices again that a dynamically loaded SSDT created. This is widely similar to the DT overlay behavior." >> I'm not sure that I want to change the interface >> to AcpiLoadTable just for something that is being deprecated. Already, we >> throw an ACPI_EXCEPTION if the Unload operator is encountered in the AML byte >> stream. The same thing with AcpiUnloadParentTable - it is being deprecated. >> >> ACPI_EXCEPTION ((AE_INFO, AE_NOT_IMPLEMENTED, >> "AML Unload operator is not supported")); >
WARNING: multiple messages have this Message-ID (diff)
From: Ferry Toth <fntoth@gmail.com> To: "Shevchenko, Andriy" <andriy.shevchenko@intel.com>, "Moore, Robert" <robert.moore@intel.com> Cc: Nikolaus Voss <nv@vosn.de>, "Schmauss, Erik" <erik.schmauss@intel.com>, "Rafael J. Wysocki" <rjw@rjwysocki.net>, Len Brown <lenb@kernel.org>, Jacek Anaszewski <jacek.anaszewski@gmail.com>, Pavel Machek <pavel@ucw.cz>, Dan Murphy <dmurphy@ti.com>, "linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>, "devel@acpica.org" <devel@acpica.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "nikolaus.voss@loewensteinmedical.de" <nikolaus.voss@loewensteinmedical.de>, Jan Kiszka <jan.kiszka@siemens.com> Subject: Re: [PATCH] ACPICA: make acpi_load_table() return table index Date: Fri, 13 Sep 2019 18:48:28 +0200 [thread overview] Message-ID: <7625fe37-1710-056d-fb9e-39c33fd962a1@gmail.com> (raw) Message-ID: <20190913164828.vIv6oVvATdWPyJew4RVM7O2NrIslsawg4E-9jn89lFE@z> (raw) In-Reply-To: <20190913151228.GT2680@smile.fi.intel.com> Hello all, Sorry to have sent our message with cancelled e-mail address. I have correct this now. Op 13-09-19 om 17:12 schreef Shevchenko, Andriy: > On Fri, Sep 13, 2019 at 05:20:21PM +0300, Moore, Robert wrote: >> -----Original Message----- >> From: Nikolaus Voss [mailto:nv@vosn.de] >> Sent: Friday, September 13, 2019 12:44 AM >> To: Moore, Robert <robert.moore@intel.com> >> Cc: Shevchenko, Andriy <andriy.shevchenko@intel.com>; Schmauss, Erik <erik.schmauss@intel.com>; Rafael J. Wysocki <rjw@rjwysocki.net>; Len Brown <lenb@kernel.org>; Jacek Anaszewski <jacek.anaszewski@gmail.com>; Pavel Machek <pavel@ucw.cz>; Dan Murphy <dmurphy@ti.com>; linux-acpi@vger.kernel.org; devel@acpica.org; linux-kernel@vger.kernel.org; Ferry Toth <ftoth@telfort.nl>; nikolaus.voss@loewensteinmedical.de >> Subject: RE: [PATCH] ACPICA: make acpi_load_table() return table index >> >> Bob, >> >> On Thu, 12 Sep 2019, Moore, Robert wrote: >>> The ability to unload an ACPI table (especially AML tables such as >>> SSDTs) is in the process of being deprecated in ACPICA -- since it is >>> also deprecated in the current ACPI specification. This is being done >>> because of the difficulty of deleting the namespace entries for the >>> table. FYI, Windows does not properly support this function either. >> >> ok, I see it can be a problem to unload an AML table with all it's consequences e.g. with respect to driver unregistering in setups with complex dependencies. It will only work properly under certain conditions >> - nevertheless acpi_tb_unload_table() is still exported in ACPICA and we should get this working as it worked before. >> >> AcpiTbUnloadTable is not exported, it is an internal interface only -- as >> recognized by the "AcpiTb". > > In Linux it became a part of ABI when the > > commit 772bf1e2878ecfca0d1f332071c83e021dd9cf01 > Author: Jan Kiszka <jan.kiszka@siemens.com> > Date: Fri Jun 9 20:36:31 2017 +0200 > > ACPI: configfs: Unload SSDT on configfs entry removal > > appeared in the kernel. And the commit message explains quite well why it is an important feature: "This allows to change SSDTs without rebooting the system. It also allows to destroy devices again that a dynamically loaded SSDT created. This is widely similar to the DT overlay behavior." >> I'm not sure that I want to change the interface >> to AcpiLoadTable just for something that is being deprecated. Already, we >> throw an ACPI_EXCEPTION if the Unload operator is encountered in the AML byte >> stream. The same thing with AcpiUnloadParentTable - it is being deprecated. >> >> ACPI_EXCEPTION ((AE_INFO, AE_NOT_IMPLEMENTED, >> "AML Unload operator is not supported")); >
next prev parent reply other threads:[~2019-09-13 16:50 UTC|newest] Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-05-29 12:18 [PATCH 0/3] PWM framework: add support referencing PWMs from ACPI Nikolaus Voss 2019-05-29 12:18 ` [PATCH 1/3] ACPI: Resolve objects on host-directed table loads Nikolaus Voss 2019-05-30 14:42 ` Dan Murphy 2019-05-31 12:23 ` Pavel Machek 2019-05-31 12:45 ` Dan Murphy 2019-05-31 12:46 ` Dan Murphy 2019-06-03 9:12 ` Nikolaus Voss 2019-08-14 18:50 ` Andy Shevchenko 2019-08-14 20:27 ` Schmauss, Erik 2019-08-16 11:57 ` Nikolaus Voss 2019-08-30 14:53 ` Shevchenko, Andriy 2019-09-04 7:20 ` Nikolaus Voss 2019-09-06 17:46 ` Shevchenko, Andriy 2019-09-12 8:05 ` Nikolaus Voss 2019-09-12 8:07 ` [PATCH] ACPICA: make acpi_load_table() return table index Nikolaus Voss 2019-09-12 14:19 ` Moore, Robert 2019-09-12 19:36 ` Ferry Toth 2019-09-25 18:13 ` Schmauss, Erik 2019-09-26 8:09 ` Shevchenko, Andriy 2019-09-13 7:44 ` Nikolaus Voss 2019-09-13 14:20 ` Moore, Robert 2019-09-13 15:12 ` Shevchenko, Andriy 2019-09-13 16:48 ` Ferry Toth [this message] 2019-09-13 16:48 ` Ferry Toth 2019-09-13 17:40 ` Moore, Robert 2019-09-13 19:56 ` Rafael J. Wysocki 2019-09-16 9:46 ` Nikolaus Voss 2019-09-18 14:13 ` Moore, Robert 2019-09-18 14:31 ` Nikolaus Voss 2019-09-19 17:05 ` Moore, Robert 2019-09-23 9:05 ` Nikolaus Voss 2019-09-24 19:41 ` Moore, Robert 2019-09-25 10:18 ` Nikolaus Voss 2019-09-25 10:53 ` Shevchenko, Andriy 2019-09-19 8:13 ` Rafael J. Wysocki 2019-09-23 9:08 ` Nikolaus Voss 2019-09-23 9:47 ` [PATCH] ACPICA: Introduce acpi_load_table_with_index() Nikolaus Voss 2019-09-24 12:07 ` Shevchenko, Andriy 2019-09-24 12:08 ` Shevchenko, Andriy 2019-09-25 10:20 ` Nikolaus Voss 2019-09-24 15:11 ` Andy Shevchenko 2019-09-25 10:22 ` Nikolaus Voss 2019-09-26 16:09 ` [PATCH] ACPICA: make acpi_load_table() return table index Schmauss, Erik 2019-09-26 16:35 ` Shevchenko, Andriy 2019-09-26 16:51 ` Schmauss, Erik 2019-09-26 17:47 ` Shevchenko, Andriy 2019-09-26 18:44 ` Nikolaus Voss 2019-09-26 19:26 ` Rafael J. Wysocki 2019-09-26 19:41 ` Schmauss, Erik 2019-09-26 18:43 ` Nikolaus Voss 2019-05-29 12:18 ` [PATCH 2/3] PWM framework: add support referencing PWMs from ACPI Nikolaus Voss 2019-05-30 14:54 ` Dan Murphy 2019-05-31 12:24 ` Pavel Machek 2019-06-03 9:27 ` Nikolaus Voss 2019-05-29 12:18 ` [PATCH 3/3] leds-pwm.c: support ACPI via firmware-node framework Nikolaus Voss 2019-05-30 15:14 ` Dan Murphy 2019-06-03 9:44 ` Nikolaus Voss
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=7625fe37-1710-056d-fb9e-39c33fd962a1@gmail.com \ --to=fntoth@gmail.com \ --cc=linux-acpi@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).