From: Todd Brandt <todd.e.brandt@linux.intel.com>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Mario Limonciello <mario.limonciello@amd.com>,
Mel Gorman <mgorman@techsingularity.net>,
Zhang Rui <rui.zhang@intel.com>,
LKML <linux-kernel@vger.kernel.org>,
Bjorn Helgaas <helgaas@kernel.org>,
Linux ACPI <linux-acpi@vger.kernel.org>,
Linux PM <linux-pm@vger.kernel.org>,
Alessandro Zummo <a.zummo@towertech.it>,
linux-rtc@vger.kernel.org
Subject: Re: [PATCH] rtc: rtc-cmos: Fix wake alarm breakage
Date: Tue, 25 Oct 2022 08:28:39 -0700 [thread overview]
Message-ID: <836b1787426d5b1569f6d77007a4765ee17d5ea6.camel@linux.intel.com> (raw)
In-Reply-To: <166611112152.2353171.9661532286339710942.b4-ty@bootlin.com>
On Tue, 2022-10-18 at 18:38 +0200, Alexandre Belloni wrote:
> On Tue, 18 Oct 2022 18:09:31 +0200, Rafael J. Wysocki wrote:
> > From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> >
> > Commit 4919d3eb2ec0 ("rtc: cmos: Fix event handler registration
> > ordering issue") overlooked the fact that cmos_do_probe() depended
> > on the preparations carried out by cmos_wake_setup() and the wake
> > alarm stopped working after the ordering of them had been changed.
> >
> > [...]
>
> Applied, thanks!
I did testing yesterday on the 6.1.0-rc2 build and this patch hasn't
made it into rc2. This is an extreme inconvenience to anyone testing
low power modes as the rtc wakealarm doesn't function. I'm a little
surprised more people haven't complained.
Please get this in 6.1.0-rc3.
> [1/1] rtc: rtc-cmos: Fix wake alarm breakage
> commit: 0782b66ed2fbb035dda76111df0954515e417b24
>
> Best regards,
>
next prev parent reply other threads:[~2022-10-25 15:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-18 16:09 [PATCH] rtc: rtc-cmos: Fix wake alarm breakage Rafael J. Wysocki
2022-10-18 16:38 ` Alexandre Belloni
2022-10-18 16:58 ` Len Brown
2022-10-18 19:11 ` Todd Brandt
2022-10-19 16:13 ` Rafael J. Wysocki
2022-10-19 18:16 ` Alexandre Belloni
2022-10-19 18:20 ` Rafael J. Wysocki
2022-10-25 15:28 ` Todd Brandt [this message]
2022-10-20 8:10 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=836b1787426d5b1569f6d77007a4765ee17d5ea6.camel@linux.intel.com \
--to=todd.e.brandt@linux.intel.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=helgaas@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=mgorman@techsingularity.net \
--cc=rjw@rjwysocki.net \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).