From: Ruslan Babayev <ruslan@babayev.com>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: Ruslan Babayev <ruslan@babayev.com>,
Wolfram Sang <wsa@the-dreams.de>,
xe-linux-external@cisco.com, linux-i2c@vger.kernel.org,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2 1/2] i2c: acpi: export i2c_acpi_find_adapter_by_handle
Date: Mon, 27 May 2019 19:26:53 -0700 [thread overview]
Message-ID: <8736kz9uvm.fsf@babayev.com> (raw)
In-Reply-To: <20190527083943.GX2781@lahna.fi.intel.com>
Mika Westerberg writes:
> On Fri, May 24, 2019 at 05:53:01PM -0700, Ruslan Babayev wrote:
>> +struct i2c_adapter *i2c_acpi_find_adapter_by_handle(acpi_handle handle);
>> #else
>> static inline bool i2c_acpi_get_i2c_resource(struct acpi_resource *ares,
>> struct acpi_resource_i2c_serialbus **i2c)
>> @@ -996,6 +998,10 @@ static inline struct i2c_client *i2c_acpi_new_device(struct device *dev,
>> {
>> return NULL;
>> }
>> +struct i2c_adapter *i2c_acpi_find_adapter_by_handle(acpi_handle handle)
>
> This should be static inline, I think.
>
>> +{
>> + return NULL;
>> +}
>> #endif /* CONFIG_ACPI */
>>
>> #endif /* _LINUX_I2C_H */
>> --
>> 2.17.1
Thanks Mika, will make the change and repost the patches.
next prev parent reply other threads:[~2019-05-28 2:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-05 19:34 [PATCH] net: phy: sfp: enable i2c-bus detection on ACPI based systems Ruslan Babayev
2019-05-05 19:34 ` Ruslan Babayev
2019-05-05 19:51 ` Heiner Kallweit
2019-05-05 19:51 ` Heiner Kallweit
2019-05-05 20:51 ` [PATCH 1/2] i2c: acpi: export i2c_acpi_find_adapter_by_handle Ruslan Babayev
2019-05-05 20:51 ` Ruslan Babayev
2019-05-25 0:53 ` [PATCH net-next v2 " Ruslan Babayev
2019-05-27 8:39 ` Mika Westerberg
2019-05-28 2:26 ` Ruslan Babayev [this message]
2019-05-27 18:47 ` Wolfram Sang
2019-05-28 2:03 ` Ruslan Babayev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8736kz9uvm.fsf@babayev.com \
--to=ruslan@babayev.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=wsa@the-dreams.de \
--cc=xe-linux-external@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).