From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5AF6C4332B for ; Fri, 20 Mar 2020 20:28:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 80A252072C for ; Fri, 20 Mar 2020 20:28:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727113AbgCTU2Z (ORCPT ); Fri, 20 Mar 2020 16:28:25 -0400 Received: from Galois.linutronix.de ([193.142.43.55]:37077 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726789AbgCTU2Y (ORCPT ); Fri, 20 Mar 2020 16:28:24 -0400 Received: from p5de0bf0b.dip0.t-ipconnect.de ([93.224.191.11] helo=nanos.tec.linutronix.de) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1jFOFL-0003Pp-8l; Fri, 20 Mar 2020 21:27:59 +0100 Received: by nanos.tec.linutronix.de (Postfix, from userid 1000) id 857A71039FC; Fri, 20 Mar 2020 21:27:58 +0100 (CET) From: Thomas Gleixner To: Andy Shevchenko Cc: LKML , "maintainer\:X86 ARCHITECTURE \(32-BIT AND 64-BIT\)" , Greg Kroah-Hartman , Mark Gross , Tony Luck , Paolo Bonzini , Darren Hart , Andy Shevchenko , "Rafael J. Wysocki" , Len Brown , ACPI Devel Maling List , Viresh Kumar , Linux PM , Srinivas Pandruvada , linux-edac@vger.kernel.org, Platform Driver , Jean Delvare , Guenter Roeck , linux-hwmon@vger.kernel.org, Zhang Rui , Daniel Lezcano , Amit Kucheria , Chanwoo Choi , Jacob Pan , Adrian Hunter , Ulf Hansson , linux-mmc , Bjorn Helgaas , linux-pci@vger.kernel.org, Takashi Iwai , ALSA Development Mailing List , Herbert Xu , "David S. Miller" , linux-crypto Subject: Re: [patch 02/22] x86/cpu: Add conistent CPU match macros In-Reply-To: References: <20200320131345.635023594@linutronix.de> <20200320131508.826011988@linutronix.de> Date: Fri, 20 Mar 2020 21:27:58 +0100 Message-ID: <87h7yipy9d.fsf@nanos.tec.linutronix.de> MIME-Version: 1.0 Content-Type: text/plain X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org Andy Shevchenko writes: > >> Also a add a few model constants for Centaur CPUs and QUARK. > > I would perhaps made this as a separate change(s). Can do. >> +#define X86_MATCH_VENDOR_FAM_MODEL_FEATURE(_vendor, _family, _model, \ >> + _feature, _data) { \ > > I would leave it on one line despite the length, but it's up to you. > >> + .vendor = X86_VENDOR_##_vendor, \ >> + .family = _family, \ >> + .model = _model, \ >> + .feature = _feature, \ > >> + .driver_data = (unsigned long) _data \ > > For sake of consistency shouldn't be this kernel_ulong_t ? I can change that though in kernel space this does not matter. > Or we are going to get rid of that type? No. Thanks, tglx