From: "Bjørn Mork" <bjorn@mork.no>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Linus Walleij <linus.walleij@linaro.org>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH v8 1/6] software node: rename is_array to is_inline
Date: Wed, 13 Nov 2019 07:52:43 +0100
Message-ID: <87woc4s1xg.fsf@miraculix.mork.no> (raw)
In-Reply-To: <20191108042225.45391-2-dmitry.torokhov@gmail.com> (Dmitry Torokhov's message of "Thu, 7 Nov 2019 20:22:20 -0800")
Dmitry Torokhov <dmitry.torokhov@gmail.com> writes:
> We do not need a special flag to know if we are dealing with an array,
> as we can get that data from ratio between element length and the data
> size, however we do need a flag to know whether the data is stored
> directly inside property_entry or separately.
Doesn't a non-null prop->pointer tell you this?
And inverting the flag is unnecessarily risky IMHO. An all-zero prop
might now result in dereferencing a NULL prop->pointer instead of using
the empty prop->value. Now I haven't looked at the code to see if this
is a real problem. But I believe it's better not having to do that
anyway...
Bjørn
next prev parent reply index
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-08 4:22 [PATCH v8 0/6] software node: add support for reference properties Dmitry Torokhov
2019-11-08 4:22 ` [PATCH v8 1/6] software node: rename is_array to is_inline Dmitry Torokhov
2019-11-08 9:49 ` Rafael J. Wysocki
2019-11-13 6:52 ` Bjørn Mork [this message]
2019-11-13 8:08 ` Dmitry Torokhov
[not found] ` <CGME20191212111237eucas1p1a278d2d5d2437e3219896367e82604cc@eucas1p1.samsung.com>
2019-12-12 11:12 ` Marek Szyprowski
2019-12-12 11:28 ` Andy Shevchenko
2019-12-12 16:41 ` Rafael J. Wysocki
2019-12-13 6:47 ` Marek Szyprowski
2019-12-13 8:37 ` Rafael J. Wysocki
2019-12-13 1:24 ` Dmitry Torokhov
2019-12-13 6:44 ` Marek Szyprowski
2019-11-08 4:22 ` [PATCH v8 2/6] software node: allow embedding of small arrays into property_entry Dmitry Torokhov
2019-11-08 4:22 ` [PATCH v8 3/6] software node: implement reference properties Dmitry Torokhov
[not found] ` <CGME20201109170241eucas1p14c2156334d8c6ef15d52664fa4776f41@eucas1p1.samsung.com>
2020-11-09 17:02 ` Lukasz Stelmach
2020-11-09 17:24 ` Andy Shevchenko
[not found] ` <CGME20201109181851eucas1p241de8938e399c0b603c764593b057c41@eucas1p2.samsung.com>
2020-11-09 18:18 ` Lukasz Stelmach
2020-11-09 18:53 ` Dmitry Torokhov
2020-11-09 19:05 ` Andy Shevchenko
2020-11-10 12:39 ` Heikki Krogerus
2020-11-10 12:46 ` Rafael J. Wysocki
[not found] ` <CGME20201109195504eucas1p19d493c947d8752e39c26202cf0978fc0@eucas1p1.samsung.com>
2020-11-09 19:54 ` Lukasz Stelmach
2020-11-09 19:02 ` Andy Shevchenko
[not found] ` <CGME20201109194725eucas1p2cc9357486879a14b2ad2f6ef968ff4b2@eucas1p2.samsung.com>
2020-11-09 19:47 ` Lukasz Stelmach
2020-11-09 21:20 ` Andy Shevchenko
2019-11-08 4:22 ` [PATCH v8 4/6] platform/x86: intel_cht_int33fe: use inline " Dmitry Torokhov
2019-11-08 4:22 ` [PATCH v8 5/6] software node: remove separate handling of references Dmitry Torokhov
2019-11-08 4:22 ` [PATCH v8 6/6] software node: add basic tests for property entries Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87woc4s1xg.fsf@miraculix.mork.no \
--to=bjorn@mork.no \
--cc=andriy.shevchenko@linux.intel.com \
--cc=ard.biesheuvel@linaro.org \
--cc=dmitry.torokhov@gmail.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Linux-ACPI Archive on lore.kernel.org
Archives are clonable:
git clone --mirror https://lore.kernel.org/linux-acpi/0 linux-acpi/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 linux-acpi linux-acpi/ https://lore.kernel.org/linux-acpi \
linux-acpi@vger.kernel.org
public-inbox-index linux-acpi
Example config snippet for mirrors
Newsgroup available over NNTP:
nntp://nntp.lore.kernel.org/org.kernel.vger.linux-acpi
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git