From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC836C3A5A5 for ; Tue, 3 Sep 2019 05:41:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CD76022CF7 for ; Tue, 3 Sep 2019 05:41:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726555AbfICFly (ORCPT ); Tue, 3 Sep 2019 01:41:54 -0400 Received: from metis.ext.pengutronix.de ([85.220.165.71]:44809 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725854AbfICFlw (ORCPT ); Tue, 3 Sep 2019 01:41:52 -0400 Received: from soja.hi.pengutronix.de ([2001:67c:670:100:3ad5:47ff:feaf:13da]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1i51Za-0005vB-Fx; Tue, 03 Sep 2019 07:41:46 +0200 Subject: Re: [PATCH] ACPI: support for NXP i2c controller To: Andy Shevchenko , "Rafael J. Wysocki" Cc: Chuanhua Han , Wolfram Sang , "Rafael J. Wysocki" , Len Brown , Shawn Guo , Sascha Hauer , ACPI Devel Maling List , Linux Kernel Mailing List , linux-i2c , Linux ARM , Leo Li , Meenakshi Aggarwal , Udit Kumar References: <20190711102601.20582-1-chuanhua.han@nxp.com> From: Oleksij Rempel Message-ID: <896b88d4-9d1b-922b-1784-55ef9a1a1830@pengutronix.de> Date: Tue, 3 Sep 2019 07:41:45 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:100:3ad5:47ff:feaf:13da X-SA-Exim-Mail-From: o.rempel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-acpi@vger.kernel.org Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org Hi, On 02.09.19 23:16, Andy Shevchenko wrote: > On Mon, Sep 2, 2019 at 11:58 PM Rafael J. Wysocki wrote: >> >> On Thu, Jul 11, 2019 at 12:35 PM Chuanhua Han wrote: >>> >>> Enable NXP i2c controller to boot with ACPI >>> >>> Signed-off-by: Meenakshi Aggarwal >>> Signed-off-by: Udit Kumar >>> Signed-off-by: Chuanhua Han >> >> Wolfram, any objections to this from the i2c side? > > May I propose amendment(s)? > >>> @@ -44,6 +44,7 @@ >>> #include >>> #include >>> #include > >>> +#include > > If it's kept in order, better to go with it. (Yes, it is as I have checked) > However, property.h should be included instead, see below. > >>> const struct of_device_id *of_id = of_match_device(i2c_imx_dt_ids, >>> &pdev->dev); >>> + const struct acpi_device_id *acpi_id = >>> + acpi_match_device(i2c_imx_acpi_ids, >>> + &pdev->dev); > > >>> if (of_id) >>> i2c_imx->hwdata = of_id->data; >>> + else if (acpi_id) >>> + i2c_imx->hwdata = (struct imx_i2c_hwdata *) >>> + acpi_id->driver_data; > > > The above altogher may be replaced with > > const struct imx_i2c_hwdata *match; > ... > match = device_get_match_data(&pdev->dev); > if (match) > i2c_imx->hwdata = match; > else > ... Instead of "may be replaced", I would say: it should be replaced :) >>> + .acpi_match_table = ACPI_PTR(i2c_imx_acpi_ids), > > Since there is no #ifdef guard no need to use ACPI_PTR(). > What iMX/(other NXP?) SoCs are with ACPI support? Where I can get one? I would like to know more about it. Kind regards, Oleksij Rempel -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |