From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E911C433E2 for ; Mon, 20 Jul 2020 01:19:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4D27C22B51 for ; Mon, 20 Jul 2020 01:19:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726510AbgGTBTB (ORCPT ); Sun, 19 Jul 2020 21:19:01 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:44993 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726225AbgGTBS6 (ORCPT ); Sun, 19 Jul 2020 21:18:58 -0400 Received: from mail-pg1-f197.google.com ([209.85.215.197]) by youngberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1jxKSF-00036E-OB for linux-acpi@vger.kernel.org; Mon, 20 Jul 2020 01:18:55 +0000 Received: by mail-pg1-f197.google.com with SMTP id e127so12710143pgc.2 for ; Sun, 19 Jul 2020 18:18:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=dTQyUG61kX2XCwIUiPSY5cCF6yJekK9Ymo10gmabLSw=; b=do335db8ioUN3Sw+USVExMhs4mlJBytVl5VMxirhuM5xp2NqRVWy/o9iGczlobpiMG y1lCN91TFcjWwwl5DpDT8s5XmBYFzmpcg3mgDVJ9JAmmXT+id95dZK386jNwTUzykl+W DgAu6rrU2kEOOFPzNtfIKyQ3JUbtioMTlF4O1FdyGm/zUV3PMFVg4TFuDnBEsgbexdsm ah7hX6S6FiuLht5CRZ7ugrgy5BznW642Bqo3PwzcOG+2q4dzkuXOC6M5ysTQHmSPkemE QTsefmwArj9LiZ1RFGfw/8Yne2mv0yqy/Z2kmnfeWrWVGlkM/uTM5/IIW9y3/anUlDsC b7IA== X-Gm-Message-State: AOAM5316LuuMl/8ea49geRvjDgXErAnqcU98QL+lGkSiGxJmikl5SGUZ mwuVn7Hi1QOS7FYR4SUD4o4ndwt3n9+TlWbE6ZptxIvxrx5NT9rmLyAaNcm3KqObbzsc+kzSpGB KOPYlflV+3zegNbtldEl4U8bzWhOb+iXCpIi7IS4= X-Received: by 2002:a65:490d:: with SMTP id p13mr16441325pgs.183.1595207934350; Sun, 19 Jul 2020 18:18:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwudbwMDOJLkji0WfrSzxkPuyTod60uCI/xIM8pY05aS+io4K0fWco4Zfmkc0P1TnvefU0aMw== X-Received: by 2002:a65:490d:: with SMTP id p13mr16441307pgs.183.1595207933994; Sun, 19 Jul 2020 18:18:53 -0700 (PDT) Received: from [192.168.0.119] (d66-222-144-129.abhsia.telus.net. [66.222.144.129]) by smtp.gmail.com with ESMTPSA id 15sm10012333pjs.8.2020.07.19.18.18.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 19 Jul 2020 18:18:53 -0700 (PDT) Subject: Re: [PATCH] RFC: ACPI / OSI: remove workarounds for hybrid graphics laptops To: Karol Herbst Cc: Linux ACPI Mailing List , "Rafael J. Wysocki" , Len Brown , Lyude Paul , LKML , dri-devel , nouveau References: <20200717190547.648604-1-kherbst@redhat.com> From: Alex Hung Message-ID: <8ad1866d-eb61-a30c-5875-5ffbfd2e17e1@canonical.com> Date: Sun, 19 Jul 2020 19:18:52 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On 2020-07-19 1:50 p.m., Karol Herbst wrote: > On Fri, Jul 17, 2020 at 9:52 PM Alex Hung wrote: >> >> On 2020-07-17 1:05 p.m., Karol Herbst wrote: >>> It's hard to figure out what systems are actually affected and right now I >>> don't see a good way of removing those... >>> >>> But I'd like to see thos getting removed and drivers fixed instead (which >>> happened at least for nouveau). >>> >>> And as mentioned before, I prefer people working on fixing issues instead >>> of spending time to add firmware level workarounds which are hard to know >>> to which systems they apply to, hard to remove and basically a big huge >>> pain to work with.> In the end I have no idea how to even figure out what systems are affected >>> and which not by this, so I have no idea how to even verify we can safely >>> remove this (which just means those are impossible to remove unless we risk >>> breaking systems, which again makes those supper annoying to deal with). >>> >>> Also from the comments it's hard to get what those bits really do. Are they >>> just preventing runtime pm or do the devices are powered down when booting? >>> I am sure it's the former, still... >>> >>> Please, don't do this again. >>> >>> For now, those workaround prevent power savings on systems those workaround >>> applies to, which might be any so those should get removed asap and if >>> new issues arrise removing those please do a proper bug report and we can >>> look into it and come up with a proper fix (and keep this patch out until >>> we resolve all of those). >>> >>> Signed-off-by: Karol Herbst >>> CC: Alex Hung >>> CC: "Rafael J. Wysocki" >>> CC: Len Brown >>> CC: Lyude Paul >>> CC: linux-kernel@vger.kernel.org >>> CC: dri-devel@lists.freedesktop.org >>> CC: nouveau@lists.freedesktop.org >>> --- >>> drivers/acpi/osi.c | 24 ------------------------ >>> 1 file changed, 24 deletions(-) >>> >>> diff --git a/drivers/acpi/osi.c b/drivers/acpi/osi.c >>> index 9f68538091384..d4405e1ca9b97 100644 >>> --- a/drivers/acpi/osi.c >>> +++ b/drivers/acpi/osi.c >>> @@ -44,30 +44,6 @@ osi_setup_entries[OSI_STRING_ENTRIES_MAX] __initdata = { >>> {"Processor Device", true}, >>> {"3.0 _SCP Extensions", true}, >>> {"Processor Aggregator Device", true}, >>> - /* >>> - * Linux-Dell-Video is used by BIOS to disable RTD3 for NVidia graphics >>> - * cards as RTD3 is not supported by drivers now. Systems with NVidia >>> - * cards will hang without RTD3 disabled. >>> - * >>> - * Once NVidia drivers officially support RTD3, this _OSI strings can >>> - * be removed if both new and old graphics cards are supported. >>> - */ >>> - {"Linux-Dell-Video", true}, >>> - /* >>> - * Linux-Lenovo-NV-HDMI-Audio is used by BIOS to power on NVidia's HDMI >>> - * audio device which is turned off for power-saving in Windows OS. >>> - * This power management feature observed on some Lenovo Thinkpad >>> - * systems which will not be able to output audio via HDMI without >>> - * a BIOS workaround. >>> - */ >>> - {"Linux-Lenovo-NV-HDMI-Audio", true}, >>> - /* >>> - * Linux-HPI-Hybrid-Graphics is used by BIOS to enable dGPU to >>> - * output video directly to external monitors on HP Inc. mobile >>> - * workstations as Nvidia and AMD VGA drivers provide limited >>> - * hybrid graphics supports. >>> - */ >>> - {"Linux-HPI-Hybrid-Graphics", true}, >>> }; >>> >>> static u32 acpi_osi_handler(acpi_string interface, u32 supported) >>> >> >> The changes were discussed and tested a while ago, and no crashes were >> observed. Thanks for solving PM issues in nouveau. >> >> Acked-by: Alex Hung >> > > By any chance, do you have a list of systems implementing those workarounds? > I don't keep a list but the workaround, in theory, should only apply to the systems with the specific nvidia hardware. I reminded OEMs and ODMs that these _OSI strings were temporary solutions, and highlighted we were going to remove them after our discussion last year. If they were paying attentions recent systems shouldn't have these _OSI strings. -- Cheers, Alex Hung